* [PATCH 0/7] Cocci spatch "vma_pages" - v4.14-rc1
@ 2017-09-20 22:29 Thomas Meyer
2017-09-20 22:29 ` Thomas Meyer
` (6 more replies)
0 siblings, 7 replies; 30+ messages in thread
From: Thomas Meyer @ 2017-09-20 22:29 UTC (permalink / raw)
To: linux-kernel
Use vma_pages function on vma object instead of explicit computation.
Found by coccinelle spatch "api/vma_pages.cocci"
Run against version v4.14-rc1
Let me know when you as a maintainer are not interested in these kind of patches.
I can exclude you by path; e.g. all findings in "drivers/scsi" will never
be reported again by this semi-automatic program runs.
^ permalink raw reply [flat|nested] 30+ messages in thread* [PATCH 1/7] ARM: dma-mapping: Cocci spatch "vma_pages" 2017-09-20 22:29 [PATCH 0/7] Cocci spatch "vma_pages" - v4.14-rc1 Thomas Meyer @ 2017-09-20 22:29 ` Thomas Meyer 2017-09-20 22:29 ` [PATCH 5/7] MIPS: " Thomas Meyer ` (5 subsequent siblings) 6 siblings, 0 replies; 30+ messages in thread From: Thomas Meyer @ 2017-09-20 22:29 UTC (permalink / raw) To: linux, linux-arm-kernel, linux-kernel Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Thomas Meyer <thomas@m3y3r.de> --- diff -u -p a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c --- a/arch/arm/mm/dma-mapping.c +++ b/arch/arm/mm/dma-mapping.c @@ -846,7 +846,7 @@ static int __arm_dma_mmap(struct device unsigned long attrs) { int ret; - unsigned long nr_vma_pages = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; + unsigned long nr_vma_pages = vma_pages(vma); unsigned long nr_pages = PAGE_ALIGN(size) >> PAGE_SHIFT; unsigned long pfn = dma_to_pfn(dev, dma_addr); unsigned long off = vma->vm_pgoff; ^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 1/7] ARM: dma-mapping: Cocci spatch "vma_pages" @ 2017-09-20 22:29 ` Thomas Meyer 0 siblings, 0 replies; 30+ messages in thread From: Thomas Meyer @ 2017-09-20 22:29 UTC (permalink / raw) To: linux-arm-kernel Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Thomas Meyer <thomas@m3y3r.de> --- diff -u -p a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c --- a/arch/arm/mm/dma-mapping.c +++ b/arch/arm/mm/dma-mapping.c @@ -846,7 +846,7 @@ static int __arm_dma_mmap(struct device unsigned long attrs) { int ret; - unsigned long nr_vma_pages = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; + unsigned long nr_vma_pages = vma_pages(vma); unsigned long nr_pages = PAGE_ALIGN(size) >> PAGE_SHIFT; unsigned long pfn = dma_to_pfn(dev, dma_addr); unsigned long off = vma->vm_pgoff; ^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 5/7] MIPS: Cocci spatch "vma_pages" 2017-09-20 22:29 [PATCH 0/7] Cocci spatch "vma_pages" - v4.14-rc1 Thomas Meyer 2017-09-20 22:29 ` Thomas Meyer @ 2017-09-20 22:29 ` Thomas Meyer 2017-09-20 22:29 ` [PATCH 4/7] microblaze: " Thomas Meyer ` (4 subsequent siblings) 6 siblings, 0 replies; 30+ messages in thread From: Thomas Meyer @ 2017-09-20 22:29 UTC (permalink / raw) To: ralf, linux-mips, linux-kernel Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Thomas Meyer <thomas@m3y3r.de> --- diff -u -p a/arch/mips/mm/dma-default.c b/arch/mips/mm/dma-default.c --- a/arch/mips/mm/dma-default.c +++ b/arch/mips/mm/dma-default.c @@ -179,7 +179,7 @@ static int mips_dma_mmap(struct device * void *cpu_addr, dma_addr_t dma_addr, size_t size, unsigned long attrs) { - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; + unsigned long user_count = vma_pages(vma); unsigned long count = PAGE_ALIGN(size) >> PAGE_SHIFT; unsigned long addr = (unsigned long)cpu_addr; unsigned long off = vma->vm_pgoff; ^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 4/7] microblaze: Cocci spatch "vma_pages" 2017-09-20 22:29 [PATCH 0/7] Cocci spatch "vma_pages" - v4.14-rc1 Thomas Meyer 2017-09-20 22:29 ` Thomas Meyer 2017-09-20 22:29 ` [PATCH 5/7] MIPS: " Thomas Meyer @ 2017-09-20 22:29 ` Thomas Meyer 2017-09-25 13:37 ` Michal Simek 2017-09-20 22:29 ` Thomas Meyer ` (3 subsequent siblings) 6 siblings, 1 reply; 30+ messages in thread From: Thomas Meyer @ 2017-09-20 22:29 UTC (permalink / raw) To: monstr, linux-kernel Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Thomas Meyer <thomas@m3y3r.de> --- diff -u -p a/arch/microblaze/kernel/dma.c b/arch/microblaze/kernel/dma.c --- a/arch/microblaze/kernel/dma.c +++ b/arch/microblaze/kernel/dma.c @@ -165,7 +165,7 @@ int dma_direct_mmap_coherent(struct devi unsigned long attrs) { #ifdef CONFIG_MMU - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; + unsigned long user_count = vma_pages(vma); unsigned long count = PAGE_ALIGN(size) >> PAGE_SHIFT; unsigned long off = vma->vm_pgoff; unsigned long pfn; ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 4/7] microblaze: Cocci spatch "vma_pages" 2017-09-20 22:29 ` [PATCH 4/7] microblaze: " Thomas Meyer @ 2017-09-25 13:37 ` Michal Simek 0 siblings, 0 replies; 30+ messages in thread From: Michal Simek @ 2017-09-25 13:37 UTC (permalink / raw) To: Thomas Meyer, linux-kernel [-- Attachment #1.1: Type: text/plain, Size: 1076 bytes --] On 21.9.2017 00:29, Thomas Meyer wrote: > Use vma_pages function on vma object instead of explicit computation. > Found by coccinelle spatch "api/vma_pages.cocci" > > Signed-off-by: Thomas Meyer <thomas@m3y3r.de> > --- > > diff -u -p a/arch/microblaze/kernel/dma.c b/arch/microblaze/kernel/dma.c > --- a/arch/microblaze/kernel/dma.c > +++ b/arch/microblaze/kernel/dma.c > @@ -165,7 +165,7 @@ int dma_direct_mmap_coherent(struct devi > unsigned long attrs) > { > #ifdef CONFIG_MMU > - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; > + unsigned long user_count = vma_pages(vma); > unsigned long count = PAGE_ALIGN(size) >> PAGE_SHIFT; > unsigned long off = vma->vm_pgoff; > unsigned long pfn; > Applied to mb/next. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" 2017-09-20 22:29 [PATCH 0/7] Cocci spatch "vma_pages" - v4.14-rc1 Thomas Meyer @ 2017-09-20 22:29 ` Thomas Meyer 2017-09-20 22:29 ` [PATCH 5/7] MIPS: " Thomas Meyer ` (5 subsequent siblings) 6 siblings, 0 replies; 30+ messages in thread From: Thomas Meyer @ 2017-09-20 22:29 UTC (permalink / raw) To: mark.yao, airlied, heiko, dri-devel, linux-arm-kernel, linux-rockchip, linux-kernel Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Thomas Meyer <thomas@m3y3r.de> --- diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_ { struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj); unsigned int i, count = obj->size >> PAGE_SHIFT; - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; + unsigned long user_count = vma_pages(vma); unsigned long uaddr = vma->vm_start; unsigned long offset = vma->vm_pgoff; unsigned long end = user_count + offset; ^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" @ 2017-09-20 22:29 ` Thomas Meyer 0 siblings, 0 replies; 30+ messages in thread From: Thomas Meyer @ 2017-09-20 22:29 UTC (permalink / raw) To: linux-arm-kernel Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Thomas Meyer <thomas@m3y3r.de> --- diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_ { struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj); unsigned int i, count = obj->size >> PAGE_SHIFT; - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; + unsigned long user_count = vma_pages(vma); unsigned long uaddr = vma->vm_start; unsigned long offset = vma->vm_pgoff; unsigned long end = user_count + offset; ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" 2017-09-20 22:29 ` Thomas Meyer (?) @ 2017-09-21 1:02 ` Mark yao -1 siblings, 0 replies; 30+ messages in thread From: Mark yao @ 2017-09-21 1:02 UTC (permalink / raw) To: Thomas Meyer, airlied, heiko, dri-devel, linux-arm-kernel, linux-rockchip, linux-kernel On 2017年09月21日 06:29, Thomas Meyer wrote: > Use vma_pages function on vma object instead of explicit computation. > Found by coccinelle spatch "api/vma_pages.cocci" > > Signed-off-by: Thomas Meyer <thomas@m3y3r.de> > --- Looks good for me: Acked-by: Mark Yao <mark.yao@rock-chips.com> > > diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_ > { > struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj); > unsigned int i, count = obj->size >> PAGE_SHIFT; > - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; > + unsigned long user_count = vma_pages(vma); > unsigned long uaddr = vma->vm_start; > unsigned long offset = vma->vm_pgoff; > unsigned long end = user_count + offset; > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > > -- Ｍark Yao ^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" @ 2017-09-21 1:02 ` Mark yao 0 siblings, 0 replies; 30+ messages in thread From: Mark yao @ 2017-09-21 1:02 UTC (permalink / raw) To: linux-arm-kernel On 2017?09?21? 06:29, Thomas Meyer wrote: > Use vma_pages function on vma object instead of explicit computation. > Found by coccinelle spatch "api/vma_pages.cocci" > > Signed-off-by: Thomas Meyer <thomas@m3y3r.de> > --- Looks good for me: Acked-by: Mark Yao <mark.yao@rock-chips.com> > > diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_ > { > struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj); > unsigned int i, count = obj->size >> PAGE_SHIFT; > - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; > + unsigned long user_count = vma_pages(vma); > unsigned long uaddr = vma->vm_start; > unsigned long offset = vma->vm_pgoff; > unsigned long end = user_count + offset; > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > > -- ?ark Yao ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" @ 2017-09-21 1:02 ` Mark yao 0 siblings, 0 replies; 30+ messages in thread From: Mark yao @ 2017-09-21 1:02 UTC (permalink / raw) To: Thomas Meyer, airlied, heiko, dri-devel, linux-arm-kernel, linux-rockchip, linux-kernel On 2017年09月21日 06:29, Thomas Meyer wrote: > Use vma_pages function on vma object instead of explicit computation. > Found by coccinelle spatch "api/vma_pages.cocci" > > Signed-off-by: Thomas Meyer <thomas@m3y3r.de> > --- Looks good for me: Acked-by: Mark Yao <mark.yao@rock-chips.com> > > diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_ > { > struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj); > unsigned int i, count = obj->size >> PAGE_SHIFT; > - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; > + unsigned long user_count = vma_pages(vma); > unsigned long uaddr = vma->vm_start; > unsigned long offset = vma->vm_pgoff; > unsigned long end = user_count + offset; > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > > -- Ｍark Yao _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" 2017-09-21 1:02 ` Mark yao (?) @ 2017-09-26 5:12 ` Daniel Vetter -1 siblings, 0 replies; 30+ messages in thread From: Daniel Vetter @ 2017-09-26 5:12 UTC (permalink / raw) To: Mark yao Cc: Thomas Meyer, airlied, heiko, dri-devel, linux-arm-kernel, linux-rockchip, linux-kernel On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote: > On 2017年09月21日 06:29, Thomas Meyer wrote: > > Use vma_pages function on vma object instead of explicit computation. > > Found by coccinelle spatch "api/vma_pages.cocci" > > > > Signed-off-by: Thomas Meyer <thomas@m3y3r.de> > > --- > Looks good for me: > Acked-by: Mark Yao <mark.yao@rock-chips.com> Once more a maintainer who acks a patch and doesn't push it. This is really confusing, who exactly do you expect to handle this patch for you? Please push to drm-misc-next (also for future patches), thanks. -Daniel > > > > > diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_ > > { > > struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj); > > unsigned int i, count = obj->size >> PAGE_SHIFT; > > - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; > > + unsigned long user_count = vma_pages(vma); > > unsigned long uaddr = vma->vm_start; > > unsigned long offset = vma->vm_pgoff; > > unsigned long end = user_count + offset; > > > > _______________________________________________ > > Linux-rockchip mailing list > > Linux-rockchip@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > > > > > > > -- > Ｍark Yao > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" @ 2017-09-26 5:12 ` Daniel Vetter 0 siblings, 0 replies; 30+ messages in thread From: Daniel Vetter @ 2017-09-26 5:12 UTC (permalink / raw) To: linux-arm-kernel On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote: > On 2017?09?21? 06:29, Thomas Meyer wrote: > > Use vma_pages function on vma object instead of explicit computation. > > Found by coccinelle spatch "api/vma_pages.cocci" > > > > Signed-off-by: Thomas Meyer <thomas@m3y3r.de> > > --- > Looks good for me: > Acked-by: Mark Yao <mark.yao@rock-chips.com> Once more a maintainer who acks a patch and doesn't push it. This is really confusing, who exactly do you expect to handle this patch for you? Please push to drm-misc-next (also for future patches), thanks. -Daniel > > > > > diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_ > > { > > struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj); > > unsigned int i, count = obj->size >> PAGE_SHIFT; > > - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; > > + unsigned long user_count = vma_pages(vma); > > unsigned long uaddr = vma->vm_start; > > unsigned long offset = vma->vm_pgoff; > > unsigned long end = user_count + offset; > > > > _______________________________________________ > > Linux-rockchip mailing list > > Linux-rockchip at lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > > > > > > > -- > ?ark Yao > > > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" @ 2017-09-26 5:12 ` Daniel Vetter 0 siblings, 0 replies; 30+ messages in thread From: Daniel Vetter @ 2017-09-26 5:12 UTC (permalink / raw) To: Mark yao Cc: linux-kernel, dri-devel, linux-rockchip, linux-arm-kernel, Thomas Meyer On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote: > On 2017年09月21日 06:29, Thomas Meyer wrote: > > Use vma_pages function on vma object instead of explicit computation. > > Found by coccinelle spatch "api/vma_pages.cocci" > > > > Signed-off-by: Thomas Meyer <thomas@m3y3r.de> > > --- > Looks good for me: > Acked-by: Mark Yao <mark.yao@rock-chips.com> Once more a maintainer who acks a patch and doesn't push it. This is really confusing, who exactly do you expect to handle this patch for you? Please push to drm-misc-next (also for future patches), thanks. -Daniel > > > > > diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_ > > { > > struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj); > > unsigned int i, count = obj->size >> PAGE_SHIFT; > > - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; > > + unsigned long user_count = vma_pages(vma); > > unsigned long uaddr = vma->vm_start; > > unsigned long offset = vma->vm_pgoff; > > unsigned long end = user_count + offset; > > > > _______________________________________________ > > Linux-rockchip mailing list > > Linux-rockchip@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > > > > > > > -- > Ｍark Yao > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" 2017-09-26 5:12 ` Daniel Vetter (?) @ 2017-09-26 6:33 ` Mark yao -1 siblings, 0 replies; 30+ messages in thread From: Mark yao @ 2017-09-26 6:33 UTC (permalink / raw) To: Thomas Meyer, airlied, heiko, dri-devel, linux-arm-kernel, linux-rockchip, linux-kernel On 2017年09月26日 13:12, Daniel Vetter wrote: > On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote: >> On 2017年09月21日 06:29, Thomas Meyer wrote: >>> Use vma_pages function on vma object instead of explicit computation. >>> Found by coccinelle spatch "api/vma_pages.cocci" >>> >>> Signed-off-by: Thomas Meyer <thomas@m3y3r.de> >>> --- >> Looks good for me: >> Acked-by: Mark Yao <mark.yao@rock-chips.com> > Once more a maintainer who acks a patch and doesn't push it. This is > really confusing, who exactly do you expect to handle this patch for you? > > Please push to drm-misc-next (also for future patches), thanks. > -Daniel Hi Daniel I Saw the patch title is "[PATCH 7/7]", I guessed it's one of a series of patches and maybe it can pushed by series. Ok, Pushed it to drm-misc-next. > >>> diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c >>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c >>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c >>> @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_ >>> { >>> struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj); >>> unsigned int i, count = obj->size >> PAGE_SHIFT; >>> - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; >>> + unsigned long user_count = vma_pages(vma); >>> unsigned long uaddr = vma->vm_start; >>> unsigned long offset = vma->vm_pgoff; >>> unsigned long end = user_count + offset; >>> >>> _______________________________________________ >>> Linux-rockchip mailing list >>> Linux-rockchip@lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/linux-rockchip >>> >>> >>> >> -- >> Ｍark Yao >> >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ｍark Ya ^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" @ 2017-09-26 6:33 ` Mark yao 0 siblings, 0 replies; 30+ messages in thread From: Mark yao @ 2017-09-26 6:33 UTC (permalink / raw) To: linux-arm-kernel On 2017?09?26? 13:12, Daniel Vetter wrote: > On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote: >> On 2017?09?21? 06:29, Thomas Meyer wrote: >>> Use vma_pages function on vma object instead of explicit computation. >>> Found by coccinelle spatch "api/vma_pages.cocci" >>> >>> Signed-off-by: Thomas Meyer <thomas@m3y3r.de> >>> --- >> Looks good for me: >> Acked-by: Mark Yao <mark.yao@rock-chips.com> > Once more a maintainer who acks a patch and doesn't push it. This is > really confusing, who exactly do you expect to handle this patch for you? > > Please push to drm-misc-next (also for future patches), thanks. > -Daniel Hi Daniel I Saw the patch title is "[PATCH 7/7]", I guessed it's one of a series of patches and maybe it can pushed by series. Ok, Pushed it to drm-misc-next. > >>> diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c >>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c >>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c >>> @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_ >>> { >>> struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj); >>> unsigned int i, count = obj->size >> PAGE_SHIFT; >>> - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; >>> + unsigned long user_count = vma_pages(vma); >>> unsigned long uaddr = vma->vm_start; >>> unsigned long offset = vma->vm_pgoff; >>> unsigned long end = user_count + offset; >>> >>> _______________________________________________ >>> Linux-rockchip mailing list >>> Linux-rockchip at lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/linux-rockchip >>> >>> >>> >> -- >> ?ark Yao >> >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel at lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel -- ?ark Ya ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" @ 2017-09-26 6:33 ` Mark yao 0 siblings, 0 replies; 30+ messages in thread From: Mark yao @ 2017-09-26 6:33 UTC (permalink / raw) To: Thomas Meyer, airlied, heiko, dri-devel, linux-arm-kernel, linux-rockchip, linux-kernel On 2017年09月26日 13:12, Daniel Vetter wrote: > On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote: >> On 2017年09月21日 06:29, Thomas Meyer wrote: >>> Use vma_pages function on vma object instead of explicit computation. >>> Found by coccinelle spatch "api/vma_pages.cocci" >>> >>> Signed-off-by: Thomas Meyer <thomas@m3y3r.de> >>> --- >> Looks good for me: >> Acked-by: Mark Yao <mark.yao@rock-chips.com> > Once more a maintainer who acks a patch and doesn't push it. This is > really confusing, who exactly do you expect to handle this patch for you? > > Please push to drm-misc-next (also for future patches), thanks. > -Daniel Hi Daniel I Saw the patch title is "[PATCH 7/7]", I guessed it's one of a series of patches and maybe it can pushed by series. Ok, Pushed it to drm-misc-next. > >>> diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c >>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c >>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c >>> @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_ >>> { >>> struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj); >>> unsigned int i, count = obj->size >> PAGE_SHIFT; >>> - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; >>> + unsigned long user_count = vma_pages(vma); >>> unsigned long uaddr = vma->vm_start; >>> unsigned long offset = vma->vm_pgoff; >>> unsigned long end = user_count + offset; >>> >>> _______________________________________________ >>> Linux-rockchip mailing list >>> Linux-rockchip@lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/linux-rockchip >>> >>> >>> >> -- >> Ｍark Yao >> >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ｍark Ya _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" 2017-09-26 6:33 ` Mark yao (?) @ 2017-09-26 8:08 ` Daniel Vetter -1 siblings, 0 replies; 30+ messages in thread From: Daniel Vetter @ 2017-09-26 8:08 UTC (permalink / raw) To: Mark yao Cc: Thomas Meyer, airlied, heiko, dri-devel, linux-arm-kernel, linux-rockchip, linux-kernel On Tue, Sep 26, 2017 at 02:33:07PM +0800, Mark yao wrote: > On 2017年09月26日 13:12, Daniel Vetter wrote: > > On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote: > > > On 2017年09月21日 06:29, Thomas Meyer wrote: > > > > Use vma_pages function on vma object instead of explicit computation. > > > > Found by coccinelle spatch "api/vma_pages.cocci" > > > > > > > > Signed-off-by: Thomas Meyer <thomas@m3y3r.de> > > > > --- > > > Looks good for me: > > > Acked-by: Mark Yao <mark.yao@rock-chips.com> > > Once more a maintainer who acks a patch and doesn't push it. This is > > really confusing, who exactly do you expect to handle this patch for you? > > > > Please push to drm-misc-next (also for future patches), thanks. > > -Daniel > > Hi Daniel > I Saw the patch title is "[PATCH 7/7]", I guessed it's one of a series of patches and maybe it can pushed by series. > > Ok, Pushed it to drm-misc-next. Hm right, but I only see 7/7 here. Either way, except when the author asks for a preferred tree it's best if you just pick things up right away. And if you're unsure, just ask instead of risking that a patch drops through the cracks. -Daniel > > > > > > > diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > > > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > > > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > > > @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_ > > > > { > > > > struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj); > > > > unsigned int i, count = obj->size >> PAGE_SHIFT; > > > > - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; > > > > + unsigned long user_count = vma_pages(vma); > > > > unsigned long uaddr = vma->vm_start; > > > > unsigned long offset = vma->vm_pgoff; > > > > unsigned long end = user_count + offset; > > > > > > > > _______________________________________________ > > > > Linux-rockchip mailing list > > > > Linux-rockchip@lists.infradead.org > > > > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > > > > > > > > > > > > > > -- > > > Ｍark Yao > > > > > > > > > _______________________________________________ > > > dri-devel mailing list > > > dri-devel@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > -- > Ｍark Ya > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" @ 2017-09-26 8:08 ` Daniel Vetter 0 siblings, 0 replies; 30+ messages in thread From: Daniel Vetter @ 2017-09-26 8:08 UTC (permalink / raw) To: linux-arm-kernel On Tue, Sep 26, 2017 at 02:33:07PM +0800, Mark yao wrote: > On 2017?09?26? 13:12, Daniel Vetter wrote: > > On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote: > > > On 2017?09?21? 06:29, Thomas Meyer wrote: > > > > Use vma_pages function on vma object instead of explicit computation. > > > > Found by coccinelle spatch "api/vma_pages.cocci" > > > > > > > > Signed-off-by: Thomas Meyer <thomas@m3y3r.de> > > > > --- > > > Looks good for me: > > > Acked-by: Mark Yao <mark.yao@rock-chips.com> > > Once more a maintainer who acks a patch and doesn't push it. This is > > really confusing, who exactly do you expect to handle this patch for you? > > > > Please push to drm-misc-next (also for future patches), thanks. > > -Daniel > > Hi Daniel > I Saw the patch title is "[PATCH 7/7]", I guessed it's one of a series of patches and maybe it can pushed by series. > > Ok, Pushed it to drm-misc-next. Hm right, but I only see 7/7 here. Either way, except when the author asks for a preferred tree it's best if you just pick things up right away. And if you're unsure, just ask instead of risking that a patch drops through the cracks. -Daniel > > > > > > > diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > > > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > > > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > > > @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_ > > > > { > > > > struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj); > > > > unsigned int i, count = obj->size >> PAGE_SHIFT; > > > > - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; > > > > + unsigned long user_count = vma_pages(vma); > > > > unsigned long uaddr = vma->vm_start; > > > > unsigned long offset = vma->vm_pgoff; > > > > unsigned long end = user_count + offset; > > > > > > > > _______________________________________________ > > > > Linux-rockchip mailing list > > > > Linux-rockchip at lists.infradead.org > > > > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > > > > > > > > > > > > > > -- > > > ?ark Yao > > > > > > > > > _______________________________________________ > > > dri-devel mailing list > > > dri-devel at lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > -- > ?ark Ya > > > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" @ 2017-09-26 8:08 ` Daniel Vetter 0 siblings, 0 replies; 30+ messages in thread From: Daniel Vetter @ 2017-09-26 8:08 UTC (permalink / raw) To: Mark yao Cc: linux-kernel, dri-devel, linux-rockchip, linux-arm-kernel, Thomas Meyer On Tue, Sep 26, 2017 at 02:33:07PM +0800, Mark yao wrote: > On 2017年09月26日 13:12, Daniel Vetter wrote: > > On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote: > > > On 2017年09月21日 06:29, Thomas Meyer wrote: > > > > Use vma_pages function on vma object instead of explicit computation. > > > > Found by coccinelle spatch "api/vma_pages.cocci" > > > > > > > > Signed-off-by: Thomas Meyer <thomas@m3y3r.de> > > > > --- > > > Looks good for me: > > > Acked-by: Mark Yao <mark.yao@rock-chips.com> > > Once more a maintainer who acks a patch and doesn't push it. This is > > really confusing, who exactly do you expect to handle this patch for you? > > > > Please push to drm-misc-next (also for future patches), thanks. > > -Daniel > > Hi Daniel > I Saw the patch title is "[PATCH 7/7]", I guessed it's one of a series of patches and maybe it can pushed by series. > > Ok, Pushed it to drm-misc-next. Hm right, but I only see 7/7 here. Either way, except when the author asks for a preferred tree it's best if you just pick things up right away. And if you're unsure, just ask instead of risking that a patch drops through the cracks. -Daniel > > > > > > > diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > > > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > > > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > > > > @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_ > > > > { > > > > struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj); > > > > unsigned int i, count = obj->size >> PAGE_SHIFT; > > > > - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; > > > > + unsigned long user_count = vma_pages(vma); > > > > unsigned long uaddr = vma->vm_start; > > > > unsigned long offset = vma->vm_pgoff; > > > > unsigned long end = user_count + offset; > > > > > > > > _______________________________________________ > > > > Linux-rockchip mailing list > > > > Linux-rockchip@lists.infradead.org > > > > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > > > > > > > > > > > > > > -- > > > Ｍark Yao > > > > > > > > > _______________________________________________ > > > dri-devel mailing list > > > dri-devel@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > -- > Ｍark Ya > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages" 2017-09-26 8:08 ` Daniel Vetter (?) (?) @ 2017-09-26 9:06 ` Mark yao -1 siblings, 0 replies; 30+ messages in thread From: Mark yao @ 2017-09-26 9:06 UTC (permalink / raw) To: Thomas Meyer, airlied, heiko, dri-devel, linux-arm-kernel, linux-rockchip, linux-kernel On 2017年09月26日 16:08, Daniel Vetter wrote: > On Tue, Sep 26, 2017 at 02:33:07PM +0800, Mark yao wrote: >> On 2017年09月26日 13:12, Daniel Vetter wrote: >>> On Thu, Sep 21, 2017 at 09:02:22AM +0800, Mark yao wrote: >>>> On 2017年09月21日 06:29, Thomas Meyer wrote: >>>>> Use vma_pages function on vma object instead of explicit computation. >>>>> Found by coccinelle spatch "api/vma_pages.cocci" >>>>> >>>>> Signed-off-by: Thomas Meyer <thomas@m3y3r.de> >>>>> --- >>>> Looks good for me: >>>> Acked-by: Mark Yao <mark.yao@rock-chips.com> >>> Once more a maintainer who acks a patch and doesn't push it. This is >>> really confusing, who exactly do you expect to handle this patch for you? >>> >>> Please push to drm-misc-next (also for future patches), thanks. >>> -Daniel >> Hi Daniel >> I Saw the patch title is "[PATCH 7/7]", I guessed it's one of a series of patches and maybe it can pushed by series. >> >> Ok, Pushed it to drm-misc-next. > Hm right, but I only see 7/7 here. Either way, except when the author asks > for a preferred tree it's best if you just pick things up right away. And > if you're unsure, just ask instead of risking that a patch drops through > the cracks. > -Daniel Okay, I'll keep it in mind next time. Thanks Mark > >>>>> diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c >>>>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c >>>>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c >>>>> @@ -220,7 +220,7 @@ static int rockchip_drm_gem_object_mmap_ >>>>> { >>>>> struct rockchip_gem_object *rk_obj = to_rockchip_obj(obj); >>>>> unsigned int i, count = obj->size >> PAGE_SHIFT; >>>>> - unsigned long user_count = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; >>>>> + unsigned long user_count = vma_pages(vma); >>>>> unsigned long uaddr = vma->vm_start; >>>>> unsigned long offset = vma->vm_pgoff; >>>>> unsigned long end = user_count + offset; >>>>> >>>>> _______________________________________________ >>>>> Linux-rockchip mailing list >>>>> Linux-rockchip@lists.infradead.org >>>>> http://lists.infradead.org/mailman/listinfo/linux-rockchip >>>>> >>>>> >>>>> >>>> -- >>>> Ｍark Yao >>>> >>>> >>>> _______________________________________________ >>>> dri-devel mailing list >>>> dri-devel@lists.freedesktop.org >>>> https://lists.freedesktop.org/mailman/listinfo/dri-devel >> >> -- >> Ｍark Ya >> >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 3/7] metag: Cocci spatch "vma_pages" 2017-09-20 22:29 [PATCH 0/7] Cocci spatch "vma_pages" - v4.14-rc1 Thomas Meyer ` (3 preceding siblings ...) 2017-09-20 22:29 ` Thomas Meyer @ 2017-09-20 22:29 ` Thomas Meyer 2017-09-20 22:29 ` Thomas Meyer 2017-09-20 22:29 ` Thomas Meyer 6 siblings, 0 replies; 30+ messages in thread From: Thomas Meyer @ 2017-09-20 22:29 UTC (permalink / raw) To: linux-metag, linux-kernel Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Thomas Meyer <thomas@m3y3r.de> --- diff -u -p a/arch/metag/kernel/dma.c b/arch/metag/kernel/dma.c --- a/arch/metag/kernel/dma.c +++ b/arch/metag/kernel/dma.c @@ -342,7 +342,7 @@ static int metag_dma_mmap(struct device else vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot); - user_size = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; + user_size = vma_pages(vma); spin_lock_irqsave(&consistent_lock, flags); c = metag_vm_region_find(&consistent_head, (unsigned long)cpu_addr); ^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 2/7] arm64: Cocci spatch "vma_pages" 2017-09-20 22:29 [PATCH 0/7] Cocci spatch "vma_pages" - v4.14-rc1 Thomas Meyer @ 2017-09-20 22:29 ` Thomas Meyer 2017-09-20 22:29 ` [PATCH 5/7] MIPS: " Thomas Meyer ` (5 subsequent siblings) 6 siblings, 0 replies; 30+ messages in thread From: Thomas Meyer @ 2017-09-20 22:29 UTC (permalink / raw) To: catalin.marinas, will.deacon, linux-arm-kernel, linux-kernel Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Thomas Meyer <thomas@m3y3r.de> --- diff -u -p a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c --- a/arch/arm64/mm/dma-mapping.c +++ b/arch/arm64/mm/dma-mapping.c @@ -303,8 +303,7 @@ static int __swiotlb_mmap_pfn(struct vm_ unsigned long pfn, size_t size) { int ret = -ENXIO; - unsigned long nr_vma_pages = (vma->vm_end - vma->vm_start) >> - PAGE_SHIFT; + unsigned long nr_vma_pages = vma_pages(vma); unsigned long nr_pages = PAGE_ALIGN(size) >> PAGE_SHIFT; unsigned long off = vma->vm_pgoff; ^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 2/7] arm64: Cocci spatch "vma_pages" @ 2017-09-20 22:29 ` Thomas Meyer 0 siblings, 0 replies; 30+ messages in thread From: Thomas Meyer @ 2017-09-20 22:29 UTC (permalink / raw) To: linux-arm-kernel Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Thomas Meyer <thomas@m3y3r.de> --- diff -u -p a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c --- a/arch/arm64/mm/dma-mapping.c +++ b/arch/arm64/mm/dma-mapping.c @@ -303,8 +303,7 @@ static int __swiotlb_mmap_pfn(struct vm_ unsigned long pfn, size_t size) { int ret = -ENXIO; - unsigned long nr_vma_pages = (vma->vm_end - vma->vm_start) >> - PAGE_SHIFT; + unsigned long nr_vma_pages = vma_pages(vma); unsigned long nr_pages = PAGE_ALIGN(size) >> PAGE_SHIFT; unsigned long off = vma->vm_pgoff; ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 2/7] arm64: Cocci spatch "vma_pages" 2017-09-20 22:29 ` Thomas Meyer @ 2017-09-26 11:57 ` Robin Murphy -1 siblings, 0 replies; 30+ messages in thread From: Robin Murphy @ 2017-09-26 11:57 UTC (permalink / raw) To: Thomas Meyer, catalin.marinas, will.deacon, linux-arm-kernel, linux-kernel On 20/09/17 23:29, Thomas Meyer wrote: > Use vma_pages function on vma object instead of explicit computation. > Found by coccinelle spatch "api/vma_pages.cocci" Reviewed-by: Robin Murphy <robin.murphy@arm.com> I guess this can be picked up independently of the other patches? Robin. > Signed-off-by: Thomas Meyer <thomas@m3y3r.de> > --- > > diff -u -p a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c > --- a/arch/arm64/mm/dma-mapping.c > +++ b/arch/arm64/mm/dma-mapping.c > @@ -303,8 +303,7 @@ static int __swiotlb_mmap_pfn(struct vm_ > unsigned long pfn, size_t size) > { > int ret = -ENXIO; > - unsigned long nr_vma_pages = (vma->vm_end - vma->vm_start) >> > - PAGE_SHIFT; > + unsigned long nr_vma_pages = vma_pages(vma); > unsigned long nr_pages = PAGE_ALIGN(size) >> PAGE_SHIFT; > unsigned long off = vma->vm_pgoff; > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > ^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 2/7] arm64: Cocci spatch "vma_pages" @ 2017-09-26 11:57 ` Robin Murphy 0 siblings, 0 replies; 30+ messages in thread From: Robin Murphy @ 2017-09-26 11:57 UTC (permalink / raw) To: linux-arm-kernel On 20/09/17 23:29, Thomas Meyer wrote: > Use vma_pages function on vma object instead of explicit computation. > Found by coccinelle spatch "api/vma_pages.cocci" Reviewed-by: Robin Murphy <robin.murphy@arm.com> I guess this can be picked up independently of the other patches? Robin. > Signed-off-by: Thomas Meyer <thomas@m3y3r.de> > --- > > diff -u -p a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c > --- a/arch/arm64/mm/dma-mapping.c > +++ b/arch/arm64/mm/dma-mapping.c > @@ -303,8 +303,7 @@ static int __swiotlb_mmap_pfn(struct vm_ > unsigned long pfn, size_t size) > { > int ret = -ENXIO; > - unsigned long nr_vma_pages = (vma->vm_end - vma->vm_start) >> > - PAGE_SHIFT; > + unsigned long nr_vma_pages = vma_pages(vma); > unsigned long nr_pages = PAGE_ALIGN(size) >> PAGE_SHIFT; > unsigned long off = vma->vm_pgoff; > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > ^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 6/7] KVM: PPC: Cocci spatch "vma_pages" 2017-09-20 22:29 [PATCH 0/7] Cocci spatch "vma_pages" - v4.14-rc1 Thomas Meyer @ 2017-09-20 22:29 ` Thomas Meyer 2017-09-20 22:29 ` [PATCH 5/7] MIPS: " Thomas Meyer ` (5 subsequent siblings) 6 siblings, 0 replies; 30+ messages in thread From: Thomas Meyer @ 2017-09-20 22:29 UTC (permalink / raw) To: agraf, benh, paulus, mpe, kvm-ppc, linuxppc-dev, linux-kernel Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Thomas Meyer <thomas@m3y3r.de> --- diff -u -p a/arch/powerpc/kvm/e500_mmu_host.c b/arch/powerpc/kvm/e500_mmu_host.c --- a/arch/powerpc/kvm/e500_mmu_host.c +++ b/arch/powerpc/kvm/e500_mmu_host.c @@ -377,7 +377,7 @@ static inline int kvmppc_e500_shadow_map start = vma->vm_pgoff; end = start + - ((vma->vm_end - vma->vm_start) >> PAGE_SHIFT); + vma_pages(vma); pfn = start + ((hva - vma->vm_start) >> PAGE_SHIFT); ^ permalink raw reply [flat|nested] 30+ messages in thread
* [PATCH 6/7] KVM: PPC: Cocci spatch "vma_pages" @ 2017-09-20 22:29 ` Thomas Meyer 0 siblings, 0 replies; 30+ messages in thread From: Thomas Meyer @ 2017-09-20 22:29 UTC (permalink / raw) To: agraf, benh, paulus, mpe, kvm-ppc, linuxppc-dev, linux-kernel Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Thomas Meyer <thomas@m3y3r.de> --- diff -u -p a/arch/powerpc/kvm/e500_mmu_host.c b/arch/powerpc/kvm/e500_mmu_host.c --- a/arch/powerpc/kvm/e500_mmu_host.c +++ b/arch/powerpc/kvm/e500_mmu_host.c @@ -377,7 +377,7 @@ static inline int kvmppc_e500_shadow_map start = vma->vm_pgoff; end = start + - ((vma->vm_end - vma->vm_start) >> PAGE_SHIFT); + vma_pages(vma); pfn = start + ((hva - vma->vm_start) >> PAGE_SHIFT); ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 6/7] KVM: PPC: Cocci spatch "vma_pages" 2017-09-20 22:29 ` Thomas Meyer @ 2017-10-19 3:46 ` Paul Mackerras -1 siblings, 0 replies; 30+ messages in thread From: Paul Mackerras @ 2017-10-19 3:46 UTC (permalink / raw) To: Thomas Meyer; +Cc: agraf, benh, mpe, kvm-ppc, linuxppc-dev, linux-kernel On Thu, Sep 21, 2017 at 12:29:36AM +0200, Thomas Meyer wrote: > Use vma_pages function on vma object instead of explicit computation. > Found by coccinelle spatch "api/vma_pages.cocci" > > Signed-off-by: Thomas Meyer <thomas@m3y3r.de> Thanks, applied to my kvm-ppc-next branch, with the headline "KVM: PPC: BookE: Use vma_pages function". Paul. ^ permalink raw reply [flat|nested] 30+ messages in thread
* Re: [PATCH 6/7] KVM: PPC: Cocci spatch "vma_pages" @ 2017-10-19 3:46 ` Paul Mackerras 0 siblings, 0 replies; 30+ messages in thread From: Paul Mackerras @ 2017-10-19 3:46 UTC (permalink / raw) To: Thomas Meyer; +Cc: agraf, benh, mpe, kvm-ppc, linuxppc-dev, linux-kernel On Thu, Sep 21, 2017 at 12:29:36AM +0200, Thomas Meyer wrote: > Use vma_pages function on vma object instead of explicit computation. > Found by coccinelle spatch "api/vma_pages.cocci" > > Signed-off-by: Thomas Meyer <thomas@m3y3r.de> Thanks, applied to my kvm-ppc-next branch, with the headline "KVM: PPC: BookE: Use vma_pages function". Paul. ^ permalink raw reply [flat|nested] 30+ messages in thread
end of thread, other threads:[~2017-10-19 3:49 UTC | newest] Thread overview: 30+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-09-20 22:29 [PATCH 0/7] Cocci spatch "vma_pages" - v4.14-rc1 Thomas Meyer 2017-09-20 22:29 ` [PATCH 1/7] ARM: dma-mapping: Cocci spatch "vma_pages" Thomas Meyer 2017-09-20 22:29 ` Thomas Meyer 2017-09-20 22:29 ` [PATCH 5/7] MIPS: " Thomas Meyer 2017-09-20 22:29 ` [PATCH 4/7] microblaze: " Thomas Meyer 2017-09-25 13:37 ` Michal Simek 2017-09-20 22:29 ` [PATCH 7/7] drm/rockchip: " Thomas Meyer 2017-09-20 22:29 ` Thomas Meyer 2017-09-21 1:02 ` Mark yao 2017-09-21 1:02 ` Mark yao 2017-09-21 1:02 ` Mark yao 2017-09-26 5:12 ` Daniel Vetter 2017-09-26 5:12 ` Daniel Vetter 2017-09-26 5:12 ` Daniel Vetter 2017-09-26 6:33 ` Mark yao 2017-09-26 6:33 ` Mark yao 2017-09-26 6:33 ` Mark yao 2017-09-26 8:08 ` Daniel Vetter 2017-09-26 8:08 ` Daniel Vetter 2017-09-26 8:08 ` Daniel Vetter 2017-09-26 9:06 ` Mark yao 2017-09-20 22:29 ` [PATCH 3/7] metag: " Thomas Meyer 2017-09-20 22:29 ` [PATCH 2/7] arm64: " Thomas Meyer 2017-09-20 22:29 ` Thomas Meyer 2017-09-26 11:57 ` Robin Murphy 2017-09-26 11:57 ` Robin Murphy 2017-09-20 22:29 ` [PATCH 6/7] KVM: PPC: " Thomas Meyer 2017-09-20 22:29 ` Thomas Meyer 2017-10-19 3:46 ` Paul Mackerras 2017-10-19 3:46 ` Paul Mackerras
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.