Re: Bug#873508: sparse test failures on ppc32le (and other not so common archs) - Uwe Kleine-König

From: "Uwe Kleine-König" <uwe@kleine-koenig.org>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: Christopher Li <sparse@chrisli.org>,
	Ramsay Jones <ramsay@ramsayjones.plus.com>,
	Linux-Sparse <linux-sparse@vger.kernel.org>,
	873508@bugs.debian.org, Antoine Beaupre <anarcat@debian.org>
Subject: Re: Bug#873508: sparse test failures on ppc32le (and other not so common archs)
Date: Wed, 27 Sep 2017 10:00:07 +0200	[thread overview]
Message-ID: <20170927080007.jz2vfe4ekjjowkbe@taurus.defre.kleine-koenig.org> (raw)
In-Reply-To: <20170926181101.jas3ytdiro7o7mj7@taurus.defre.kleine-koenig.org>

[-- Attachment #1: Type: text/plain, Size: 865 bytes --]

Hello,

On Tue, Sep 26, 2017 at 08:11:01PM +0200, Uwe Kleine-König wrote:
> And ppc64 and x32 need the respective cpp defines added I think. If
> noone beats me to it, I will look into the latter at least during the
> next few days.

Looking at ppc64, the following fixes the build:

diff --git a/cgcc b/cgcc
index a8d7b4f217fe..a1c02899c623 100755
--- a/cgcc
+++ b/cgcc
@@ -286,7 +286,7 @@ sub add_specs {
     } elsif ($spec eq 'ppc64') {
 	return (' -D__powerpc__=1 -D__PPC__=1 -D_STRING_ARCH_unaligned=1' .
 		' -D__powerpc64__=1 -D__PPC64__=1' .
-		' -D_CALL_ELF=2' .
+		' -D_CALL_ELF=1' .
 		' -m64' .
 		&float_types (1, 1, 21, [24,8], [53,11], [113,15]));
     } elsif ($spec eq 's390x') {

I wonder if that could be right. Luc, you added =2 in
e0306fe0b725af6e2e7ff59d7f0d99c96315791a, maybe you can comment?

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
