All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christopher Li <sparse@chrisli.org>
To: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: Ramsay Jones <ramsay@ramsayjones.plus.com>,
	Linux-Sparse <linux-sparse@vger.kernel.org>,
	873508@bugs.debian.org, Antoine Beaupre <anarcat@debian.org>
Subject: Re: sparse test failures on ppc32le (and other not so common archs)
Date: Thu, 31 Aug 2017 20:47:55 -0400	[thread overview]
Message-ID: <CANeU7QkBF=uw_EVBe7-zLadUU=cgCvFS7uKxdRk_vq=6SO7W5Q@mail.gmail.com> (raw)
In-Reply-To: <20170831205514.vxmirle2yoc3rm44@taurus.defre.kleine-koenig.org>

On Thu, Aug 31, 2017 at 4:55 PM, Uwe Kleine-König <uwe@kleine-> Yes
that works. So to address the Debian bug I can do:
>
>  - move sparse to /usr/lib
>  - teach cgcc about the move of sparse
>  - make /usr/bin/sparse call cgcc -no-compile "$@"

I don't like that. It means the user can't invoke sparse directly.

>
> or is it easier to teach sparse about the architecture stuff?

First of all. It is not very trivial to teach sparse about the architecture
stuff. To my mind, we need to move all the cgcc logic into sparse.

For this case, I think it is easier to teach the sparse validation
code to use cgcc on those back end testing. Most validation don't
need to include system header file at all so it does not have
this problem.

How about this patch?
I know my patch is white space damaged in email.
Git branch is at:
https://git.kernel.org/pub/scm/devel/sparse/chrisl/sparse.git/log/?h=llvm-cgcc

Please let me know if that fix your problem. It pass check
on my local machine running x86_64. I don't have ppc64 to
test with.

Chris

diff --git a/sparsec b/sparsec
index 9dc96c9..2990d26 100755
--- a/sparsec
+++ b/sparsec
@@ -32,7 +32,8 @@ done
 TMPLLVM=`mktemp -t tmp.XXXXXX`".llvm"
 TMPFILE=`mktemp -t tmp.XXXXXX`".o"

-$DIRNAME/sparse-llvm $SPARSEOPTS > $TMPLLVM
+env CHECK=$DIRNAME/sparse-llvm $DIRNAME/cgcc -no-compile \
+       $SPARSEOPTS > $TMPLLVM

 LLC=`"${LLVM_CONFIG:-llvm-config}" --bindir`/llc

diff --git a/sparsei b/sparsei
index 3431a9f..3abd00f 100755
--- a/sparsei
+++ b/sparsei
@@ -10,4 +10,4 @@ if [ $# -eq 0 ]; then
   exit 1
 fi

-$DIRNAME/sparse-llvm $@ | $LLI
+env CHECK=$DIRNAME/sparse-llvm $DIRNAME/cgcc -no-compile $@ | $LLI

  parent reply	other threads:[~2017-09-01  0:47 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <150392922734.24087.13050909898214597041.reportbug@curie.anarc.at>
2017-08-30 16:14 ` Bug#873508: sparse test failures on ppc32le (and other not so common archs) Uwe Kleine-König
2017-08-30 16:55   ` Ramsay Jones
2017-08-30 17:36     ` Uwe Kleine-König
2017-08-31  0:11       ` Christopher Li
2017-08-31 20:55         ` Uwe Kleine-König
2017-08-31 22:43           ` Ramsay Jones
2017-09-01  0:50             ` Christopher Li
2017-09-01  7:46             ` Uwe Kleine-König
2017-09-01 11:51               ` Christopher Li
2017-09-21 18:58               ` Bug#873508: " Uwe Kleine-König
2017-09-26 18:11                 ` Uwe Kleine-König
2017-09-27  8:00                   ` Uwe Kleine-König
2017-09-27  8:40                     ` Luc Van Oostenryck
2017-09-27 21:11                     ` [PATCH] fix cgcc ELF version for ppc64/pcc64le Luc Van Oostenryck
2017-09-30  8:49                       ` Uwe Kleine-König
2017-10-02 19:45                         ` Luc Van Oostenryck
2017-10-02 21:17                           ` Christopher Li
2017-10-03  4:46                       ` Christopher Li
2017-09-01  0:47           ` Christopher Li [this message]
2017-09-01  7:02             ` sparse test failures on ppc32le (and other not so common archs) Josh Triplett
2017-09-01  7:57               ` Uwe Kleine-König
2017-09-01 22:55                 ` Josh Triplett
2017-09-01 12:00               ` Christopher Li
2017-09-03 21:14               ` Luc Van Oostenryck
2017-09-04 18:00                 ` Christopher Li
     [not found]                 ` <715b7059-4ff0-0982-ff92-56c13c4160e7@kleine-koenig.org>
     [not found]                   ` <CAMHZB6GHoA6v_RPtKF3WBbX0DPB5pqfz9wLf1iP8MWfUVdbteQ@mail.gmail.com>
2017-09-06 14:44                     ` Uwe Kleine-König
2017-09-06 15:18                       ` Christopher Li
2017-09-06 15:36                         ` Uwe Kleine-König
2017-09-12  5:59                           ` Christopher Li
2017-09-12  6:27                             ` Uwe Kleine-König
2017-09-12  6:36                               ` Christopher Li
2017-09-09 21:02             ` Uwe Kleine-König
2017-09-10  1:56               ` [PATCH] build: disable sparse-llvm on non-x86 Luc Van Oostenryck
2017-09-12  6:02                 ` Christopher Li
2017-09-12  6:12                   ` Luc Van Oostenryck
2017-09-12  6:27                     ` Christopher Li
2017-09-12  6:34                       ` Luc Van Oostenryck
2017-09-12  6:44                         ` Christopher Li
2017-09-12  6:48                           ` Luc Van Oostenryck
2017-09-12  7:04                             ` Christopher Li
2017-09-12  7:01                 ` Christopher Li
2017-09-12  7:10                   ` Luc Van Oostenryck
2017-09-12 15:53                     ` Christopher Li
2017-09-01 11:33 ` Bug#873508: sparse test failures on ppc32le (and other not so common archs) Antoine Beaupré
2017-09-10  1:22 ` Luc Van Oostenryck
2017-09-10  8:43   ` Uwe Kleine-König
2017-09-10  9:39     ` Luc Van Oostenryck
2017-09-10 12:29 ` Bug#873508: " Luc Van Oostenryck
2018-04-27  5:56 ` Uwe Kleine-König
2018-04-27  7:33 ` Bug#873508: sparse test failures & PATH_MAX Luc Van Oostenryck
2018-04-27  7:33 ` Uwe Kleine-König
2018-04-27  7:43 ` Bug#873508: sparse test failures on x32 Luc Van Oostenryck
2018-04-27 16:11 ` Bug#873508: sparse test failures & PATH_MAX Luc Van Oostenryck
2019-01-10  2:28 ` Bug#873508: sparse test failures on ppc32le (and other not so common archs) Antoine Beaupré
2019-01-10 11:39 ` Luc Van Oostenryck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANeU7QkBF=uw_EVBe7-zLadUU=cgCvFS7uKxdRk_vq=6SO7W5Q@mail.gmail.com' \
    --to=sparse@chrisli.org \
    --cc=873508@bugs.debian.org \
    --cc=anarcat@debian.org \
    --cc=linux-sparse@vger.kernel.org \
    --cc=ramsay@ramsayjones.plus.com \
    --cc=uwe@kleine-koenig.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.