[PATCH] Staging: vc04_services: remove unused variables control and status

[PATCH] Staging: vc04_services: remove unused variables control and status

[Keerthi Reddy]

the volatile variables control, status are not
used. Delete them.

Signed-off-by: Keerthi Reddy <keerthigd4990@gmail.com>
---
 drivers/staging/vc04_services/bcm2835-audio/bcm2835.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h
index 379604d..f1e43e4 100644
--- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h
+++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h
@@ -123,8 +123,6 @@ struct bcm2835_alsa_stream {
 	struct snd_pcm_indirect pcm_indirect;
 
 	spinlock_t lock;
-	volatile unsigned int control;
-	volatile unsigned int status;
 
 	int open;
 	int running;
-- 
2.7.4

Re: [Outreachy kernel] [PATCH] Staging: vc04_services: remove unused variables control and status

[Julia Lawall]

On Thu, 28 Sep 2017, Keerthi Reddy wrote:

> the volatile variables control, status are not
> used. Delete them.

It could be useful to give some information about how you have checked
this.  Simply compiling the directory might not be good enough, if there
are uses under ifdefs.  Grep could be a reasonable solution.

Also, I would say that these are fields rather than variables, as they are
part of a structure rather than variables in a function.

julia

>
> Signed-off-by: Keerthi Reddy <keerthigd4990@gmail.com>
> ---
>  drivers/staging/vc04_services/bcm2835-audio/bcm2835.h | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h
> index 379604d..f1e43e4 100644
> --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h
> +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h
> @@ -123,8 +123,6 @@ struct bcm2835_alsa_stream {
>  	struct snd_pcm_indirect pcm_indirect;
>
>  	spinlock_t lock;
> -	volatile unsigned int control;
> -	volatile unsigned int status;
>
>  	int open;
>  	int running;
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170928084954.GA4170%40manoharreddy.
> For more options, visit https://groups.google.com/d/optout.
>