* [PATCH] ASoC: Intel: Skylake: Fix jack name format substitution
@ 2017-09-18 15:43 ` Chintan Patel
0 siblings, 0 replies; 5+ messages in thread
From: Chintan Patel @ 2017-09-18 15:43 UTC (permalink / raw)
Cc: harshapriya.n, naveen.m, Chintan Patel, Liam Girdwood,
Mark Brown, Jaroslav Kysela, Takashi Iwai, Sathya Prakash M R,
Hsin-yu Chao, Jeeja KP, Julia Lawall, alsa-devel, linux-kernel
Jack name is not getting formatted correctly hence resulting
in invalid name for HDMI/DP input devices.
This was recently exposed due changes brought by MST:
commit 3a13347f05fd ("ASoC: Intel: kbl: Add jack port initialize
in kbl machine drivers")
Signed-off-by: Chintan Patel <chintan.m.patel@intel.com>
---
sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
index 4689991bcc86..c127b7b0ee3f 100644
--- a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
+++ b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
@@ -611,6 +611,8 @@ static int kabylake_card_late_probe(struct snd_soc_card *card)
list_for_each_entry(pcm, &ctx->hdmi_pcm_list, head) {
codec = pcm->codec_dai->codec;
+ snprintf(jack_name, sizeof(jack_name),
+ "HDMI/DP, pcm=%d Jack", pcm->device);
err = snd_soc_card_jack_new(card, jack_name,
SND_JACK_AVOUT, &ctx->kabylake_hdmi[i],
NULL, 0);
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ASoC: Intel: Skylake: Fix jack name format substitution
@ 2017-09-18 15:43 ` Chintan Patel
0 siblings, 0 replies; 5+ messages in thread
From: Chintan Patel @ 2017-09-18 15:43 UTC (permalink / raw)
Cc: harshapriya.n, naveen.m, Chintan Patel, Liam Girdwood,
Mark Brown, Jaroslav Kysela, Takashi Iwai, Sathya Prakash M R,
Hsin-yu Chao, Jeeja KP, Julia Lawall, alsa-devel, linux-kernel
Jack name is not getting formatted correctly hence resulting
in invalid name for HDMI/DP input devices.
This was recently exposed due changes brought by MST:
commit 3a13347f05fd ("ASoC: Intel: kbl: Add jack port initialize
in kbl machine drivers")
Signed-off-by: Chintan Patel <chintan.m.patel@intel.com>
---
sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
index 4689991bcc86..c127b7b0ee3f 100644
--- a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
+++ b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
@@ -611,6 +611,8 @@ static int kabylake_card_late_probe(struct snd_soc_card *card)
list_for_each_entry(pcm, &ctx->hdmi_pcm_list, head) {
codec = pcm->codec_dai->codec;
+ snprintf(jack_name, sizeof(jack_name),
+ "HDMI/DP, pcm=%d Jack", pcm->device);
err = snd_soc_card_jack_new(card, jack_name,
SND_JACK_AVOUT, &ctx->kabylake_hdmi[i],
NULL, 0);
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: Intel: Skylake: Fix jack name format substitution
2017-09-18 15:43 ` Chintan Patel
(?)
@ 2017-09-28 3:10 ` Vinod Koul
-1 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2017-09-28 3:10 UTC (permalink / raw)
To: Chintan Patel
Cc: alsa-devel, Hsin-yu Chao, harshapriya.n, linux-kernel,
Takashi Iwai, Liam Girdwood, Julia Lawall, Mark Brown, Jeeja KP,
Sathya Prakash M R, naveen.m
On Mon, Sep 18, 2017 at 08:43:18AM -0700, Chintan Patel wrote:
> Jack name is not getting formatted correctly hence resulting
> in invalid name for HDMI/DP input devices.
>
> This was recently exposed due changes brought by MST:
> commit 3a13347f05fd ("ASoC: Intel: kbl: Add jack port initialize
> in kbl machine drivers")
Acked-By: Vinod Koul <vinod.koul@intel.com>
>
> Signed-off-by: Chintan Patel <chintan.m.patel@intel.com>
> ---
> sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
> index 4689991bcc86..c127b7b0ee3f 100644
> --- a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
> +++ b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
> @@ -611,6 +611,8 @@ static int kabylake_card_late_probe(struct snd_soc_card *card)
>
> list_for_each_entry(pcm, &ctx->hdmi_pcm_list, head) {
> codec = pcm->codec_dai->codec;
> + snprintf(jack_name, sizeof(jack_name),
> + "HDMI/DP, pcm=%d Jack", pcm->device);
> err = snd_soc_card_jack_new(card, jack_name,
> SND_JACK_AVOUT, &ctx->kabylake_hdmi[i],
> NULL, 0);
> --
> 1.9.1
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
--
~Vinod
^ permalink raw reply [flat|nested] 5+ messages in thread
* Applied "ASoC: Intel: Skylake: Fix jack name format substitution" to the asoc tree
2017-09-18 15:43 ` Chintan Patel
@ 2017-09-28 18:58 ` Mark Brown
-1 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2017-09-28 18:58 UTC (permalink / raw)
To: Chintan Patel
Cc: Mark Brown, alsa-devel, Hsin-yu Chao, harshapriya.n,
linux-kernel, Takashi Iwai, Liam Girdwood, Julia Lawall,
Mark Brown, Jeeja KP, Sathya Prakash M R, naveen.m, alsa-devel
The patch
ASoC: Intel: Skylake: Fix jack name format substitution
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From d1c4cb447a7efcb5608a33cdfed8ab4234378b0a Mon Sep 17 00:00:00 2001
From: Chintan Patel <chintan.m.patel@intel.com>
Date: Mon, 18 Sep 2017 08:43:18 -0700
Subject: [PATCH] ASoC: Intel: Skylake: Fix jack name format substitution
Jack name is not getting formatted correctly hence resulting
in invalid name for HDMI/DP input devices.
This was recently exposed due changes brought by MST:
commit 3a13347f05fd ("ASoC: Intel: kbl: Add jack port initialize
in kbl machine drivers")
Signed-off-by: Chintan Patel <chintan.m.patel@intel.com>
Acked-By: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
index 88ff54220007..9cd0769ccd34 100644
--- a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
+++ b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
@@ -604,6 +604,8 @@ static int kabylake_card_late_probe(struct snd_soc_card *card)
list_for_each_entry(pcm, &ctx->hdmi_pcm_list, head) {
codec = pcm->codec_dai->codec;
+ snprintf(jack_name, sizeof(jack_name),
+ "HDMI/DP, pcm=%d Jack", pcm->device);
err = snd_soc_card_jack_new(card, jack_name,
SND_JACK_AVOUT, &ctx->kabylake_hdmi[i],
NULL, 0);
--
2.14.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Applied "ASoC: Intel: Skylake: Fix jack name format substitution" to the asoc tree
@ 2017-09-28 18:58 ` Mark Brown
0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2017-09-28 18:58 UTC (permalink / raw)
To: Chintan Patel
Cc: Mark Brown, alsa-devel, Hsin-yu Chao, harshapriya.n,
linux-kernel, Takashi Iwai, Liam Girdwood, Julia Lawall
The patch
ASoC: Intel: Skylake: Fix jack name format substitution
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From d1c4cb447a7efcb5608a33cdfed8ab4234378b0a Mon Sep 17 00:00:00 2001
From: Chintan Patel <chintan.m.patel@intel.com>
Date: Mon, 18 Sep 2017 08:43:18 -0700
Subject: [PATCH] ASoC: Intel: Skylake: Fix jack name format substitution
Jack name is not getting formatted correctly hence resulting
in invalid name for HDMI/DP input devices.
This was recently exposed due changes brought by MST:
commit 3a13347f05fd ("ASoC: Intel: kbl: Add jack port initialize
in kbl machine drivers")
Signed-off-by: Chintan Patel <chintan.m.patel@intel.com>
Acked-By: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
index 88ff54220007..9cd0769ccd34 100644
--- a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
+++ b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
@@ -604,6 +604,8 @@ static int kabylake_card_late_probe(struct snd_soc_card *card)
list_for_each_entry(pcm, &ctx->hdmi_pcm_list, head) {
codec = pcm->codec_dai->codec;
+ snprintf(jack_name, sizeof(jack_name),
+ "HDMI/DP, pcm=%d Jack", pcm->device);
err = snd_soc_card_jack_new(card, jack_name,
SND_JACK_AVOUT, &ctx->kabylake_hdmi[i],
NULL, 0);
--
2.14.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-09-28 18:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-18 15:43 [PATCH] ASoC: Intel: Skylake: Fix jack name format substitution Chintan Patel
2017-09-18 15:43 ` Chintan Patel
2017-09-28 3:10 ` [alsa-devel] " Vinod Koul
2017-09-28 18:58 ` Applied "ASoC: Intel: Skylake: Fix jack name format substitution" to the asoc tree Mark Brown
2017-09-28 18:58 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.