All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Georgiana Chelu <georgiana.chelu93@gmail.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
	outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: ieee80211: Use netdev_info instead of printk
Date: Fri, 29 Sep 2017 15:18:06 +0200	[thread overview]
Message-ID: <20170929131806.GA5945@kroah.com> (raw)
In-Reply-To: <CALta04wjWw+iu-0exV7aW5fEiJqG-xGmzgkw08-4Qwz3txOGpw@mail.gmail.com>

On Sun, Sep 24, 2017 at 12:18:55AM +0300, Georgiana Chelu wrote:
> On 20 September 2017 at 12:06, Julia Lawall <julia.lawall@lip6.fr> wrote:
> >
> >
> > On Wed, 20 Sep 2017, Georgiana Chelu wrote:
> >
> >> On 19 September 2017 at 23:28, Julia Lawall <julia.lawall@lip6.fr> wrote:
> >> >
> >> >
> >> > On Tue, 19 Sep 2017, Georgiana Chelu wrote:
> >> >
> >> >> Replace printk with netdev_info because struct ieee80211_device
> >> >> contains a net_device structure.
> >> >>
> >> >> Issue found by checkpatch.pl script.
> >> >> WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
> >> >> dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...
> >> >>
> >> >> Signed-off-by: Georgiana Chelu <georgiana.chelu93@example.com>
> >> >
> >> > Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> >> >
> >> > Maybe all the locally defined debug levels are not really needed, and the
> >> > calls to the debug macros could also be replaced by appropriate calls to
> >> > netdev logging functions.
> >> >
> >> > julia
> 
> Hi Greg,
> 
> Are debug levels still needed? As Julia pointed out, all IEEE80211_DEBUG_*
> macros use printk(KERN_*) in the end. Do you think it is useful and safe
> to replace these macros with netdev_*?

I really do not know, sorry.

greg k-h


      reply	other threads:[~2017-09-29 13:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-19 19:54 [PATCH] Staging: rtl8192u: ieee80211: Use netdev_info instead of printk Georgiana Chelu
2017-09-19 20:28 ` [Outreachy kernel] " Julia Lawall
2017-09-19 22:37   ` Georgiana Chelu
2017-09-20  9:06     ` Julia Lawall
2017-09-23 21:18       ` Georgiana Chelu
2017-09-29 13:18         ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170929131806.GA5945@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=georgiana.chelu93@gmail.com \
    --cc=julia.lawall@lip6.fr \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.