Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: ieee80211: Use netdev_info instead of printk

From: Julia Lawall <julia.lawall@lip6.fr>
To: Georgiana Chelu <georgiana.chelu93@gmail.com>
Cc: outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org
Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: ieee80211: Use netdev_info instead of printk
Date: Tue, 19 Sep 2017 22:28:17 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1709192225010.2518@hadrien> (raw)
In-Reply-To: <20170919195406.n6kztu5q3pnduhir@fireworks>

On Tue, 19 Sep 2017, Georgiana Chelu wrote:

> Replace printk with netdev_info because struct ieee80211_device
> contains a net_device structure.
>
> Issue found by checkpatch.pl script.
> WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
> dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...
>
> Signed-off-by: Georgiana Chelu <georgiana.chelu93@example.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

Maybe all the locally defined debug levels are not really needed, and the
calls to the debug macros could also be replaced by appropriate calls to
netdev logging functions.

julia

> ---
>  drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
> index 8aa38dcf0dfd..0f86195680e8 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c
> @@ -143,7 +143,7 @@ static struct sk_buff *ieee80211_ADDBA(struct ieee80211_device *ieee, u8 *Dst, P
>
>  	if (ACT_ADDBARSP == type) {
>  		// Status Code
> -		printk(KERN_INFO "=====>to send ADDBARSP\n");
> +		netdev_info(ieee->dev, "=====>to send ADDBARSP\n");
>
>  		put_unaligned_le16(StatusCode, tag);
>  		tag += 2;
> @@ -345,7 +345,7 @@ int ieee80211_rx_ADDBAReq(struct ieee80211_device *ieee, struct sk_buff *skb)
>  	pBaTimeoutVal = (u16 *)(tag + 5);
>  	pBaStartSeqCtrl = (PSEQUENCE_CONTROL)(req + 7);
>
> -	printk(KERN_INFO "====================>rx ADDBAREQ from :%pM\n", dst);
> +	netdev_info(ieee->dev, "====================>rx ADDBAREQ from :%pM\n", dst);
>  //some other capability is not ready now.
>  	if ((ieee->current_network.qos_data.active == 0) ||
>  		(!ieee->pHTInfo->bCurrentHTSupport)) //||
> --
> 2.11.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170919195406.n6kztu5q3pnduhir%40fireworks.
> For more options, visit https://groups.google.com/d/optout.
>