All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liviu Dudau <liviu.dudau@arm.com>
To: Srishti Sharma <srishtishar@gmail.com>
Cc: daniel.vetter@ffwll.ch, seanpaul@chromium.org,
	brian.starkey@arm.com, malidp@foss.arm.com, airlied@linux.ie,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] drm/arm: Replace instances of drm_dev_unref with drm_dev_put.
Date: Fri, 29 Sep 2017 16:24:55 +0100	[thread overview]
Message-ID: <20170929152455.GL6681@e110455-lin.cambridge.arm.com> (raw)
In-Reply-To: <1506679240-7061-1-git-send-email-srishtishar@gmail.com>

Hi Srishti,

On Fri, Sep 29, 2017 at 03:30:40PM +0530, Srishti Sharma wrote:
> Replace drm_dev_unref with drm_dev_put as it is more consistent
> with kernel coding style. Done using the following semantic
> patch by coccinelle.

Thanks for the patch!

Acked-by: Liviu Dudau <liviu.dudau@arm.com>

I'm going to pull this patch into the mali-dp tree next week when
I'm preparing an update of that tree.

Best regards,
Liviu

> 
> @r@
> expression e;
> @@
> 
> -drm_dev_unref();
> +drm_dev_put();
> 
> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
> ---
>  drivers/gpu/drm/arm/hdlcd_drv.c  | 4 ++--
>  drivers/gpu/drm/arm/malidp_drv.c | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c
> index f9bda7b..1a96462 100644
> --- a/drivers/gpu/drm/arm/hdlcd_drv.c
> +++ b/drivers/gpu/drm/arm/hdlcd_drv.c
> @@ -353,7 +353,7 @@ static int hdlcd_drm_bind(struct device *dev)
>  err_free:
>  	drm_mode_config_cleanup(drm);
>  	dev_set_drvdata(dev, NULL);
> -	drm_dev_unref(drm);
> +	drm_dev_put(drm);
>  
>  	return ret;
>  }
> @@ -378,7 +378,7 @@ static void hdlcd_drm_unbind(struct device *dev)
>  	pm_runtime_disable(drm->dev);
>  	of_reserved_mem_device_release(drm->dev);
>  	drm_mode_config_cleanup(drm);
> -	drm_dev_unref(drm);
> +	drm_dev_put(drm);
>  	drm->dev_private = NULL;
>  	dev_set_drvdata(dev, NULL);
>  }
> diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
> index 7ae94a1..1b92f41 100644
> --- a/drivers/gpu/drm/arm/malidp_drv.c
> +++ b/drivers/gpu/drm/arm/malidp_drv.c
> @@ -665,7 +665,7 @@ static int malidp_bind(struct device *dev)
>  		malidp_runtime_pm_suspend(dev);
>  	drm->dev_private = NULL;
>  	dev_set_drvdata(dev, NULL);
> -	drm_dev_unref(drm);
> +	drm_dev_put(drm);
>  alloc_fail:
>  	of_reserved_mem_device_release(dev);
>  
> @@ -698,7 +698,7 @@ static void malidp_unbind(struct device *dev)
>  		malidp_runtime_pm_suspend(dev);
>  	drm->dev_private = NULL;
>  	dev_set_drvdata(dev, NULL);
> -	drm_dev_unref(drm);
> +	drm_dev_put(drm);
>  	of_reserved_mem_device_release(dev);
>  }
>  
> -- 
> 2.7.4
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯


WARNING: multiple messages have this Message-ID (diff)
From: Liviu Dudau <liviu.dudau@arm.com>
To: Srishti Sharma <srishtishar@gmail.com>
Cc: daniel.vetter@ffwll.ch, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	outreachy-kernel@googlegroups.com, malidp@foss.arm.com
Subject: Re: [PATCH] drm/arm: Replace instances of drm_dev_unref with drm_dev_put.
Date: Fri, 29 Sep 2017 16:24:55 +0100	[thread overview]
Message-ID: <20170929152455.GL6681@e110455-lin.cambridge.arm.com> (raw)
In-Reply-To: <1506679240-7061-1-git-send-email-srishtishar@gmail.com>

Hi Srishti,

On Fri, Sep 29, 2017 at 03:30:40PM +0530, Srishti Sharma wrote:
> Replace drm_dev_unref with drm_dev_put as it is more consistent
> with kernel coding style. Done using the following semantic
> patch by coccinelle.

Thanks for the patch!

Acked-by: Liviu Dudau <liviu.dudau@arm.com>

I'm going to pull this patch into the mali-dp tree next week when
I'm preparing an update of that tree.

Best regards,
Liviu

> 
> @r@
> expression e;
> @@
> 
> -drm_dev_unref();
> +drm_dev_put();
> 
> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
> ---
>  drivers/gpu/drm/arm/hdlcd_drv.c  | 4 ++--
>  drivers/gpu/drm/arm/malidp_drv.c | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c
> index f9bda7b..1a96462 100644
> --- a/drivers/gpu/drm/arm/hdlcd_drv.c
> +++ b/drivers/gpu/drm/arm/hdlcd_drv.c
> @@ -353,7 +353,7 @@ static int hdlcd_drm_bind(struct device *dev)
>  err_free:
>  	drm_mode_config_cleanup(drm);
>  	dev_set_drvdata(dev, NULL);
> -	drm_dev_unref(drm);
> +	drm_dev_put(drm);
>  
>  	return ret;
>  }
> @@ -378,7 +378,7 @@ static void hdlcd_drm_unbind(struct device *dev)
>  	pm_runtime_disable(drm->dev);
>  	of_reserved_mem_device_release(drm->dev);
>  	drm_mode_config_cleanup(drm);
> -	drm_dev_unref(drm);
> +	drm_dev_put(drm);
>  	drm->dev_private = NULL;
>  	dev_set_drvdata(dev, NULL);
>  }
> diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
> index 7ae94a1..1b92f41 100644
> --- a/drivers/gpu/drm/arm/malidp_drv.c
> +++ b/drivers/gpu/drm/arm/malidp_drv.c
> @@ -665,7 +665,7 @@ static int malidp_bind(struct device *dev)
>  		malidp_runtime_pm_suspend(dev);
>  	drm->dev_private = NULL;
>  	dev_set_drvdata(dev, NULL);
> -	drm_dev_unref(drm);
> +	drm_dev_put(drm);
>  alloc_fail:
>  	of_reserved_mem_device_release(dev);
>  
> @@ -698,7 +698,7 @@ static void malidp_unbind(struct device *dev)
>  		malidp_runtime_pm_suspend(dev);
>  	drm->dev_private = NULL;
>  	dev_set_drvdata(dev, NULL);
> -	drm_dev_unref(drm);
> +	drm_dev_put(drm);
>  	of_reserved_mem_device_release(dev);
>  }
>  
> -- 
> 2.7.4
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-09-29 20:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-29 10:00 [PATCH] drm/arm: Replace instances of drm_dev_unref with drm_dev_put Srishti Sharma
2017-09-29 15:24 ` Liviu Dudau [this message]
2017-09-29 15:24   ` Liviu Dudau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170929152455.GL6681@e110455-lin.cambridge.arm.com \
    --to=liviu.dudau@arm.com \
    --cc=airlied@linux.ie \
    --cc=brian.starkey@arm.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=malidp@foss.arm.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=seanpaul@chromium.org \
    --cc=srishtishar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.