* [PATCH net] ip_gre: ipgre_tap device should keep dst
@ 2017-09-28 5:23 Xin Long
2017-10-01 2:54 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Xin Long @ 2017-09-28 5:23 UTC (permalink / raw)
To: network dev; +Cc: davem, Dmitry Kozlov
Without keeping dst, the tunnel will not update any mtu/pmtu info,
since it does not have a dst on the skb.
Reproducer:
client(ipgre_tap1 - eth1) <-----> (eth1 - ipgre_tap1)server
After reducing eth1's mtu on client, then perforamnce became 0.
This patch is to netif_keep_dst in gre_tap_init, as ipgre does.
Reported-by: Jianlin Shi <jishi@redhat.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
---
net/ipv4/ip_gre.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
index 0162fb9..8b837f6 100644
--- a/net/ipv4/ip_gre.c
+++ b/net/ipv4/ip_gre.c
@@ -1223,6 +1223,7 @@ static int gre_tap_init(struct net_device *dev)
{
__gre_tunnel_init(dev);
dev->priv_flags |= IFF_LIVE_ADDR_CHANGE;
+ netif_keep_dst(dev);
return ip_tunnel_init(dev);
}
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] ip_gre: ipgre_tap device should keep dst
2017-09-28 5:23 [PATCH net] ip_gre: ipgre_tap device should keep dst Xin Long
@ 2017-10-01 2:54 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-10-01 2:54 UTC (permalink / raw)
To: lucien.xin; +Cc: netdev, xeb
From: Xin Long <lucien.xin@gmail.com>
Date: Thu, 28 Sep 2017 13:23:31 +0800
> Without keeping dst, the tunnel will not update any mtu/pmtu info,
> since it does not have a dst on the skb.
>
> Reproducer:
> client(ipgre_tap1 - eth1) <-----> (eth1 - ipgre_tap1)server
>
> After reducing eth1's mtu on client, then perforamnce became 0.
>
> This patch is to netif_keep_dst in gre_tap_init, as ipgre does.
>
> Reported-by: Jianlin Shi <jishi@redhat.com>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-01 2:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-28 5:23 [PATCH net] ip_gre: ipgre_tap device should keep dst Xin Long
2017-10-01 2:54 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.