All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] report: fix summary statistics in xUnit header
@ 2017-10-02  3:39 Theodore Ts'o
  0 siblings, 0 replies; only message in thread
From: Theodore Ts'o @ 2017-10-02  3:39 UTC (permalink / raw)
  To: fstests; +Cc: Theodore Ts'o, Dmitry Monakhov

The xUnit XML DTD distinguishes between test failures and test errors,
where a test failure indicate that the test has explicitly indicated
that the code under test has behaved in an unexpected fashion, whereas
a test error indicates the test code itself has thrown an error or
there has been some other test implementation error.

Xfstest failures are correctly marked as xUnit failures, but in the
attributes of the testsuite XML element, the number of test failures
was incorrectly reported as the number of errors.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: Dmitry Monakhov <dmonakhov@openvz.org>
---
 common/report | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/report b/common/report
index bb689836..058c0bba 100644
--- a/common/report
+++ b/common/report
@@ -59,7 +59,7 @@ _xunit_make_section_report()
 	# Header
 	echo "<?xml version=\"1.0\" encoding=\"UTF-8\"?>" > $REPORT_DIR/result.xml
 	local dtime=`echo $date_time| tr  " " 'T'`
-	local stats="errors=\"$n_bad\" skipped=\"$n_notrun\" tests=\"$n_total\" time=\"$sect_time\""
+	local stats="failures=\"$n_bad\" skipped=\"$n_notrun\" tests=\"$n_total\" time=\"$sect_time\""
 	local hw_info="hostname=\"$HOST\" timestamp=\"$dtime\" "
 	echo "<testsuite name=\"xfstests\" $stats  $hw_info >" >> $REPORT_DIR/result.xml
 
-- 
2.11.0.rc0.7.gbe5a750


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2017-10-02  3:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-02  3:39 [PATCH] report: fix summary statistics in xUnit header Theodore Ts'o

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.