From: Mike Snitzer <snitzer@redhat.com>
To: Alasdair G Kergon <agk@redhat.com>
Cc: dm-devel@redhat.com, Mikulas Patocka <mpatocka@redhat.com>,
Milan Broz <gmazyland@gmail.com>
Subject: Re: dm-crypt: Reject sector_size feature if device length is not aligned to it
Date: Tue, 3 Oct 2017 14:08:04 -0400 [thread overview]
Message-ID: <20171003180804.GA25465@redhat.com> (raw)
In-Reply-To: <20171003120508.GA9979@agk-dp.fab.redhat.com>
On Tue, Oct 03 2017 at 8:05am -0400,
Alasdair G Kergon <agk@redhat.com> wrote:
> On Mon, Oct 02, 2017 at 10:43:56AM -0400, Mikulas Patocka wrote:
> > Here I send a patch that checks invalid limits when the table is loaded
> > and aborts the table load ioctl with an error.
>
> The code does not already do this because it needs to avoid unnecessary
> failures if any characteristics of the devices underneath change after
> the 'load' but before the 'resume' (as can happen, for example, when a
> tree of devices gets updated by performing all the loads before all the
> resumes).
Not sure why you're putting such value on that behaviour. The earlier
we catch invalid tables the better off we are. Failing at resume time
sucks (always has).
Could be there is some specific scenario where lvm2 is leveraging this
historic DM "feature" but it'd be nice to revalidate the need.
Mike
next prev parent reply other threads:[~2017-10-03 18:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 13:45 [PATCH] dm-crypt: Reject sector_size feature if device length is not aligned to it Milan Broz
2017-09-30 18:31 ` Milan Broz
2017-10-02 14:43 ` Mikulas Patocka
2017-10-03 6:27 ` Milan Broz
2017-10-03 12:05 ` Alasdair G Kergon
2017-10-03 18:08 ` Mike Snitzer [this message]
2017-10-03 19:09 ` Alasdair G Kergon
2017-10-03 20:08 ` Mikulas Patocka
2017-10-03 20:33 ` Milan Broz
2017-10-03 21:18 ` Mike Snitzer
2017-10-04 6:45 ` Milan Broz
2017-10-04 15:05 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003180804.GA25465@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=gmazyland@gmail.com \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.