All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Milan Broz <gmazyland@gmail.com>
Cc: dm-devel@redhat.com, Mikulas Patocka <mpatocka@redhat.com>,
	Alasdair G Kergon <agk@redhat.com>
Subject: Re: dm-crypt: Reject sector_size feature if device length is not aligned to it
Date: Wed, 4 Oct 2017 11:05:21 -0400	[thread overview]
Message-ID: <20171004150520.GA31155@redhat.com> (raw)
In-Reply-To: <704e2665-2dc2-54a4-a35e-0c04350f4d8c@gmail.com>

On Wed, Oct 04 2017 at  2:45am -0400,
Milan Broz <gmazyland@gmail.com> wrote:

> On 10/03/2017 11:18 PM, Mike Snitzer wrote:
> > On Tue, Oct 03 2017 at  4:33pm -0400,
> > Milan Broz <gmazyland@gmail.com> wrote:
> > 
> >> On 10/03/2017 10:08 PM, Mikulas Patocka wrote:
> >>>
> >>> It would be interesting to know, why Milan wants the table load to fail.
> >>
> >> I mentioned this on IRC:
> >> the only situation I care about in load is that size (dm-table length) is unaligned to optional sector_size.
> >> create fails in this case, load should imho fail as well. 
> >> ...
> >> if we say that dmsetup table output is always directly usable (as a mapping table),
> >> then why should there be an exception for dmsetup table --inactive? (now it can print apparently invalid mapping)
> > 
> > The .ctr should validate the inactive table and that'll cause load to
> > fail.
> 
> And that's exactly what is the former patch doing - we introduced a new parameter that
> has new limitations, we should fix constructor. That's all I want :-)

Yeap, I've staged your fix.. enough with all this debate.
See: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-4.14/dm&id=783874b050768d361239e444ba0fa396bb6d463f

(but yes I read your "rant".. I agreed with all you said.. but it lacked
the qualities of a flaming rant.. you must be happier ;)

      reply	other threads:[~2017-10-04 15:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-13 13:45 [PATCH] dm-crypt: Reject sector_size feature if device length is not aligned to it Milan Broz
2017-09-30 18:31 ` Milan Broz
2017-10-02 14:43   ` Mikulas Patocka
2017-10-03  6:27     ` Milan Broz
2017-10-03 12:05     ` Alasdair G Kergon
2017-10-03 18:08       ` Mike Snitzer
2017-10-03 19:09         ` Alasdair G Kergon
2017-10-03 20:08           ` Mikulas Patocka
2017-10-03 20:33             ` Milan Broz
2017-10-03 21:18               ` Mike Snitzer
2017-10-04  6:45                 ` Milan Broz
2017-10-04 15:05                   ` Mike Snitzer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171004150520.GA31155@redhat.com \
    --to=snitzer@redhat.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=gmazyland@gmail.com \
    --cc=mpatocka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.