All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: LKP <lkp@01.org>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>
Subject: Re: d82fed7529 ("locking/lockdep/selftests: Fix mixed read-write .."):  BUG:  -1 unexpected failures (out of 262) - debugging disabled! |
Date: Wed, 4 Oct 2017 09:04:23 +0800	[thread overview]
Message-ID: <20171004010423.yjuhkr43aqh42qns@wfg-t540p.sh.intel.com> (raw)
In-Reply-To: <20170830074159.GB660@worktop.programming.kicks-ass.net>

On Wed, Aug 30, 2017 at 09:41:59AM +0200, Peter Zijlstra wrote:
>On Wed, Aug 30, 2017 at 08:29:47AM +0200, Peter Zijlstra wrote:
>> On Wed, Aug 30, 2017 at 11:37:21AM +0800, kernel test robot wrote:
>>
>> > [    0.004000] -----------------------------------------------------------------
>> > [    0.004000] BUG:  -1 unexpected failures (out of 262) - debugging disabled! |
>> > [    0.004000] -----------------------------------------------------------------
>>
>> lol.. however did that happen.. /me goes look.
>
>Ah, I think this should cure..

It works!

Tested-by: Fengguang Wu <fengguang.wu@intel.com>

>---
>diff --git a/lib/locking-selftest.c b/lib/locking-selftest.c
>index cd0b5c964bd0..2b827b8a1d8c 100644
>--- a/lib/locking-selftest.c
>+++ b/lib/locking-selftest.c
>@@ -2031,11 +2031,13 @@ void locking_selftest(void)
> 	print_testname("mixed read-lock/lock-write ABBA");
> 	pr_cont("             |");
> 	dotest(rlock_ABBA1, FAILURE, LOCKTYPE_RWLOCK);
>+#ifdef CONFIG_PROVE_LOCKING
> 	/*
> 	 * Lockdep does indeed fail here, but there's nothing we can do about
> 	 * that now.  Don't kill lockdep for it.
> 	 */
> 	unexpected_testcase_failures--;
>+#endif
>
> 	pr_cont("             |");
> 	dotest(rwsem_ABBA1, FAILURE, LOCKTYPE_RWSEM);

WARNING: multiple messages have this Message-ID (diff)
From: Fengguang Wu <fengguang.wu@intel.com>
To: lkp@lists.01.org
Subject: Re: d82fed7529 ("locking/lockdep/selftests: Fix mixed read-write .."): BUG: -1 unexpected failures (out of 262) - debugging disabled! |
Date: Wed, 04 Oct 2017 09:04:23 +0800	[thread overview]
Message-ID: <20171004010423.yjuhkr43aqh42qns@wfg-t540p.sh.intel.com> (raw)
In-Reply-To: <20170830074159.GB660@worktop.programming.kicks-ass.net>

[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]

On Wed, Aug 30, 2017 at 09:41:59AM +0200, Peter Zijlstra wrote:
>On Wed, Aug 30, 2017 at 08:29:47AM +0200, Peter Zijlstra wrote:
>> On Wed, Aug 30, 2017 at 11:37:21AM +0800, kernel test robot wrote:
>>
>> > [    0.004000] -----------------------------------------------------------------
>> > [    0.004000] BUG:  -1 unexpected failures (out of 262) - debugging disabled! |
>> > [    0.004000] -----------------------------------------------------------------
>>
>> lol.. however did that happen.. /me goes look.
>
>Ah, I think this should cure..

It works!

Tested-by: Fengguang Wu <fengguang.wu@intel.com>

>---
>diff --git a/lib/locking-selftest.c b/lib/locking-selftest.c
>index cd0b5c964bd0..2b827b8a1d8c 100644
>--- a/lib/locking-selftest.c
>+++ b/lib/locking-selftest.c
>@@ -2031,11 +2031,13 @@ void locking_selftest(void)
> 	print_testname("mixed read-lock/lock-write ABBA");
> 	pr_cont("             |");
> 	dotest(rlock_ABBA1, FAILURE, LOCKTYPE_RWLOCK);
>+#ifdef CONFIG_PROVE_LOCKING
> 	/*
> 	 * Lockdep does indeed fail here, but there's nothing we can do about
> 	 * that now.  Don't kill lockdep for it.
> 	 */
> 	unexpected_testcase_failures--;
>+#endif
>
> 	pr_cont("             |");
> 	dotest(rwsem_ABBA1, FAILURE, LOCKTYPE_RWSEM);

  reply	other threads:[~2017-10-04  1:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-30  3:37 d82fed7529 ("locking/lockdep/selftests: Fix mixed read-write .."): BUG: -1 unexpected failures (out of 262) - debugging disabled! | kernel test robot
2017-08-30  3:37 ` kernel test robot
2017-08-30  6:29 ` Peter Zijlstra
2017-08-30  6:29   ` Peter Zijlstra
2017-08-30  7:41   ` Peter Zijlstra
2017-08-30  7:41     ` Peter Zijlstra
2017-10-04  1:04     ` Fengguang Wu [this message]
2017-10-04  1:04       ` Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171004010423.yjuhkr43aqh42qns@wfg-t540p.sh.intel.com \
    --to=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@01.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.