[PATCH 0/3] arm64: dts: renesas: r8a7795: salvator-xs: enable USB2.0 host channel 3

[PATCH 0/3] arm64: dts: renesas: r8a7795: salvator-xs: enable USB2.0 host channel 3

[Yoshihiro Shimoda]

This patch set is based on the latest renesas.git /
renesas-devel-20170928-v4.14-rc2 tag.

Yoshihiro Shimoda (3):
  arm64: dts: renesas: r8a7795: salvator-xs: enable USB2.0 phy channel 3
  arm64: dts: renesas: r8a7795: salvator-xs: enable USB2.0 Host channel
    3
  arm64: dts: renesas: r8a7795: salvator-xs: enable HS-USB channel 3

 .../arm64/boot/dts/renesas/r8a7795-salvator-xs.dts | 24 ++++++++++++++++++++++
 1 file changed, 24 insertions(+)

-- 
1.9.1

[PATCH 1/3] arm64: dts: renesas: r8a7795: salvator-xs: enable USB2.0 phy channel 3

[Yoshihiro Shimoda]

This patch enables the USB2.0 phy channel 3. R-Car H3 ES2.0 has
this channel and we can use it on the Salvator-XS.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
---
 arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
index 7675de5..e18bf4f 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
@@ -99,6 +99,11 @@
 		groups = "usb2";
 		function = "usb2";
 	};
+
+	usb2_ch3_pins: usb2_ch3 {
+		groups = "usb2_ch3";
+		function = "usb2_ch3";
+	};
 };
 
 &usb2_phy2 {
@@ -107,3 +112,10 @@
 
 	status = "okay";
 };
+
+&usb2_phy3 {
+	pinctrl-0 = <&usb2_ch3_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/3] arm64: dts: renesas: r8a7795: salvator-xs: enable USB2.0 phy channel 3

[Yoshihiro Shimoda]

This patch enables the USB2.0 phy channel 3. R-Car H3 ES2.0 has
this channel and we can use it on the Salvator-XS.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
index 7675de5..e18bf4f 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
@@ -99,6 +99,11 @@
 		groups = "usb2";
 		function = "usb2";
 	};
+
+	usb2_ch3_pins: usb2_ch3 {
+		groups = "usb2_ch3";
+		function = "usb2_ch3";
+	};
 };
 
 &usb2_phy2 {
@@ -107,3 +112,10 @@
 
 	status = "okay";
 };
+
+&usb2_phy3 {
+	pinctrl-0 = <&usb2_ch3_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
-- 
1.9.1

[PATCH 2/3] arm64: dts: renesas: r8a7795: salvator-xs: enable USB2.0 Host channel 3

[Yoshihiro Shimoda]

This patch enables USB2.0 Host (EHCI/OHCI) channel 3. R-Car H3 ES2.0
has this channel and we can use it on the Salvator-XS.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
---
 arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
index e18bf4f..365c8df 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
@@ -56,6 +56,10 @@
 	status = "okay";
 };
 
+&ehci3 {
+	status = "okay";
+};
+
 &hdmi0 {
 	status = "okay";
 
@@ -94,6 +98,10 @@
 	status = "okay";
 };
 
+&ohci3 {
+	status = "okay";
+};
+
 &pfc {
 	usb2_pins: usb2 {
 		groups = "usb2";
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/3] arm64: dts: renesas: r8a7795: salvator-xs: enable USB2.0 Host channel 3

[Yoshihiro Shimoda]

This patch enables USB2.0 Host (EHCI/OHCI) channel 3. R-Car H3 ES2.0
has this channel and we can use it on the Salvator-XS.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
index e18bf4f..365c8df 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
@@ -56,6 +56,10 @@
 	status = "okay";
 };
 
+&ehci3 {
+	status = "okay";
+};
+
 &hdmi0 {
 	status = "okay";
 
@@ -94,6 +98,10 @@
 	status = "okay";
 };
 
+&ohci3 {
+	status = "okay";
+};
+
 &pfc {
 	usb2_pins: usb2 {
 		groups = "usb2";
-- 
1.9.1

[PATCH 3/3] arm64: dts: renesas: r8a7795: salvator-xs: enable HS-USB channel 3

[Yoshihiro Shimoda]

This patch enables HS-USB channel 3. R-Car H3 ES2.0 has this channel
and we can use it on the Salvator-XS.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
---
 arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
index 365c8df..344ca99 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
@@ -94,6 +94,10 @@
 	remote-endpoint = <&rcar_dw_hdmi1_out>;
 };
 
+&hsusb3 {
+	status = "okay";
+};
+
 &ohci2 {
 	status = "okay";
 };
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 3/3] arm64: dts: renesas: r8a7795: salvator-xs: enable HS-USB channel 3

[Yoshihiro Shimoda]

This patch enables HS-USB channel 3. R-Car H3 ES2.0 has this channel
and we can use it on the Salvator-XS.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
index 365c8df..344ca99 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
@@ -94,6 +94,10 @@
 	remote-endpoint = <&rcar_dw_hdmi1_out>;
 };
 
+&hsusb3 {
+	status = "okay";
+};
+
 &ohci2 {
 	status = "okay";
 };
-- 
1.9.1

Re: [PATCH 1/3] arm64: dts: renesas: r8a7795: salvator-xs: enable USB2.0 phy channel 3

[Geert Uytterhoeven]

Hi Shimoda-san,

On Mon, Oct 2, 2017 at 8:29 AM, Yoshihiro Shimoda
<yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> wrote:
> This patch enables the USB2.0 phy channel 3. R-Car H3 ES2.0 has
> this channel and we can use it on the Salvator-XS.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>

> --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
> @@ -99,6 +99,11 @@
>                 groups = "usb2";
>                 function = "usb2";
>         };
> +
> +       usb2_ch3_pins: usb2_ch3 {
> +               groups = "usb2_ch3";
> +               function = "usb2_ch3";
> +       };
>  };

Using these pins requires changing SW31, disabling the interrupt capabilities
of the ADV7482? Does the ADV7482 still work after that?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] arm64: dts: renesas: r8a7795: salvator-xs: enable USB2.0 phy channel 3

[Geert Uytterhoeven]

Hi Shimoda-san,

On Mon, Oct 2, 2017 at 8:29 AM, Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> This patch enables the USB2.0 phy channel 3. R-Car H3 ES2.0 has
> this channel and we can use it on the Salvator-XS.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
> @@ -99,6 +99,11 @@
>                 groups = "usb2";
>                 function = "usb2";
>         };
> +
> +       usb2_ch3_pins: usb2_ch3 {
> +               groups = "usb2_ch3";
> +               function = "usb2_ch3";
> +       };
>  };

Using these pins requires changing SW31, disabling the interrupt capabilities
of the ADV7482? Does the ADV7482 still work after that?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/3] arm64: dts: renesas: r8a7795: salvator-xs: enable USB2.0 phy channel 3

[Kieran Bingham]

Hi Geert, Shimoda-san,

On 02/10/17 09:20, Geert Uytterhoeven wrote:
> Hi Shimoda-san,
> 
> On Mon, Oct 2, 2017 at 8:29 AM, Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com> wrote:
>> This patch enables the USB2.0 phy channel 3. R-Car H3 ES2.0 has
>> this channel and we can use it on the Salvator-XS.
>>
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
>> --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
>> +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
>> @@ -99,6 +99,11 @@
>>                 groups = "usb2";
>>                 function = "usb2";
>>         };
>> +
>> +       usb2_ch3_pins: usb2_ch3 {
>> +               groups = "usb2_ch3";
>> +               function = "usb2_ch3";
>> +       };
>>  };
> 
> Using these pins requires changing SW31, disabling the interrupt capabilities
> of the ADV7482? Does the ADV7482 still work after that?

The ADV7482 is currently working without interrupts at the moment. However, I do
have hotplug and interrupt handling on my todo list, and infact I have already
started a patch adding interrupt support.


The DT currently specifies the following interrupts for the ADV7482,

+	video-receiver@70 {
+		compatible = "adi,adv7482";
+		interrupt-parent = <&gpio6>;
+		interrupt-names = "intrq1", "intrq2";
+		interrupts = <30 IRQ_TYPE_LEVEL_LOW>,
+			     <31 IRQ_TYPE_LEVEL_LOW>;

And the start of interrupt handling looks like: (this is not integrated, nor
finished):

https://git.kernel.org/pub/scm/linux/kernel/git/kbingham/rcar.git/commit/?h=adv748x/dev&id=82c7d0100edd28fa429c3811c575bad7a4d92cfd

This purely registers the interrupts currently; so if I need to do anything
differently to handle the USB2 conflict, please let me know.

As for going forwards, I believe that the ADV7482 can actually configure what
interrupts are triggered on either interrupt source, (INTRQ1/INTRQ2) and
therefore we could potentially get by with only INTRQ1, (INT 30) if we needed
to; however it would be good to handle this conflict in a generic way.


Regards

Kieran

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 

RE: [PATCH 1/3] arm64: dts: renesas: r8a7795: salvator-xs: enable USB2.0 phy channel 3

[Yoshihiro Shimoda]

Hi Geert-san, Kieran-san,

> -----Original Message-----
> From: Kieran Bingham
> Sent: Monday, October 2, 2017 5:45 PM
> 
> Hi Geert, Shimoda-san,
> 
> On 02/10/17 09:20, Geert Uytterhoeven wrote:
> > Hi Shimoda-san,
> >
> > On Mon, Oct 2, 2017 at 8:29 AM, Yoshihiro Shimoda
> > <yoshihiro.shimoda.uh@renesas.com> wrote:
> >> This patch enables the USB2.0 phy channel 3. R-Car H3 ES2.0 has
> >> this channel and we can use it on the Salvator-XS.
> >>
> >> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> >> --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
> >> +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
> >> @@ -99,6 +99,11 @@
> >>                 groups = "usb2";
> >>                 function = "usb2";
> >>         };
> >> +
> >> +       usb2_ch3_pins: usb2_ch3 {
> >> +               groups = "usb2_ch3";
> >> +               function = "usb2_ch3";
> >> +       };
> >>  };
> >
> > Using these pins requires changing SW31, disabling the interrupt capabilities
> > of the ADV7482? Does the ADV7482 still work after that?

Oops, I missed the usb2.0 pins are connected to ADV7482's interruption pins.
But,

> The ADV7482 is currently working without interrupts at the moment. However, I do
> have hotplug and interrupt handling on my todo list, and infact I have already
> started a patch adding interrupt support.
> 
> 
> The DT currently specifies the following interrupts for the ADV7482,
> 
> +	video-receiver@70 {
> +		compatible = "adi,adv7482";
> +		interrupt-parent = <&gpio6>;
> +		interrupt-names = "intrq1", "intrq2";
> +		interrupts = <30 IRQ_TYPE_LEVEL_LOW>,
> +			     <31 IRQ_TYPE_LEVEL_LOW>;

It seems Kieran-san is using non-conflict pins with usb2.0 ch3 :)
According to the board datasheet, GP6_30 and GP6_31 are initial setting for ADV7482 and
it doesn't conflict with USB 2.0 ch3 (USB2.0 ch3 pins are GP6_04 and GP6_21).
So, I think we can use both usb 2.0 ch3 and ADV7482 if we don't change the SW31 from initial setting.
However, to avoid any trouble, should we explain this SW31 setting in the dts file?

Best regards,
Yoshihiro Shimoda

> And the start of interrupt handling looks like: (this is not integrated, nor
> finished):
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/kbingham/rcar.git/commit/?h=adv748x/dev&id=82c7d0100edd28fa429c3811c
> 575bad7a4d92cfd
> 
> This purely registers the interrupts currently; so if I need to do anything
> differently to handle the USB2 conflict, please let me know.


> As for going forwards, I believe that the ADV7482 can actually configure what
> interrupts are triggered on either interrupt source, (INTRQ1/INTRQ2) and
> therefore we could potentially get by with only INTRQ1, (INT 30) if we needed
> to; however it would be good to handle this conflict in a generic way.
> 
> 
> Regards
> 
> Kieran
> 
> > Gr{oetje,eeting}s,
> >
> >                         Geert
> >
> > --
> > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> >
> > In personal conversations with technical people, I call myself a hacker. But
> > when I'm talking to journalists I just say "programmer" or something like that.
> >                                 -- Linus Torvalds
> >

Re: [PATCH 1/3] arm64: dts: renesas: r8a7795: salvator-xs: enable USB2.0 phy channel 3

[Geert Uytterhoeven]

Hi Shimoda-san,

On Mon, Oct 2, 2017 at 11:14 AM, Yoshihiro Shimoda
<yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> wrote:
>> -----Original Message-----
>> From: Kieran Bingham
>> Sent: Monday, October 2, 2017 5:45 PM
>> On 02/10/17 09:20, Geert Uytterhoeven wrote:
>> > On Mon, Oct 2, 2017 at 8:29 AM, Yoshihiro Shimoda
>> > <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> wrote:
>> >> This patch enables the USB2.0 phy channel 3. R-Car H3 ES2.0 has
>> >> this channel and we can use it on the Salvator-XS.
>> >>
>> >> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
>> >
>> > Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
>> >
>> >> --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
>> >> +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
>> >> @@ -99,6 +99,11 @@
>> >>                 groups = "usb2";
>> >>                 function = "usb2";
>> >>         };
>> >> +
>> >> +       usb2_ch3_pins: usb2_ch3 {
>> >> +               groups = "usb2_ch3";
>> >> +               function = "usb2_ch3";
>> >> +       };
>> >>  };
>> >
>> > Using these pins requires changing SW31, disabling the interrupt capabilities
>> > of the ADV7482? Does the ADV7482 still work after that?
>
> Oops, I missed the usb2.0 pins are connected to ADV7482's interruption pins.
> But,
>
>> The ADV7482 is currently working without interrupts at the moment. However, I do
>> have hotplug and interrupt handling on my todo list, and infact I have already
>> started a patch adding interrupt support.
>>
>>
>> The DT currently specifies the following interrupts for the ADV7482,
>>
>> +     video-receiver@70 {
>> +             compatible = "adi,adv7482";
>> +             interrupt-parent = <&gpio6>;
>> +             interrupt-names = "intrq1", "intrq2";
>> +             interrupts = <30 IRQ_TYPE_LEVEL_LOW>,
>> +                          <31 IRQ_TYPE_LEVEL_LOW>;
>
> It seems Kieran-san is using non-conflict pins with usb2.0 ch3 :)
> According to the board datasheet, GP6_30 and GP6_31 are initial setting for ADV7482 and
> it doesn't conflict with USB 2.0 ch3 (USB2.0 ch3 pins are GP6_04 and GP6_21).

Can the USB2.0 driver use GPIOs for PWEN and OVC?

> So, I think we can use both usb 2.0 ch3 and ADV7482 if we don't change the SW31 from initial setting.

OK. But in that case, DT should not configure pinctrl for "usb2_ch3",
but instead
describe that it uses GP6_04 and GP6_21.

> However, to avoid any trouble, should we explain this SW31 setting in the dts file?

Yes, it would be good to document that.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] arm64: dts: renesas: r8a7795: salvator-xs: enable USB2.0 phy channel 3

[Geert Uytterhoeven]

Hi Shimoda-san,

On Mon, Oct 2, 2017 at 11:14 AM, Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
>> -----Original Message-----
>> From: Kieran Bingham
>> Sent: Monday, October 2, 2017 5:45 PM
>> On 02/10/17 09:20, Geert Uytterhoeven wrote:
>> > On Mon, Oct 2, 2017 at 8:29 AM, Yoshihiro Shimoda
>> > <yoshihiro.shimoda.uh@renesas.com> wrote:
>> >> This patch enables the USB2.0 phy channel 3. R-Car H3 ES2.0 has
>> >> this channel and we can use it on the Salvator-XS.
>> >>
>> >> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> >
>> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> >
>> >> --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
>> >> +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
>> >> @@ -99,6 +99,11 @@
>> >>                 groups = "usb2";
>> >>                 function = "usb2";
>> >>         };
>> >> +
>> >> +       usb2_ch3_pins: usb2_ch3 {
>> >> +               groups = "usb2_ch3";
>> >> +               function = "usb2_ch3";
>> >> +       };
>> >>  };
>> >
>> > Using these pins requires changing SW31, disabling the interrupt capabilities
>> > of the ADV7482? Does the ADV7482 still work after that?
>
> Oops, I missed the usb2.0 pins are connected to ADV7482's interruption pins.
> But,
>
>> The ADV7482 is currently working without interrupts at the moment. However, I do
>> have hotplug and interrupt handling on my todo list, and infact I have already
>> started a patch adding interrupt support.
>>
>>
>> The DT currently specifies the following interrupts for the ADV7482,
>>
>> +     video-receiver@70 {
>> +             compatible = "adi,adv7482";
>> +             interrupt-parent = <&gpio6>;
>> +             interrupt-names = "intrq1", "intrq2";
>> +             interrupts = <30 IRQ_TYPE_LEVEL_LOW>,
>> +                          <31 IRQ_TYPE_LEVEL_LOW>;
>
> It seems Kieran-san is using non-conflict pins with usb2.0 ch3 :)
> According to the board datasheet, GP6_30 and GP6_31 are initial setting for ADV7482 and
> it doesn't conflict with USB 2.0 ch3 (USB2.0 ch3 pins are GP6_04 and GP6_21).

Can the USB2.0 driver use GPIOs for PWEN and OVC?

> So, I think we can use both usb 2.0 ch3 and ADV7482 if we don't change the SW31 from initial setting.

OK. But in that case, DT should not configure pinctrl for "usb2_ch3",
but instead
describe that it uses GP6_04 and GP6_21.

> However, to avoid any trouble, should we explain this SW31 setting in the dts file?

Yes, it would be good to document that.

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

RE: [PATCH 1/3] arm64: dts: renesas: r8a7795: salvator-xs: enable USB2.0 phy channel 3

[Yoshihiro Shimoda]

Hi Geert-san,

> -----Original Message-----
> From: Geert Uytterhoeven
> Sent: Monday, October 2, 2017 6:20 PM
> 
> Hi Shimoda-san,
> 
> On Mon, Oct 2, 2017 at 11:14 AM, Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com> wrote:
> >> -----Original Message-----
> >> From: Kieran Bingham
> >> Sent: Monday, October 2, 2017 5:45 PM
> >> On 02/10/17 09:20, Geert Uytterhoeven wrote:
> >> > On Mon, Oct 2, 2017 at 8:29 AM, Yoshihiro Shimoda
> >> > <yoshihiro.shimoda.uh@renesas.com> wrote:
<snip>
> >> The ADV7482 is currently working without interrupts at the moment. However, I do
> >> have hotplug and interrupt handling on my todo list, and infact I have already
> >> started a patch adding interrupt support.
> >>
> >>
> >> The DT currently specifies the following interrupts for the ADV7482,
> >>
> >> +     video-receiver@70 {
> >> +             compatible = "adi,adv7482";
> >> +             interrupt-parent = <&gpio6>;
> >> +             interrupt-names = "intrq1", "intrq2";
> >> +             interrupts = <30 IRQ_TYPE_LEVEL_LOW>,
> >> +                          <31 IRQ_TYPE_LEVEL_LOW>;
> >
> > It seems Kieran-san is using non-conflict pins with usb2.0 ch3 :)
> > According to the board datasheet, GP6_30 and GP6_31 are initial setting for ADV7482 and
> > it doesn't conflict with USB 2.0 ch3 (USB2.0 ch3 pins are GP6_04 and GP6_21).
> 
> Can the USB2.0 driver use GPIOs for PWEN and OVC?

No, the driver cannot use GPIOs. These pins control by a usb specific register
(e.g. in EHCI, bit 14 of PORTSC[1] for PWEN and bit 4 of PORTSC[1] for OVC),
So, I think we have no change to use GPIOs.

> > So, I think we can use both usb 2.0 ch3 and ADV7482 if we don't change the SW31 from initial setting.
> 
> OK. But in that case, DT should not configure pinctrl for "usb2_ch3",
> but instead
> describe that it uses GP6_04 and GP6_21.

I got it. I will modify it.

> > However, to avoid any trouble, should we explain this SW31 setting in the dts file?
> 
> Yes, it would be good to document that.

I got it. I will add it.
I will submit v2 patch tomorrow (or later).

Best regards,
Yoshihiro Shimoda

> Thanks!
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

RE: [PATCH 1/3] arm64: dts: renesas: r8a7795: salvator-xs: enable USB2.0 phy channel 3

[Yoshihiro Shimoda]

Hi Geert-san,

> -----Original Message-----
> From: Geert Uytterhoeven
> Sent: Monday, October 2, 2017 6:20 PM
> 
> Hi Shimoda-san,
> 
> On Mon, Oct 2, 2017 at 11:14 AM, Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com> wrote:
> >> -----Original Message-----
> >> From: Kieran Bingham
> >> Sent: Monday, October 2, 2017 5:45 PM
> >> On 02/10/17 09:20, Geert Uytterhoeven wrote:
> >> > On Mon, Oct 2, 2017 at 8:29 AM, Yoshihiro Shimoda
> >> > <yoshihiro.shimoda.uh@renesas.com> wrote:
> >> >> This patch enables the USB2.0 phy channel 3. R-Car H3 ES2.0 has
> >> >> this channel and we can use it on the Salvator-XS.
> >> >>
> >> >> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> >> >
> >> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >> >
> >> >> --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
> >> >> +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
> >> >> @@ -99,6 +99,11 @@
> >> >>                 groups = "usb2";
> >> >>                 function = "usb2";
> >> >>         };
> >> >> +
> >> >> +       usb2_ch3_pins: usb2_ch3 {
> >> >> +               groups = "usb2_ch3";
> >> >> +               function = "usb2_ch3";
> >> >> +       };
> >> >>  };
> >> >
> >> > Using these pins requires changing SW31, disabling the interrupt capabilities
> >> > of the ADV7482? Does the ADV7482 still work after that?
> >
> > Oops, I missed the usb2.0 pins are connected to ADV7482's interruption pins.
> > But,
> >
> >> The ADV7482 is currently working without interrupts at the moment. However, I do
> >> have hotplug and interrupt handling on my todo list, and infact I have already
> >> started a patch adding interrupt support.
> >>
> >>
> >> The DT currently specifies the following interrupts for the ADV7482,
> >>
> >> +     video-receiver@70 {
> >> +             compatible = "adi,adv7482";
> >> +             interrupt-parent = <&gpio6>;
> >> +             interrupt-names = "intrq1", "intrq2";
> >> +             interrupts = <30 IRQ_TYPE_LEVEL_LOW>,
> >> +                          <31 IRQ_TYPE_LEVEL_LOW>;
> >
> > It seems Kieran-san is using non-conflict pins with usb2.0 ch3 :)
> > According to the board datasheet, GP6_30 and GP6_31 are initial setting for ADV7482 and
> > it doesn't conflict with USB 2.0 ch3 (USB2.0 ch3 pins are GP6_04 and GP6_21).
> 
> Can the USB2.0 driver use GPIOs for PWEN and OVC?
> 
> > So, I think we can use both usb 2.0 ch3 and ADV7482 if we don't change the SW31 from initial setting.
> 
> OK. But in that case, DT should not configure pinctrl for "usb2_ch3",
> but instead
> describe that it uses GP6_04 and GP6_21.

I'm afraid but I completely misunderstood the pin configurations on the Salvator-XS.
I wrote right things below:
- USB2.0 ch3 pins are GP6_30 and GP6_31.
 - So, initial setting of the board will be conflict with the adv7482's interrupt pins.
- If we change the SW31 as alternative setting for usb, the adv7482's interrupt pins connect
  to GP6_04 and GP6_21.

And, I wrote my opinions below:
- The adv7482 point of view:
 - On both Salvator-X and Salvator-XS, adv7482's interrupt pins connected to GP6_30 and GP6_31.
  - On Salvator-XS, adv7482's interrupt pins can be changed by SW31 and they connected to GP6_04 and GP6_21.
- The usb2 ch3 point of view:
 - It can be used on H3 ES2.0 only. (In other words, M3 cannot use the usb2 ch3.)
- Summary
 - We describe the adv7482's interrupt pins into both salvator-x.dtsi and salvator-xs.dtsi.
  - In salvator-x.dtsi, adv7482 node uses GP6_30 and GP6_31.
  - In salvator-xs.dtsi, adv7482 node uses GP6_04 and GP6_21.
 - We describe the usb2 ch3 pfc node into r8a7795-salvator-xs.dtsi with "usb2_ch3" groups/function and
    describe the SW31 configuration.

What do you think?

Best regards,
Yoshihiro Shimoda

Re: [PATCH 1/3] arm64: dts: renesas: r8a7795: salvator-xs: enable USB2.0 phy channel 3

[Geert Uytterhoeven]

Hi Shimoda-san,

On Tue, Oct 3, 2017 at 5:13 AM, Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
>> -----Original Message-----
>> From: Geert Uytterhoeven
>> Sent: Monday, October 2, 2017 6:20 PM
>> On Mon, Oct 2, 2017 at 11:14 AM, Yoshihiro Shimoda
>> <yoshihiro.shimoda.uh@renesas.com> wrote:
>> >> -----Original Message-----
>> >> From: Kieran Bingham
>> >> Sent: Monday, October 2, 2017 5:45 PM
>> >> On 02/10/17 09:20, Geert Uytterhoeven wrote:
>> >> > On Mon, Oct 2, 2017 at 8:29 AM, Yoshihiro Shimoda
>> >> > <yoshihiro.shimoda.uh@renesas.com> wrote:
>> >> >> This patch enables the USB2.0 phy channel 3. R-Car H3 ES2.0 has
>> >> >> this channel and we can use it on the Salvator-XS.
>> >> >>
>> >> >> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> >> >
>> >> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> >> >
>> >> >> --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
>> >> >> +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
>> >> >> @@ -99,6 +99,11 @@
>> >> >>                 groups = "usb2";
>> >> >>                 function = "usb2";
>> >> >>         };
>> >> >> +
>> >> >> +       usb2_ch3_pins: usb2_ch3 {
>> >> >> +               groups = "usb2_ch3";
>> >> >> +               function = "usb2_ch3";
>> >> >> +       };
>> >> >>  };
>> >> >
>> >> > Using these pins requires changing SW31, disabling the interrupt capabilities
>> >> > of the ADV7482? Does the ADV7482 still work after that?
>> >
>> > Oops, I missed the usb2.0 pins are connected to ADV7482's interruption pins.
>> > But,
>> >
>> >> The ADV7482 is currently working without interrupts at the moment. However, I do
>> >> have hotplug and interrupt handling on my todo list, and infact I have already
>> >> started a patch adding interrupt support.
>> >>
>> >> The DT currently specifies the following interrupts for the ADV7482,
>> >>
>> >> +     video-receiver@70 {
>> >> +             compatible = "adi,adv7482";
>> >> +             interrupt-parent = <&gpio6>;
>> >> +             interrupt-names = "intrq1", "intrq2";
>> >> +             interrupts = <30 IRQ_TYPE_LEVEL_LOW>,
>> >> +                          <31 IRQ_TYPE_LEVEL_LOW>;
>> >
>> > It seems Kieran-san is using non-conflict pins with usb2.0 ch3 :)
>> > According to the board datasheet, GP6_30 and GP6_31 are initial setting for ADV7482 and
>> > it doesn't conflict with USB 2.0 ch3 (USB2.0 ch3 pins are GP6_04 and GP6_21).
>>
>> Can the USB2.0 driver use GPIOs for PWEN and OVC?
>>
>> > So, I think we can use both usb 2.0 ch3 and ADV7482 if we don't change the SW31 from initial setting.
>>
>> OK. But in that case, DT should not configure pinctrl for "usb2_ch3",
>> but instead
>> describe that it uses GP6_04 and GP6_21.
>
> I'm afraid but I completely misunderstood the pin configurations on the Salvator-XS.
> I wrote right things below:
> - USB2.0 ch3 pins are GP6_30 and GP6_31.

OK.

>  - So, initial setting of the board will be conflict with the adv7482's interrupt pins.

Initial setting of SW31 is ON-ON-OFF-OFF-OFF-OFF, cfr. Section 2.1.22
("SW31 (Selects GPIO/USB Connection) Specifications") of the
Salvator-XS setup manual,
which is meant to accommodate the ADV7482 on both H3 and M3-W, like
was done on Salvator-X.

> - If we change the SW31 as alternative setting for usb, the adv7482's interrupt pins connect
>   to GP6_04 and GP6_21.

OK.

> And, I wrote my opinions below:
> - The adv7482 point of view:
>  - On both Salvator-X and Salvator-XS, adv7482's interrupt pins connected to GP6_30 and GP6_31.
>   - On Salvator-XS, adv7482's interrupt pins can be changed by SW31 and they connected to GP6_04 and GP6_21.

OK.

> - The usb2 ch3 point of view:
>  - It can be used on H3 ES2.0 only. (In other words, M3 cannot use the usb2 ch3.)

OK.

> - Summary
>  - We describe the adv7482's interrupt pins into both salvator-x.dtsi and salvator-xs.dtsi.
>   - In salvator-x.dtsi, adv7482 node uses GP6_30 and GP6_31.
>   - In salvator-xs.dtsi, adv7482 node uses GP6_04 and GP6_21.

While you could do this in salvator-xs.dtsi, doing so would mean users of
Salvator-X with M3-W have to change SW31 from the default configuration to
OFF-OFF-OFF-OFF-ON-ON (Note: we don't have r8a7796-salvator-xs.dts in
mainline yet).

>  - We describe the usb2 ch3 pfc node into r8a7795-salvator-xs.dtsi with "usb2_ch3" groups/function and
>     describe the SW31 configuration.
>
> What do you think?

I would keep the ADV7482 in salvator-common.dtsi using the GP6_3[01]
interrupts, like is done now.

In r8a7795-salvator-xs.dtsi, you can override the interrupts property to
GP6_{04,21}, with a comment saying:
  1. This is done to support the "usb2_ch3" pin group, and,
  2. This requires changing SW31 to OFF-OFF-ON-ON-ON-ON.

Users of Salvator-XS with M3-W don't have to change anything.

Does this sound OK?
Simon?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

RE: [PATCH 1/3] arm64: dts: renesas: r8a7795: salvator-xs: enable USB2.0 phy channel 3

[Yoshihiro Shimoda]

Hi Geert-san,

> -----Original Message-----
> From: Geert Uytterhoeven, Sent: Tuesday, October 3, 2017 4:13 PM
> 
> Hi Shimoda-san,
> 
> On Tue, Oct 3, 2017 at 5:13 AM, Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com> wrote:
<snip>
> > I'm afraid but I completely misunderstood the pin configurations on the Salvator-XS.
> > I wrote right things below:
> > - USB2.0 ch3 pins are GP6_30 and GP6_31.
> 
> OK.
> 
> >  - So, initial setting of the board will be conflict with the adv7482's interrupt pins.
> 
> Initial setting of SW31 is ON-ON-OFF-OFF-OFF-OFF, cfr. Section 2.1.22
> ("SW31 (Selects GPIO/USB Connection) Specifications") of the
> Salvator-XS setup manual,
> which is meant to accommodate the ADV7482 on both H3 and M3-W, like
> was done on Salvator-X.

Yes.

<snip>
> > - Summary
> >  - We describe the adv7482's interrupt pins into both salvator-x.dtsi and salvator-xs.dtsi.
> >   - In salvator-x.dtsi, adv7482 node uses GP6_30 and GP6_31.
> >   - In salvator-xs.dtsi, adv7482 node uses GP6_04 and GP6_21.
> 
> While you could do this in salvator-xs.dtsi, doing so would mean users of
> Salvator-X with M3-W have to change SW31 from the default configuration to
> OFF-OFF-OFF-OFF-ON-ON (Note: we don't have r8a7796-salvator-xs.dts in
> mainline yet).

Yes.

> >  - We describe the usb2 ch3 pfc node into r8a7795-salvator-xs.dtsi with "usb2_ch3" groups/function and
> >     describe the SW31 configuration.
> >
> > What do you think?
> 
> I would keep the ADV7482 in salvator-common.dtsi using the GP6_3[01]
> interrupts, like is done now.
> 
> In r8a7795-salvator-xs.dtsi, you can override the interrupts property to
> GP6_{04,21}, with a comment saying:
>   1. This is done to support the "usb2_ch3" pin group, and,
>   2. This requires changing SW31 to OFF-OFF-ON-ON-ON-ON.
> 
> Users of Salvator-XS with M3-W don't have to change anything.
> 
> Does this sound OK?

It sounds good to me! I guess Kieran-san will do the "override the interrupt property"
when he supports ADV7482 :)

Best regards,
Yoshihiro Shimoda

> Simon?
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

Re: [PATCH 0/3] arm64: dts: renesas: r8a7795: salvator-xs: enable USB2.0 host channel 3

[Simon Horman]

On Mon, Oct 02, 2017 at 03:29:46PM +0900, Yoshihiro Shimoda wrote:
> This patch set is based on the latest renesas.git /
> renesas-devel-20170928-v4.14-rc2 tag.
> 
> Yoshihiro Shimoda (3):
>   arm64: dts: renesas: r8a7795: salvator-xs: enable USB2.0 phy channel 3
>   arm64: dts: renesas: r8a7795: salvator-xs: enable USB2.0 Host channel
>     3
>   arm64: dts: renesas: r8a7795: salvator-xs: enable HS-USB channel 3
> 
>  .../arm64/boot/dts/renesas/r8a7795-salvator-xs.dts | 24 ++++++++++++++++++++++

Hi Shimoda-san,

there was some discussion of patch 1/3.
At this point I'm waiting for a repost of the patchset with
a revised patch 1/3.

Thanks