* [PATCH] nvme: update timeout module parameter type
@ 2017-09-07 0:23 Marc Olson
2017-09-07 6:29 ` Christoph Hellwig
2017-10-04 7:44 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Marc Olson @ 2017-09-07 0:23 UTC (permalink / raw)
The underlying blk_mq_tag_set, and request timeout parameters support an
unsigned int. Extend the size of the nvme module parameters for io and
admin commands to match.
Signed-off-by: Marc Olson <marcolso at amazon.com>
---
drivers/nvme/host/core.c | 8 ++++----
drivers/nvme/host/nvme.h | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index fbeca06..097f678 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -34,13 +34,13 @@
#define NVME_MINORS (1U << MINORBITS)
-unsigned char admin_timeout = 60;
-module_param(admin_timeout, byte, 0644);
+unsigned int admin_timeout = 60;
+module_param(admin_timeout, uint, 0644);
MODULE_PARM_DESC(admin_timeout, "timeout in seconds for admin commands");
EXPORT_SYMBOL_GPL(admin_timeout);
-unsigned char nvme_io_timeout = 30;
-module_param_named(io_timeout, nvme_io_timeout, byte, 0644);
+unsigned int nvme_io_timeout = 30;
+module_param_named(io_timeout, nvme_io_timeout, uint, 0644);
MODULE_PARM_DESC(io_timeout, "timeout in seconds for I/O");
EXPORT_SYMBOL_GPL(nvme_io_timeout);
diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
index 8edafd8..6afabc4 100644
--- a/drivers/nvme/host/nvme.h
+++ b/drivers/nvme/host/nvme.h
@@ -30,10 +30,10 @@ enum {
NVME_SC_CANCELLED = -EINTR,
};
-extern unsigned char nvme_io_timeout;
+extern unsigned int nvme_io_timeout;
#define NVME_IO_TIMEOUT (nvme_io_timeout * HZ)
-extern unsigned char admin_timeout;
+extern unsigned int admin_timeout;
#define ADMIN_TIMEOUT (admin_timeout * HZ)
extern unsigned char shutdown_timeout;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] nvme: update timeout module parameter type
2017-09-07 0:23 [PATCH] nvme: update timeout module parameter type Marc Olson
@ 2017-09-07 6:29 ` Christoph Hellwig
2017-10-04 7:44 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2017-09-07 6:29 UTC (permalink / raw)
Looks fine,
Reviewed-by: Christoph Hellwig <hch at lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] nvme: update timeout module parameter type
2017-09-07 0:23 [PATCH] nvme: update timeout module parameter type Marc Olson
2017-09-07 6:29 ` Christoph Hellwig
@ 2017-10-04 7:44 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2017-10-04 7:44 UTC (permalink / raw)
Thanks,
applied to nvme-4.15.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-04 7:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-07 0:23 [PATCH] nvme: update timeout module parameter type Marc Olson
2017-09-07 6:29 ` Christoph Hellwig
2017-10-04 7:44 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.