[PATCH 0/2] using uio_pdrv_genirq without module param

[PATCH 0/2] using uio_pdrv_genirq without module param

[Chris Packham]

I found myself about to add a driver that was a sub-optimal clone of
uio_pdrv_genirq the only difference was that I didn't want to modify the args
passed to the kernel by my bootloader. If uio_pdrv_genirq had a default
of_match entry I could simply use that. This series attempts to implement this.

Chris Packham (2):
  uio: dt-bindings: document binding for uio-pdrv-genirq
  uio: add default compatible string to uio_pdrv_genirq

 .../bindings/uio/linux,uio-pdrv-genirq.txt         | 28 ++++++++++++++++++++++
 drivers/uio/uio_pdrv_genirq.c                      |  3 ++-
 2 files changed, 30 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/uio/linux,uio-pdrv-genirq.txt

-- 
2.14.1

[PATCH 1/2] uio: dt-bindings: document binding for uio-pdrv-genirq

[Chris Packham]

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
 .../bindings/uio/linux,uio-pdrv-genirq.txt         | 28 ++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/uio/linux,uio-pdrv-genirq.txt

diff --git a/Documentation/devicetree/bindings/uio/linux,uio-pdrv-genirq.txt b/Documentation/devicetree/bindings/uio/linux,uio-pdrv-genirq.txt
new file mode 100644
index 000000000000..90447905e886
--- /dev/null
+++ b/Documentation/devicetree/bindings/uio/linux,uio-pdrv-genirq.txt
@@ -0,0 +1,28 @@
+*Generic UIO platform driver with interrupts
+
+Required properties:
+- compatible: Should be "linux,uio-pdrv-genirq" or a value set with the of_id
+  module parameter.
+
+Optional properties:
+- interrupts: Should contain the interrupt to be associated with this device
+  (only a single interrupt is supported per device).
+- interrupt-parent: Specifies the phandle to the parent interrupt controller.
+- reg: Should specify the physical address spaces used by this device.
+
+Example:
+
+/* Device with MM IO and interrupt */
+my-device@10000 {
+	compatible = "linux,uio-pdrv-genirq";
+	reg = <0x10000 0x40>;
+	interrupts = <4 IRQ_TYPE_EDGE_BOTH>;
+	interrupt-parent = <&gic>;
+};
+
+/* Device with interrupt only */
+my-int {
+	compatible = "linux,uio-pdrv-genirq";
+	interrupts = <6 IRQ_TYPE_EDGE_BOTH>;
+	interrupt-parent = <&gic>;
+};
-- 
2.14.1

[PATCH 1/2] uio: dt-bindings: document binding for uio-pdrv-genirq

[Chris Packham]

Signed-off-by: Chris Packham <chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org>
---
 .../bindings/uio/linux,uio-pdrv-genirq.txt         | 28 ++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/uio/linux,uio-pdrv-genirq.txt

diff --git a/Documentation/devicetree/bindings/uio/linux,uio-pdrv-genirq.txt b/Documentation/devicetree/bindings/uio/linux,uio-pdrv-genirq.txt
new file mode 100644
index 000000000000..90447905e886
--- /dev/null
+++ b/Documentation/devicetree/bindings/uio/linux,uio-pdrv-genirq.txt
@@ -0,0 +1,28 @@
+*Generic UIO platform driver with interrupts
+
+Required properties:
+- compatible: Should be "linux,uio-pdrv-genirq" or a value set with the of_id
+  module parameter.
+
+Optional properties:
+- interrupts: Should contain the interrupt to be associated with this device
+  (only a single interrupt is supported per device).
+- interrupt-parent: Specifies the phandle to the parent interrupt controller.
+- reg: Should specify the physical address spaces used by this device.
+
+Example:
+
+/* Device with MM IO and interrupt */
+my-device@10000 {
+	compatible = "linux,uio-pdrv-genirq";
+	reg = <0x10000 0x40>;
+	interrupts = <4 IRQ_TYPE_EDGE_BOTH>;
+	interrupt-parent = <&gic>;
+};
+
+/* Device with interrupt only */
+my-int {
+	compatible = "linux,uio-pdrv-genirq";
+	interrupts = <6 IRQ_TYPE_EDGE_BOTH>;
+	interrupt-parent = <&gic>;
+};
-- 
2.14.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] uio: add default compatible string to uio_pdrv_genirq

[Chris Packham]

Add a default compatible string "linux,uio-pdrv-genirq" to
uio_pdrv_genirq to make it usable without supplying a module parameter.
The module parameter is still supported in addition to the default.

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
 drivers/uio/uio_pdrv_genirq.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/uio/uio_pdrv_genirq.c b/drivers/uio/uio_pdrv_genirq.c
index f598ecddc8a7..8dd4729e14ab 100644
--- a/drivers/uio/uio_pdrv_genirq.c
+++ b/drivers/uio/uio_pdrv_genirq.c
@@ -253,11 +253,12 @@ static const struct dev_pm_ops uio_pdrv_genirq_dev_pm_ops = {
 
 #ifdef CONFIG_OF
 static struct of_device_id uio_of_genirq_match[] = {
+	{ .compatible = "linux,uio-pdrv-genirq" },
 	{ /* This is filled with module_parm */ },
 	{ /* Sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, uio_of_genirq_match);
-module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0);
+module_param_string(of_id, uio_of_genirq_match[1].compatible, 128, 0000);
 MODULE_PARM_DESC(of_id, "Openfirmware id of the device to be handled by uio");
 #endif
 
-- 
2.14.1

Re: [PATCH 1/2] uio: dt-bindings: document binding for uio-pdrv-genirq

[Greg KH]

On Thu, Sep 21, 2017 at 12:53:25PM +1200, Chris Packham wrote:
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>

I can't take patches without any changelog text, sorry.

thanks,

greg k-h

Re: [PATCH 1/2] uio: dt-bindings: document binding for uio-pdrv-genirq

[Greg KH]

On Thu, Sep 21, 2017 at 12:53:25PM +1200, Chris Packham wrote:
> Signed-off-by: Chris Packham <chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org>

I can't take patches without any changelog text, sorry.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] uio: add default compatible string to uio_pdrv_genirq

[Andy Shevchenko]

On Thu, Sep 21, 2017 at 3:53 AM, Chris Packham
<chris.packham@alliedtelesis.co.nz> wrote:


> -module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0);
> +module_param_string(of_id, uio_of_genirq_match[1].compatible, 128, 0000);

0 -> 0000 looks like bogus checkpatch warning.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 2/2] uio: add default compatible string to uio_pdrv_genirq

[Andy Shevchenko]

On Thu, Sep 21, 2017 at 3:53 AM, Chris Packham
<chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org> wrote:


> -module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0);
> +module_param_string(of_id, uio_of_genirq_match[1].compatible, 128, 0000);

0 -> 0000 looks like bogus checkpatch warning.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] uio: add default compatible string to uio_pdrv_genirq

[Chris Packham]

On 21/09/17 19:50, Andy Shevchenko wrote:
> On Thu, Sep 21, 2017 at 3:53 AM, Chris Packham
> <chris.packham@alliedtelesis.co.nz> wrote:
> 
> 
>> -module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0);
>> +module_param_string(of_id, uio_of_genirq_match[1].compatible, 128, 0000);
> 
> 0 -> 0000 looks like bogus checkpatch warning.
> 

Yes. I changed it to satisfy checkpatch. I initially wasn't going to but 
then I noticed plenty of 0000 attached to module_params. I'll switch it 
back in v2.

Re: [PATCH 2/2] uio: add default compatible string to uio_pdrv_genirq

[Chris Packham]

On 21/09/17 19:50, Andy Shevchenko wrote:
> On Thu, Sep 21, 2017 at 3:53 AM, Chris Packham
> <chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org> wrote:
> 
> 
>> -module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0);
>> +module_param_string(of_id, uio_of_genirq_match[1].compatible, 128, 0000);
> 
> 0 -> 0000 looks like bogus checkpatch warning.
> 

Yes. I changed it to satisfy checkpatch. I initially wasn't going to but 
then I noticed plenty of 0000 attached to module_params. I'll switch it 
back in v2.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] uio: dt-bindings: document binding for uio-pdrv-genirq

[Greg KH]

On Thu, Sep 21, 2017 at 12:53:25PM +1200, Chris Packham wrote:
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---

I can't take patches without any changelog text, sorry.

Re: [PATCH 1/2] uio: dt-bindings: document binding for uio-pdrv-genirq

[Greg KH]

On Thu, Sep 21, 2017 at 12:53:25PM +1200, Chris Packham wrote:
> Signed-off-by: Chris Packham <chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org>
> ---

I can't take patches without any changelog text, sorry.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html