* [MINIOS PATCH] Include string.h before console.h
@ 2017-10-04 13:33 Wei Liu
2017-10-04 13:36 ` Wei Liu
2017-10-04 13:38 ` Samuel Thibault
0 siblings, 2 replies; 3+ messages in thread
From: Wei Liu @ 2017-10-04 13:33 UTC (permalink / raw)
To: Minios-devel
Cc: Xen-devel, Julien Grall, Wei Liu, Ian Jackson, Samuel Thibault
Starting from Xen commit af8d93564, it is required to include string.h
before console.h.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Julien Grall <julien.grall@arm.com>
Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>
After applying this patch to mini-os I will update Xen's Config.mk to
fix the build failure in xen.git.
I will also update mini-os's copy of Xen headers later.
---
lib/sys.c | 1 +
main.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/lib/sys.c b/lib/sys.c
index b173bc8..23dc2a5 100644
--- a/lib/sys.c
+++ b/lib/sys.c
@@ -20,6 +20,7 @@
#ifdef HAVE_LIBC
#include <os.h>
+#include <string.h>
#include <console.h>
#include <sched.h>
#include <events.h>
diff --git a/main.c b/main.c
index 263364c..4e42f53 100644
--- a/main.c
+++ b/main.c
@@ -8,6 +8,7 @@
#include <os.h>
#include <kernel.h>
#include <sched.h>
+#include <string.h>
#include <console.h>
#include <netfront.h>
#include <pcifront.h>
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [MINIOS PATCH] Include string.h before console.h
2017-10-04 13:33 [MINIOS PATCH] Include string.h before console.h Wei Liu
@ 2017-10-04 13:36 ` Wei Liu
2017-10-04 13:38 ` Samuel Thibault
1 sibling, 0 replies; 3+ messages in thread
From: Wei Liu @ 2017-10-04 13:36 UTC (permalink / raw)
To: Minios-devel
Cc: Xen-devel, Julien Grall, Wei Liu, Ian Jackson, Samuel Thibault
On Wed, Oct 04, 2017 at 02:33:36PM +0100, Wei Liu wrote:
> Starting from Xen commit af8d93564, it is required to include string.h
> before console.h.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Sorry this one isn't complete. There are other instances where string.h
are needed. But the basic idea is the same.
> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Julien Grall <julien.grall@arm.com>
> Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>
>
> After applying this patch to mini-os I will update Xen's Config.mk to
> fix the build failure in xen.git.
>
> I will also update mini-os's copy of Xen headers later.
> ---
> lib/sys.c | 1 +
> main.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/lib/sys.c b/lib/sys.c
> index b173bc8..23dc2a5 100644
> --- a/lib/sys.c
> +++ b/lib/sys.c
> @@ -20,6 +20,7 @@
>
> #ifdef HAVE_LIBC
> #include <os.h>
> +#include <string.h>
> #include <console.h>
> #include <sched.h>
> #include <events.h>
> diff --git a/main.c b/main.c
> index 263364c..4e42f53 100644
> --- a/main.c
> +++ b/main.c
> @@ -8,6 +8,7 @@
> #include <os.h>
> #include <kernel.h>
> #include <sched.h>
> +#include <string.h>
> #include <console.h>
> #include <netfront.h>
> #include <pcifront.h>
> --
> 2.11.0
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [MINIOS PATCH] Include string.h before console.h
2017-10-04 13:33 [MINIOS PATCH] Include string.h before console.h Wei Liu
2017-10-04 13:36 ` Wei Liu
@ 2017-10-04 13:38 ` Samuel Thibault
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Thibault @ 2017-10-04 13:38 UTC (permalink / raw)
To: Wei Liu; +Cc: Minios-devel, Xen-devel, Julien Grall, Ian Jackson
Wei Liu, on mer. 04 oct. 2017 14:33:36 +0100, wrote:
> Starting from Xen commit af8d93564, it is required to include string.h
> before console.h.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Julien Grall <julien.grall@arm.com>
> Cc: Samuel Thibault <samuel.thibault@ens-lyon.org>
>
> After applying this patch to mini-os I will update Xen's Config.mk to
> fix the build failure in xen.git.
>
> I will also update mini-os's copy of Xen headers later.
> ---
> lib/sys.c | 1 +
> main.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/lib/sys.c b/lib/sys.c
> index b173bc8..23dc2a5 100644
> --- a/lib/sys.c
> +++ b/lib/sys.c
> @@ -20,6 +20,7 @@
>
> #ifdef HAVE_LIBC
> #include <os.h>
> +#include <string.h>
> #include <console.h>
> #include <sched.h>
> #include <events.h>
> diff --git a/main.c b/main.c
> index 263364c..4e42f53 100644
> --- a/main.c
> +++ b/main.c
> @@ -8,6 +8,7 @@
> #include <os.h>
> #include <kernel.h>
> #include <sched.h>
> +#include <string.h>
> #include <console.h>
> #include <netfront.h>
> #include <pcifront.h>
> --
> 2.11.0
>
--
Samuel
Battery 1: charging, 90%, charging at zero rate - will never fully charge.
-+- acpi - et pourtant, ca monte -+-
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-04 13:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-04 13:33 [MINIOS PATCH] Include string.h before console.h Wei Liu
2017-10-04 13:36 ` Wei Liu
2017-10-04 13:38 ` Samuel Thibault
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.