[PATCH] platform/x86: mlx-platform: make a couple of structures static

[PATCH] platform/x86: mlx-platform: make a couple of structures static

[Colin King]

From: Colin Ian King <colin.king@canonical.com>

The structures mlxplat_dev and mlxplat_hotplug are local to the source
and do not need to be in global scope, so make them static.

Cleans up sparse warnings:
symbol 'mlxplat_dev' was not declared. Should it be static?
symbol 'mlxplat_hotplug' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/platform/x86/mlx-platform.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c
index 4f3de2a8c4df..504256c3660d 100644
--- a/drivers/platform/x86/mlx-platform.c
+++ b/drivers/platform/x86/mlx-platform.c
@@ -216,8 +216,8 @@ static struct resource mlxplat_mlxcpld_resources[] = {
 	[0] = DEFINE_RES_IRQ_NAMED(17, "mlxcpld-hotplug"),
 };
 
-struct platform_device *mlxplat_dev;
-struct mlxcpld_hotplug_platform_data *mlxplat_hotplug;
+static struct platform_device *mlxplat_dev;
+static struct mlxcpld_hotplug_platform_data *mlxplat_hotplug;
 
 static int __init mlxplat_dmi_default_matched(const struct dmi_system_id *dmi)
 {
-- 
2.14.1

[PATCH] platform/x86: mlx-platform: make a couple of structures static

[Colin King]

From: Colin Ian King <colin.king@canonical.com>

The structures mlxplat_dev and mlxplat_hotplug are local to the source
and do not need to be in global scope, so make them static.

Cleans up sparse warnings:
symbol 'mlxplat_dev' was not declared. Should it be static?
symbol 'mlxplat_hotplug' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/platform/x86/mlx-platform.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c
index 4f3de2a8c4df..504256c3660d 100644
--- a/drivers/platform/x86/mlx-platform.c
+++ b/drivers/platform/x86/mlx-platform.c
@@ -216,8 +216,8 @@ static struct resource mlxplat_mlxcpld_resources[] = {
 	[0] = DEFINE_RES_IRQ_NAMED(17, "mlxcpld-hotplug"),
 };
 
-struct platform_device *mlxplat_dev;
-struct mlxcpld_hotplug_platform_data *mlxplat_hotplug;
+static struct platform_device *mlxplat_dev;
+static struct mlxcpld_hotplug_platform_data *mlxplat_hotplug;
 
 static int __init mlxplat_dmi_default_matched(const struct dmi_system_id *dmi)
 {
-- 
2.14.1

Re: [PATCH] platform/x86: mlx-platform: make a couple of structures static

[Andy Shevchenko]

On Thu, Oct 5, 2017 at 1:42 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The structures mlxplat_dev and mlxplat_hotplug are local to the source
> and do not need to be in global scope, so make them static.
>
> Cleans up sparse warnings:
> symbol 'mlxplat_dev' was not declared. Should it be static?
> symbol 'mlxplat_hotplug' was not declared. Should it be static?

Thanks for the patch.
Since Vadim did some rather big driver changes I would like to hear
from him how to proceed with this one: either I apply it now, or after
we get Vadim's series in.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] platform/x86: mlx-platform: make a couple of structures static

[Andy Shevchenko]

On Thu, Oct 5, 2017 at 1:42 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The structures mlxplat_dev and mlxplat_hotplug are local to the source
> and do not need to be in global scope, so make them static.
>
> Cleans up sparse warnings:
> symbol 'mlxplat_dev' was not declared. Should it be static?
> symbol 'mlxplat_hotplug' was not declared. Should it be static?

Thanks for the patch.
Since Vadim did some rather big driver changes I would like to hear
from him how to proceed with this one: either I apply it now, or after
we get Vadim's series in.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] platform/x86: mlx-platform: make a couple of structures static

[Darren Hart]

On Sat, Oct 07, 2017 at 05:03:41PM +0300, Andy Shevchenko wrote:
> On Thu, Oct 5, 2017 at 1:42 PM, Colin King <colin.king@canonical.com> wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The structures mlxplat_dev and mlxplat_hotplug are local to the source
> > and do not need to be in global scope, so make them static.
> >
> > Cleans up sparse warnings:
> > symbol 'mlxplat_dev' was not declared. Should it be static?
> > symbol 'mlxplat_hotplug' was not declared. Should it be static?
> 
> Thanks for the patch.
> Since Vadim did some rather big driver changes I would like to hear
> from him how to proceed with this one: either I apply it now, or after
> we get Vadim's series in.

I'll be working with Vadim's series shortly and would like to take this
after that is settled.

-- 
Darren Hart
VMware Open Source Technology Center

Re: [PATCH] platform/x86: mlx-platform: make a couple of structures static

[Darren Hart]

On Sat, Oct 07, 2017 at 05:03:41PM +0300, Andy Shevchenko wrote:
> On Thu, Oct 5, 2017 at 1:42 PM, Colin King <colin.king@canonical.com> wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The structures mlxplat_dev and mlxplat_hotplug are local to the source
> > and do not need to be in global scope, so make them static.
> >
> > Cleans up sparse warnings:
> > symbol 'mlxplat_dev' was not declared. Should it be static?
> > symbol 'mlxplat_hotplug' was not declared. Should it be static?
> 
> Thanks for the patch.
> Since Vadim did some rather big driver changes I would like to hear
> from him how to proceed with this one: either I apply it now, or after
> we get Vadim's series in.

I'll be working with Vadim's series shortly and would like to take this
after that is settled.

-- 
Darren Hart
VMware Open Source Technology Center

Re: [PATCH] platform/x86: mlx-platform: make a couple of structures static

[Darren Hart]

On Sat, Oct 07, 2017 at 05:03:41PM +0300, Andy Shevchenko wrote:
> On Thu, Oct 5, 2017 at 1:42 PM, Colin King <colin.king@canonical.com> wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The structures mlxplat_dev and mlxplat_hotplug are local to the source
> > and do not need to be in global scope, so make them static.
> >
> > Cleans up sparse warnings:
> > symbol 'mlxplat_dev' was not declared. Should it be static?
> > symbol 'mlxplat_hotplug' was not declared. Should it be static?
> 
> Thanks for the patch.
> Since Vadim did some rather big driver changes I would like to hear
> from him how to proceed with this one: either I apply it now, or after
> we get Vadim's series in.
> 

I've asked Vadim to rework some of the mlx platform and hotplug patches, so I'll
be taking this now as it is a minimal patch - this way it doesn't get lost.

Thanks Colin.

-- 
Darren Hart
VMware Open Source Technology Center

Re: [PATCH] platform/x86: mlx-platform: make a couple of structures static

[Darren Hart]

On Sat, Oct 07, 2017 at 05:03:41PM +0300, Andy Shevchenko wrote:
> On Thu, Oct 5, 2017 at 1:42 PM, Colin King <colin.king@canonical.com> wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The structures mlxplat_dev and mlxplat_hotplug are local to the source
> > and do not need to be in global scope, so make them static.
> >
> > Cleans up sparse warnings:
> > symbol 'mlxplat_dev' was not declared. Should it be static?
> > symbol 'mlxplat_hotplug' was not declared. Should it be static?
> 
> Thanks for the patch.
> Since Vadim did some rather big driver changes I would like to hear
> from him how to proceed with this one: either I apply it now, or after
> we get Vadim's series in.
> 

I've asked Vadim to rework some of the mlx platform and hotplug patches, so I'll
be taking this now as it is a minimal patch - this way it doesn't get lost.

Thanks Colin.

-- 
Darren Hart
VMware Open Source Technology Center