[PATCH] libipvs: discrepancy with libnl genlmsg_put

* [PATCH] libipvs: discrepancy with libnl genlmsg_put
@ 2017-09-27 15:31 baloo
  2017-10-05 10:03 ` Jesper Dangaard Brouer
  0 siblings, 1 reply; 3+ messages in thread
From: baloo @ 2017-09-27 15:31 UTC (permalink / raw)
  To: lvs-devel
  Cc: Arthur Gautier, Julian Anastasov, Simon Horman, Jesper Dangaard Brouer

From: Arthur Gautier <baloo@gandi.net>

There is a mixup between NL_AUTO_PORT and NL_AUTO_PID. The
first should be used with genlmsg_put while the second with
nlmsg_put.

This is not a problem, because both NL_AUTO_PORT and NL_AUTO_PID
have the same value, but still a discrepancy with libnl documentation.

see documentation of genlmsg_put here:
  http://www.infradead.org/~tgr/libnl/doc/api/group__genl.html#ga9a86a71bbba6961d41b8a75f62f9e946

Cc: Julian Anastasov <ja@ssi.bg>
Cc: Simon Horman <horms@verge.net.au>
Cc: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: Arthur Gautier <baloo@gandi.net>
---
 libipvs/libipvs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libipvs/libipvs.c b/libipvs/libipvs.c
index d271c48e36faa..a8432431fbbf6 100644
--- a/libipvs/libipvs.c
+++ b/libipvs/libipvs.c
@@ -63,7 +63,7 @@ struct nl_msg *ipvs_nl_message(int cmd, int flags)
 	if (!msg)
 		return NULL;
 
-	genlmsg_put(msg, NL_AUTO_PID, NL_AUTO_SEQ, family, 0, flags,
+	genlmsg_put(msg, NL_AUTO_PORT, NL_AUTO_SEQ, family, 0, flags,
 		    cmd, IPVS_GENL_VERSION);
 
 	return msg;
-- 
2.14.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread