* Input: synaptics - Lenovo X1 Carbon 5 devices should use SMBUS/RMI
@ 2017-10-05 18:22 Yiannis Marangos
2017-10-05 18:22 ` [PATCH 1/2] Input: synaptics-rmi4 - RMI4 can also use SMBUS version 3 Yiannis Marangos
2017-10-05 18:22 ` [PATCH 2/2] Input: synaptics - Lenovo X1 Carbon 5 devices should use SMBUS/RMI Yiannis Marangos
0 siblings, 2 replies; 4+ messages in thread
From: Yiannis Marangos @ 2017-10-05 18:22 UTC (permalink / raw)
To: linux-input
Hi,
These patches were tested in 4.12.8 for almost a month, in 4.13.2 for almost
a month and in 4.14-rc3. No problems were found.
This is a resend of my previous email because the introductory message didn't
make it to the mailing list.
Regards,
Yiannis.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] Input: synaptics-rmi4 - RMI4 can also use SMBUS version 3
2017-10-05 18:22 Input: synaptics - Lenovo X1 Carbon 5 devices should use SMBUS/RMI Yiannis Marangos
@ 2017-10-05 18:22 ` Yiannis Marangos
2017-10-05 18:22 ` [PATCH 2/2] Input: synaptics - Lenovo X1 Carbon 5 devices should use SMBUS/RMI Yiannis Marangos
1 sibling, 0 replies; 4+ messages in thread
From: Yiannis Marangos @ 2017-10-05 18:22 UTC (permalink / raw)
To: linux-input; +Cc: Yiannis Marangos
Some synaptics devices such as LEN0073 use SMBUS version 3.
---
drivers/input/rmi4/rmi_smbus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/rmi4/rmi_smbus.c b/drivers/input/rmi4/rmi_smbus.c
index 225025a0940c..b6ccf39c6a7b 100644
--- a/drivers/input/rmi4/rmi_smbus.c
+++ b/drivers/input/rmi4/rmi_smbus.c
@@ -312,7 +312,7 @@ static int rmi_smb_probe(struct i2c_client *client,
rmi_smb->xport.dev = &client->dev;
rmi_smb->xport.pdata = *pdata;
rmi_smb->xport.pdata.irq = client->irq;
- rmi_smb->xport.proto_name = "smb2";
+ rmi_smb->xport.proto_name = "smb";
rmi_smb->xport.ops = &rmi_smb_ops;
smbus_version = rmi_smb_get_version(rmi_smb);
@@ -322,7 +322,7 @@ static int rmi_smb_probe(struct i2c_client *client,
rmi_dbg(RMI_DEBUG_XPORT, &client->dev, "Smbus version is %d",
smbus_version);
- if (smbus_version != 2) {
+ if (smbus_version != 2 && smbus_version != 3) {
dev_err(&client->dev, "Unrecognized SMB version %d\n",
smbus_version);
return -ENODEV;
--
2.14.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] Input: synaptics - Lenovo X1 Carbon 5 devices should use SMBUS/RMI
2017-10-05 18:22 Input: synaptics - Lenovo X1 Carbon 5 devices should use SMBUS/RMI Yiannis Marangos
2017-10-05 18:22 ` [PATCH 1/2] Input: synaptics-rmi4 - RMI4 can also use SMBUS version 3 Yiannis Marangos
@ 2017-10-05 18:22 ` Yiannis Marangos
1 sibling, 0 replies; 4+ messages in thread
From: Yiannis Marangos @ 2017-10-05 18:22 UTC (permalink / raw)
To: linux-input; +Cc: Yiannis Marangos
X1 Carbon 5 has two synaptics ids: LEN0072 and LEN0073.
---
drivers/input/mouse/synaptics.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 5af0b7d200bc..c9ab666e5ab1 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -172,6 +172,8 @@ static const char * const smbus_pnp_ids[] = {
"LEN0048", /* X1 Carbon 3 */
"LEN0046", /* X250 */
"LEN004a", /* W541 */
+ "LEN0072", /* X1 Carbon 5 */
+ "LEN0073", /* X1 Carbon 5 */
"LEN200f", /* T450s */
NULL
};
--
2.14.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] Input: synaptics - Lenovo X1 Carbon 5 devices should use SMBUS/RMI
2017-10-05 17:43 Yiannis Marangos
@ 2017-10-05 17:43 ` Yiannis Marangos
0 siblings, 0 replies; 4+ messages in thread
From: Yiannis Marangos @ 2017-10-05 17:43 UTC (permalink / raw)
To: linux-input; +Cc: Yiannis Marangos
X1 Carbon 5 has two synaptics ids: LEN0072 and LEN0073.
---
drivers/input/mouse/synaptics.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 5af0b7d200bc..c9ab666e5ab1 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -172,6 +172,8 @@ static const char * const smbus_pnp_ids[] = {
"LEN0048", /* X1 Carbon 3 */
"LEN0046", /* X250 */
"LEN004a", /* W541 */
+ "LEN0072", /* X1 Carbon 5 */
+ "LEN0073", /* X1 Carbon 5 */
"LEN200f", /* T450s */
NULL
};
--
2.14.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-05 18:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-05 18:22 Input: synaptics - Lenovo X1 Carbon 5 devices should use SMBUS/RMI Yiannis Marangos
2017-10-05 18:22 ` [PATCH 1/2] Input: synaptics-rmi4 - RMI4 can also use SMBUS version 3 Yiannis Marangos
2017-10-05 18:22 ` [PATCH 2/2] Input: synaptics - Lenovo X1 Carbon 5 devices should use SMBUS/RMI Yiannis Marangos
-- strict thread matches above, loose matches on Subject: below --
2017-10-05 17:43 Yiannis Marangos
2017-10-05 17:43 ` [PATCH 2/2] " Yiannis Marangos
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.