From: Peter Zijlstra <peterz@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
Mika Kuoppala <mika.kuoppala@intel.com>,
Marta Lofstedt <marta.lofstedt@intel.com>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 2/2] drm/i915: Use rcu instead of stop_machine in set_wedged
Date: Fri, 6 Oct 2017 13:12:42 +0200 [thread overview]
Message-ID: <20171006111242.5vqwotkqxiaajsqh@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <alpine.DEB.2.20.1710061205120.1836@nanos>
On Fri, Oct 06, 2017 at 12:12:41PM +0200, Thomas Gleixner wrote:
> So if you don't have a compelling technical reason to
> use it, then it _is_ the wrong tool.
This. stop_machine() effectively takes down _all_ CPUs for the duration
of your callback. That is something you really should avoid at pretty
much any cost.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
Daniel Vetter <daniel.vetter@intel.com>,
Mika Kuoppala <mika.kuoppala@intel.com>
Subject: Re: [PATCH 2/2] drm/i915: Use rcu instead of stop_machine in set_wedged
Date: Fri, 6 Oct 2017 13:12:42 +0200 [thread overview]
Message-ID: <20171006111242.5vqwotkqxiaajsqh@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <alpine.DEB.2.20.1710061205120.1836@nanos>
On Fri, Oct 06, 2017 at 12:12:41PM +0200, Thomas Gleixner wrote:
> So if you don't have a compelling technical reason to
> use it, then it _is_ the wrong tool.
This. stop_machine() effectively takes down _all_ CPUs for the duration
of your callback. That is something you really should avoid at pretty
much any cost.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-06 11:12 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 9:06 [PATCH 1/2] drm/i915: Preallocate our mmu notifier workequeu to unbreak cpu hotplug deadlock Daniel Vetter
2017-10-06 9:06 ` Daniel Vetter
2017-10-06 9:06 ` [PATCH 2/2] drm/i915: Use rcu instead of stop_machine in set_wedged Daniel Vetter
2017-10-06 9:06 ` Daniel Vetter
2017-10-06 9:17 ` Chris Wilson
2017-10-06 9:17 ` Chris Wilson
2017-10-06 10:12 ` Thomas Gleixner
2017-10-06 10:12 ` Thomas Gleixner
2017-10-06 11:12 ` Peter Zijlstra [this message]
2017-10-06 11:12 ` Peter Zijlstra
2017-10-06 14:12 ` Daniel Vetter
2017-10-06 11:03 ` Chris Wilson
2017-10-06 11:03 ` Chris Wilson
2017-10-06 14:20 ` Daniel Vetter
2017-10-06 17:29 ` Chris Wilson
2017-10-09 9:12 ` Daniel Vetter
2017-10-09 9:12 ` Daniel Vetter
2017-10-06 17:37 ` Chris Wilson
2017-10-09 9:26 ` Daniel Vetter
2017-10-09 9:26 ` Daniel Vetter
2017-10-06 11:10 ` Peter Zijlstra
2017-10-06 9:23 ` [PATCH 1/2] drm/i915: Preallocate our mmu notifier workequeu to unbreak cpu hotplug deadlock Chris Wilson
2017-10-06 9:23 ` Chris Wilson
2017-10-06 9:48 ` Chris Wilson
2017-10-06 9:48 ` Chris Wilson
2017-10-06 11:34 ` [Intel-gfx] " Tvrtko Ursulin
2017-10-06 11:34 ` Tvrtko Ursulin
2017-10-06 14:23 ` [Intel-gfx] " Daniel Vetter
2017-10-06 14:23 ` Daniel Vetter
2017-10-06 14:44 ` [Intel-gfx] " Tvrtko Ursulin
2017-10-06 12:50 ` ✗ Fi.CI.BAT: warning for series starting with [1/2] " Patchwork
2017-10-06 15:52 ` [PATCH] " Daniel Vetter
2017-10-06 16:07 ` Tvrtko Ursulin
2017-10-06 16:29 ` ✓ Fi.CI.BAT: success for series starting with drm/i915: Preallocate our mmu notifier workequeu to unbreak cpu hotplug deadlock (rev2) Patchwork
2017-10-06 22:20 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-10-09 16:44 [PATCH 1/2] drm/i915: Preallocate our mmu notifier workequeu to unbreak cpu hotplug deadlock Daniel Vetter
2017-10-09 16:44 ` [PATCH 2/2] drm/i915: Use rcu instead of stop_machine in set_wedged Daniel Vetter
2017-10-10 9:21 ` Chris Wilson
2017-10-10 12:30 ` Daniel Vetter
2017-10-10 13:29 ` Chris Wilson
2017-10-10 9:50 ` Mika Kuoppala
2017-10-10 12:37 ` Daniel Vetter
2017-10-10 13:39 ` Chris Wilson
2017-10-10 14:09 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171006111242.5vqwotkqxiaajsqh@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marta.lofstedt@intel.com \
--cc=mika.kuoppala@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.