* [PATCH igt] igt/gem_eio: Check hang/eio recovery during suspend
@ 2017-10-06 11:14 Chris Wilson
2017-10-06 18:41 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Chris Wilson @ 2017-10-06 11:14 UTC (permalink / raw)
To: intel-gfx
When we suspend, we do not want to be interrupted by a pending reset, or
failure of that reset. After the resume, the errors should be noted as
usual.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/gem_eio.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 48 insertions(+)
diff --git a/tests/gem_eio.c b/tests/gem_eio.c
index 608b2dfd..899cb627 100644
--- a/tests/gem_eio.c
+++ b/tests/gem_eio.c
@@ -207,6 +207,51 @@ static void test_inflight(int fd)
}
}
+static void test_inflight_suspend(int fd)
+{
+ struct drm_i915_gem_execbuffer2 execbuf;
+ struct drm_i915_gem_exec_object2 obj[2];
+ uint32_t bbe = MI_BATCH_BUFFER_END;
+ int fence[64]; /* conservative estimate of ring size */
+ igt_hang_t hang;
+
+ igt_require(gem_has_exec_fence(fd));
+ igt_require(i915_reset_control(false));
+
+ memset(obj, 0, sizeof(obj));
+ obj[0].flags = EXEC_OBJECT_WRITE;
+ obj[1].handle = gem_create(fd, 4096);
+ gem_write(fd, obj[1].handle, 0, &bbe, sizeof(bbe));
+
+ hang = igt_hang_ring(fd, 0);
+ obj[0].handle = hang.handle;
+
+ memset(&execbuf, 0, sizeof(execbuf));
+ execbuf.buffers_ptr = to_user_pointer(obj);
+ execbuf.buffer_count = 2;
+ execbuf.flags = I915_EXEC_FENCE_OUT;
+
+ for (unsigned int n = 0; n < ARRAY_SIZE(fence); n++) {
+ gem_execbuf_wr(fd, &execbuf);
+ fence[n] = execbuf.rsvd2 >> 32;
+ igt_assert(fence[n] != -1);
+ }
+
+ igt_system_suspend_autoresume(SUSPEND_STATE_MEM,
+ SUSPEND_TEST_DEVICES);
+
+ igt_post_hang_ring(fd, hang);
+
+ igt_assert_eq(__gem_wait(fd, obj[1].handle, -1), 0);
+ for (unsigned int n = 0; n < ARRAY_SIZE(fence); n++) {
+ igt_assert_eq(sync_fence_status(fence[n]), -EIO);
+ close(fence[n]);
+ }
+
+ igt_assert(i915_reset_control(true));
+ trigger_reset(fd);
+}
+
static uint32_t __gem_context_create(int fd)
{
struct drm_i915_gem_context_create create;
@@ -454,4 +499,7 @@ igt_main
igt_skip_on(caps & HAVE_SEMAPHORES);
test_inflight_internal(fd);
}
+
+ igt_subtest("in-flight-suspend")
+ test_inflight_suspend(fd);
}
--
2.14.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* ✓ Fi.CI.BAT: success for igt/gem_eio: Check hang/eio recovery during suspend
2017-10-06 11:14 [PATCH igt] igt/gem_eio: Check hang/eio recovery during suspend Chris Wilson
@ 2017-10-06 18:41 ` Patchwork
2017-10-07 3:38 ` ✓ Fi.CI.IGT: " Patchwork
2017-10-12 9:09 ` [PATCH igt] " Michał Winiarski
2 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2017-10-06 18:41 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: igt/gem_eio: Check hang/eio recovery during suspend
URL : https://patchwork.freedesktop.org/series/31485/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
d8954f05024d73a8b3f26fa0d5892d067a70fdac igt/gem_exec_scheduler: Add small priority sorting smoketest
with latest DRM-Tip kernel build CI_DRM_3188
aaf31e875e72 drm-tip: 2017y-10m-06d-17h-24m-22s UTC integration manifest
Testlist changes:
+igt@gem_eio@in-flight-suspend
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (fi-byt-j1900) fdo#101705
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:457s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:479s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:393s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:593s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:290s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:535s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:539s
fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:549s
fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:543s
fi-cfl-s total:289 pass:256 dwarn:1 dfail:0 fail:0 skip:32 time:571s
fi-cnl-y total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:642s
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:440s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:607s
fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:442s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:423s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:509s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:477s
fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:506s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:590s
fi-kbl-7567u total:289 pass:265 dwarn:4 dfail:0 fail:0 skip:20 time:494s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:601s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:657s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:479s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:664s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:542s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:526s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:476s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:588s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:437s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_305/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* ✓ Fi.CI.IGT: success for igt/gem_eio: Check hang/eio recovery during suspend
2017-10-06 11:14 [PATCH igt] igt/gem_eio: Check hang/eio recovery during suspend Chris Wilson
2017-10-06 18:41 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-10-07 3:38 ` Patchwork
2017-10-12 8:15 ` Arkadiusz Hiler
2017-10-12 9:09 ` [PATCH igt] " Michał Winiarski
2 siblings, 1 reply; 7+ messages in thread
From: Patchwork @ 2017-10-07 3:38 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: igt/gem_eio: Check hang/eio recovery during suspend
URL : https://patchwork.freedesktop.org/series/31485/
State : success
== Summary ==
Test gem_eio:
Subgroup in-flight-contexts:
dmesg-warn -> PASS (shard-hsw) fdo#102886 +1
Test kms_cursor_legacy:
Subgroup cursorA-vs-flipA-atomic-transitions:
fail -> PASS (shard-hsw) fdo#102723
fdo#102886 https://bugs.freedesktop.org/show_bug.cgi?id=102886
fdo#102723 https://bugs.freedesktop.org/show_bug.cgi?id=102723
shard-hsw total:2447 pass:1329 dwarn:7 dfail:0 fail:8 skip:1103 time:10232s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_305/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: ✓ Fi.CI.IGT: success for igt/gem_eio: Check hang/eio recovery during suspend
2017-10-07 3:38 ` ✓ Fi.CI.IGT: " Patchwork
@ 2017-10-12 8:15 ` Arkadiusz Hiler
2017-10-12 8:20 ` Chris Wilson
0 siblings, 1 reply; 7+ messages in thread
From: Arkadiusz Hiler @ 2017-10-12 8:15 UTC (permalink / raw)
To: intel-gfx
On Sat, Oct 07, 2017 at 03:38:09AM +0000, Patchwork wrote:
> == Series Details ==
>
> Series: igt/gem_eio: Check hang/eio recovery during suspend
> URL : https://patchwork.freedesktop.org/series/31485/
> State : success
>
> == Summary ==
>
> Test gem_eio:
> Subgroup in-flight-contexts:
> dmesg-warn -> PASS (shard-hsw) fdo#102886 +1
> Test kms_cursor_legacy:
> Subgroup cursorA-vs-flipA-atomic-transitions:
> fail -> PASS (shard-hsw) fdo#102723
>
> fdo#102886 https://bugs.freedesktop.org/show_bug.cgi?id=102886
> fdo#102723 https://bugs.freedesktop.org/show_bug.cgi?id=102723
>
> shard-hsw total:2447 pass:1329 dwarn:7 dfail:0 fail:8 skip:1103 time:10232s
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_305/shards.html
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_305/shards-all.html
3x dmesg-warn with moaning about lock dependency in i915_gem_suspend, huh
but the one incomplete is even more concerning
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: ✓ Fi.CI.IGT: success for igt/gem_eio: Check hang/eio recovery during suspend
2017-10-12 8:15 ` Arkadiusz Hiler
@ 2017-10-12 8:20 ` Chris Wilson
2017-10-18 6:30 ` Daniel Vetter
0 siblings, 1 reply; 7+ messages in thread
From: Chris Wilson @ 2017-10-12 8:20 UTC (permalink / raw)
To: Arkadiusz Hiler, intel-gfx
Quoting Arkadiusz Hiler (2017-10-12 09:15:33)
> On Sat, Oct 07, 2017 at 03:38:09AM +0000, Patchwork wrote:
> > == Series Details ==
> >
> > Series: igt/gem_eio: Check hang/eio recovery during suspend
> > URL : https://patchwork.freedesktop.org/series/31485/
> > State : success
> >
> > == Summary ==
> >
> > Test gem_eio:
> > Subgroup in-flight-contexts:
> > dmesg-warn -> PASS (shard-hsw) fdo#102886 +1
> > Test kms_cursor_legacy:
> > Subgroup cursorA-vs-flipA-atomic-transitions:
> > fail -> PASS (shard-hsw) fdo#102723
> >
> > fdo#102886 https://bugs.freedesktop.org/show_bug.cgi?id=102886
> > fdo#102723 https://bugs.freedesktop.org/show_bug.cgi?id=102723
> >
> > shard-hsw total:2447 pass:1329 dwarn:7 dfail:0 fail:8 skip:1103 time:10232s
> >
> > == Logs ==
> >
> > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_305/shards.html
>
> https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_305/shards-all.html
>
> 3x dmesg-warn with moaning about lock dependency in i915_gem_suspend,
They are not new.
> huh but the one incomplete is even more concerning
And lacks info, so could be anything including a new discovery
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH igt] igt/gem_eio: Check hang/eio recovery during suspend
2017-10-06 11:14 [PATCH igt] igt/gem_eio: Check hang/eio recovery during suspend Chris Wilson
2017-10-06 18:41 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-07 3:38 ` ✓ Fi.CI.IGT: " Patchwork
@ 2017-10-12 9:09 ` Michał Winiarski
2 siblings, 0 replies; 7+ messages in thread
From: Michał Winiarski @ 2017-10-12 9:09 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On Fri, Oct 06, 2017 at 11:14:20AM +0000, Chris Wilson wrote:
> When we suspend, we do not want to be interrupted by a pending reset, or
> failure of that reset. After the resume, the errors should be noted as
> usual.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Michał Winiarski <michal.winiarski@intel.com>
-Michał
> ---
> tests/gem_eio.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 48 insertions(+)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: ✓ Fi.CI.IGT: success for igt/gem_eio: Check hang/eio recovery during suspend
2017-10-12 8:20 ` Chris Wilson
@ 2017-10-18 6:30 ` Daniel Vetter
0 siblings, 0 replies; 7+ messages in thread
From: Daniel Vetter @ 2017-10-18 6:30 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On Thu, Oct 12, 2017 at 09:20:46AM +0100, Chris Wilson wrote:
> Quoting Arkadiusz Hiler (2017-10-12 09:15:33)
> > On Sat, Oct 07, 2017 at 03:38:09AM +0000, Patchwork wrote:
> > > == Series Details ==
> > >
> > > Series: igt/gem_eio: Check hang/eio recovery during suspend
> > > URL : https://patchwork.freedesktop.org/series/31485/
> > > State : success
> > >
> > > == Summary ==
> > >
> > > Test gem_eio:
> > > Subgroup in-flight-contexts:
> > > dmesg-warn -> PASS (shard-hsw) fdo#102886 +1
> > > Test kms_cursor_legacy:
> > > Subgroup cursorA-vs-flipA-atomic-transitions:
> > > fail -> PASS (shard-hsw) fdo#102723
> > >
> > > fdo#102886 https://bugs.freedesktop.org/show_bug.cgi?id=102886
> > > fdo#102723 https://bugs.freedesktop.org/show_bug.cgi?id=102723
> > >
> > > shard-hsw total:2447 pass:1329 dwarn:7 dfail:0 fail:8 skip:1103 time:10232s
> > >
> > > == Logs ==
> > >
> > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_305/shards.html
> >
> > https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_305/shards-all.html
> >
> > 3x dmesg-warn with moaning about lock dependency in i915_gem_suspend,
>
> They are not new.
>
> > huh but the one incomplete is even more concerning
>
> And lacks info, so could be anything including a new discovery
It is, this new gem_eio/in-flight-suspend kills snb. Do you have a bugfix?
We've been pretty close to adding snb to the set of shard machines that
report results, but this sets it back again (we can't have incompletes due
to the other tests that victimizes).
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-10-18 6:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-06 11:14 [PATCH igt] igt/gem_eio: Check hang/eio recovery during suspend Chris Wilson
2017-10-06 18:41 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-07 3:38 ` ✓ Fi.CI.IGT: " Patchwork
2017-10-12 8:15 ` Arkadiusz Hiler
2017-10-12 8:20 ` Chris Wilson
2017-10-18 6:30 ` Daniel Vetter
2017-10-12 9:09 ` [PATCH igt] " Michał Winiarski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.