From: David Miller <davem@davemloft.net>
To: vijay.ac.kumar@oracle.com
Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
babu.moger@oracle.com, rob.gardner@oracle.com, sam@ravnborg.org
Subject: Re: [PATCH v3 3/5] sparc64: SPARC optimised fls function
Date: Sun, 08 Oct 2017 21:39:57 -0700 (PDT) [thread overview]
Message-ID: <20171008.213957.296383983633615999.davem@davemloft.net> (raw)
In-Reply-To: <1507308893-9218-4-git-send-email-vijay.ac.kumar@oracle.com>
From: Vijay Kumar <vijay.ac.kumar@oracle.com>
Date: Fri, 6 Oct 2017 10:54:51 -0600
> +#define LXCNT_O0_G2 \
> + .word 0x85b002e8
> +
> + .text
> + .register %g2, #scratch
> + .register %g3, #scratch
> +
> +ENTRY(NG4fls)
> + LXCNT_O0_G2 !lzcnt %o0, %g2
Agreed with others that you should name this LZCNT_* instead of
LXCNT_*.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: vijay.ac.kumar@oracle.com
Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
babu.moger@oracle.com, rob.gardner@oracle.com, sam@ravnborg.org
Subject: Re: [PATCH v3 3/5] sparc64: SPARC optimised fls function
Date: Mon, 09 Oct 2017 04:39:57 +0000 [thread overview]
Message-ID: <20171008.213957.296383983633615999.davem@davemloft.net> (raw)
In-Reply-To: <1507308893-9218-4-git-send-email-vijay.ac.kumar@oracle.com>
From: Vijay Kumar <vijay.ac.kumar@oracle.com>
Date: Fri, 6 Oct 2017 10:54:51 -0600
> +#define LXCNT_O0_G2 \
> + .word 0x85b002e8
> +
> + .text
> + .register %g2, #scratch
> + .register %g3, #scratch
> +
> +ENTRY(NG4fls)
> + LXCNT_O0_G2 !lzcnt %o0, %g2
Agreed with others that you should name this LZCNT_* instead of
LXCNT_*.
next prev parent reply other threads:[~2017-10-09 4:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 16:54 [PATCH v3 0/5] sparc64: Optimize fls and __fls Vijay Kumar
2017-10-06 16:54 ` Vijay Kumar
2017-10-06 16:54 ` [PATCH v3 1/5] sparc64: Define SPARC default fls function Vijay Kumar
2017-10-06 16:54 ` Vijay Kumar
2017-10-06 16:54 ` [PATCH v3 2/5] sparc64: Define SPARC default __fls function Vijay Kumar
2017-10-06 16:54 ` Vijay Kumar
2017-10-06 16:54 ` [PATCH v3 3/5] sparc64: SPARC optimised fls function Vijay Kumar
2017-10-06 16:54 ` Vijay Kumar
2017-10-06 23:28 ` Anthony Yznaga
2017-10-06 23:28 ` Anthony Yznaga
2017-10-09 4:39 ` David Miller [this message]
2017-10-09 4:39 ` David Miller
2017-10-09 15:12 ` Vijay Kumar
2017-10-09 15:12 ` Vijay Kumar
2017-10-06 16:54 ` [PATCH v3 4/5] sparc64: SPARC optimised __fls function Vijay Kumar
2017-10-06 16:54 ` Vijay Kumar
2017-10-06 16:54 ` [PATCH v3 5/5] sparc64: Use sparc optimised fls and __fls for T4 and above Vijay Kumar
2017-10-06 16:54 ` Vijay Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171008.213957.296383983633615999.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=babu.moger@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rob.gardner@oracle.com \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
--cc=vijay.ac.kumar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.