All of lore.kernel.org
 help / color / mirror / Atom feed
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: catalin.marinas@arm.com, will.deacon@arm.com,
	bauerman@linux.vnet.ibm.com, dhowells@redhat.com,
	vgoyal@redhat.com, herbert@gondor.apana.org.au,
	davem@davemloft.net, akpm@linux-foundation.org,
	mpe@ellerman.id.au, dyoung@redhat.com, bhe@redhat.com,
	arnd@arndb.de, ard.biesheuvel@linaro.org, julien.thierry@arm.com
Cc: kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	AKASHI Takahiro <takahiro.akashi@linaro.org>
Subject: [PATCH v5 01/10] include: pe.h: remove message[] from mz header definition
Date: Tue, 10 Oct 2017 15:36:10 +0900	[thread overview]
Message-ID: <20171010063619.6303-2-takahiro.akashi@linaro.org> (raw)
In-Reply-To: <20171010063619.6303-1-takahiro.akashi@linaro.org>

message[] field won't be part of the definition of mz header.

This change is crucial for enabling kexec_file_load on arm64 because
arm64's "Image" binary, as in PE format, doesn't have any data for it and
accordingly the following check in pefile_parse_binary() will fail:

	chkaddr(cursor, mz->peaddr, sizeof(*pe));

Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: David Howells <dhowells@redhat.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David S. Miller <davem@davemloft.net>
---
 include/linux/pe.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/pe.h b/include/linux/pe.h
index 143ce75be5f0..3482b18a48b5 100644
--- a/include/linux/pe.h
+++ b/include/linux/pe.h
@@ -166,7 +166,7 @@ struct mz_hdr {
 	uint16_t oem_info;	/* oem specific */
 	uint16_t reserved1[10];	/* reserved */
 	uint32_t peaddr;	/* address of pe header */
-	char     message[64];	/* message to print */
+	char     message[];	/* message to print */
 };
 
 struct mz_reloc {
-- 
2.14.1

WARNING: multiple messages have this Message-ID (diff)
From: takahiro.akashi@linaro.org (AKASHI Takahiro)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 01/10] include: pe.h: remove message[] from mz header definition
Date: Tue, 10 Oct 2017 15:36:10 +0900	[thread overview]
Message-ID: <20171010063619.6303-2-takahiro.akashi@linaro.org> (raw)
In-Reply-To: <20171010063619.6303-1-takahiro.akashi@linaro.org>

message[] field won't be part of the definition of mz header.

This change is crucial for enabling kexec_file_load on arm64 because
arm64's "Image" binary, as in PE format, doesn't have any data for it and
accordingly the following check in pefile_parse_binary() will fail:

	chkaddr(cursor, mz->peaddr, sizeof(*pe));

Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: David Howells <dhowells@redhat.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David S. Miller <davem@davemloft.net>
---
 include/linux/pe.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/pe.h b/include/linux/pe.h
index 143ce75be5f0..3482b18a48b5 100644
--- a/include/linux/pe.h
+++ b/include/linux/pe.h
@@ -166,7 +166,7 @@ struct mz_hdr {
 	uint16_t oem_info;	/* oem specific */
 	uint16_t reserved1[10];	/* reserved */
 	uint32_t peaddr;	/* address of pe header */
-	char     message[64];	/* message to print */
+	char     message[];	/* message to print */
 };
 
 struct mz_reloc {
-- 
2.14.1

WARNING: multiple messages have this Message-ID (diff)
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: catalin.marinas@arm.com, will.deacon@arm.com,
	bauerman@linux.vnet.ibm.com, dhowells@redhat.com,
	vgoyal@redhat.com, herbert@gondor.apana.org.au,
	davem@davemloft.net, akpm@linux-foundation.org,
	mpe@ellerman.id.au, dyoung@redhat.com, bhe@redhat.com,
	arnd@arndb.de, ard.biesheuvel@linaro.org, julien.thierry@arm.com
Cc: AKASHI Takahiro <takahiro.akashi@linaro.org>,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 01/10] include: pe.h: remove message[] from mz header definition
Date: Tue, 10 Oct 2017 15:36:10 +0900	[thread overview]
Message-ID: <20171010063619.6303-2-takahiro.akashi@linaro.org> (raw)
In-Reply-To: <20171010063619.6303-1-takahiro.akashi@linaro.org>

message[] field won't be part of the definition of mz header.

This change is crucial for enabling kexec_file_load on arm64 because
arm64's "Image" binary, as in PE format, doesn't have any data for it and
accordingly the following check in pefile_parse_binary() will fail:

	chkaddr(cursor, mz->peaddr, sizeof(*pe));

Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: David Howells <dhowells@redhat.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David S. Miller <davem@davemloft.net>
---
 include/linux/pe.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/pe.h b/include/linux/pe.h
index 143ce75be5f0..3482b18a48b5 100644
--- a/include/linux/pe.h
+++ b/include/linux/pe.h
@@ -166,7 +166,7 @@ struct mz_hdr {
 	uint16_t oem_info;	/* oem specific */
 	uint16_t reserved1[10];	/* reserved */
 	uint32_t peaddr;	/* address of pe header */
-	char     message[64];	/* message to print */
+	char     message[];	/* message to print */
 };
 
 struct mz_reloc {
-- 
2.14.1


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2017-10-10  6:35 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-10  6:36 [PATCH v5 00/10] arm64: kexec: add kexec_file_load() support AKASHI Takahiro
2017-10-10  6:36 ` AKASHI Takahiro
2017-10-10  6:36 ` AKASHI Takahiro
2017-10-10  6:36 ` AKASHI Takahiro [this message]
2017-10-10  6:36   ` [PATCH v5 01/10] include: pe.h: remove message[] from mz header definition AKASHI Takahiro
2017-10-10  6:36   ` AKASHI Takahiro
2017-10-10  6:36 ` [PATCH v5 02/10] resource: add walk_system_ram_res_rev() AKASHI Takahiro
2017-10-10  6:36   ` AKASHI Takahiro
2017-10-10  6:36   ` AKASHI Takahiro
2017-10-10  6:36 ` [PATCH v5 03/10] kexec_file: factor out arch_kexec_kernel_*() from x86, powerpc AKASHI Takahiro
2017-10-10  6:36   ` AKASHI Takahiro
2017-10-10  6:36   ` AKASHI Takahiro
2017-10-10 11:02   ` Julien Thierry
2017-10-10 11:02     ` Julien Thierry
2017-10-10 11:02     ` Julien Thierry
2017-10-11  5:07     ` AKASHI Takahiro
2017-10-11  5:07       ` AKASHI Takahiro
2017-10-11  5:07       ` AKASHI Takahiro
2017-10-11  6:55       ` Ard Biesheuvel
2017-10-11  6:55         ` Ard Biesheuvel
2017-10-11  6:55         ` Ard Biesheuvel
2017-10-11  8:24       ` Julien Thierry
2017-10-11  8:24         ` Julien Thierry
2017-10-11  8:24         ` Julien Thierry
2017-10-13  8:47         ` AKASHI Takahiro
2017-10-13  8:47           ` AKASHI Takahiro
2017-10-13  8:47           ` AKASHI Takahiro
2017-10-10 11:06   ` Julien Thierry
2017-10-10 11:06     ` Julien Thierry
2017-10-10 11:06     ` Julien Thierry
2017-10-14 11:37   ` kbuild test robot
2017-10-14 11:37     ` kbuild test robot
2017-10-14 11:37     ` kbuild test robot
2017-10-19  4:36     ` AKASHI Takahiro
2017-10-19  4:36       ` AKASHI Takahiro
2017-10-19  4:36       ` AKASHI Takahiro
2017-10-15  3:10   ` kbuild test robot
2017-10-15  3:10     ` kbuild test robot
2017-10-15  3:10     ` kbuild test robot
2017-10-10  6:36 ` [PATCH v5 04/10] kexec_file: factor out crashdump elf header function from x86 AKASHI Takahiro
2017-10-10  6:36   ` AKASHI Takahiro
2017-10-10  6:36   ` AKASHI Takahiro
2017-10-10  6:36 ` [PATCH v5 05/10] asm-generic: add kexec_file_load system call to unistd.h AKASHI Takahiro
2017-10-10  6:36   ` AKASHI Takahiro
2017-10-10  6:36   ` AKASHI Takahiro
2017-10-10  6:36 ` [PATCH v5 06/10] arm64: kexec_file: create purgatory AKASHI Takahiro
2017-10-10  6:36   ` AKASHI Takahiro
2017-10-10  6:36   ` AKASHI Takahiro
2017-10-10  6:36 ` [PATCH v5 07/10] arm64: kexec_file: load initrd, device-tree and purgatory segments AKASHI Takahiro
2017-10-10  6:36   ` AKASHI Takahiro
2017-10-10  6:36   ` AKASHI Takahiro
2017-10-10  6:36 ` [PATCH v5 08/10] arm64: kexec_file: set up for crash dump adding elf core header AKASHI Takahiro
2017-10-10  6:36   ` AKASHI Takahiro
2017-10-10  6:36   ` AKASHI Takahiro
2017-10-10  6:36 ` [PATCH v5 09/10] arm64: enable KEXEC_FILE config AKASHI Takahiro
2017-10-10  6:36   ` AKASHI Takahiro
2017-10-10  6:36   ` AKASHI Takahiro
2017-10-10  6:36 ` [PATCH v5 10/10] arm64: kexec_file: add Image format support AKASHI Takahiro
2017-10-10  6:36   ` AKASHI Takahiro
2017-10-10  6:36   ` AKASHI Takahiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171010063619.6303-2-takahiro.akashi@linaro.org \
    --to=takahiro.akashi@linaro.org \
    --cc=akpm@linux-foundation.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=arnd@arndb.de \
    --cc=bauerman@linux.vnet.ibm.com \
    --cc=bhe@redhat.com \
    --cc=catalin.marinas@arm.com \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=dyoung@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=julien.thierry@arm.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=vgoyal@redhat.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.