All of lore.kernel.org
 help / color / mirror / Atom feed
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, mark.rutland@arm.com,
	robh@kernel.org, will.deacon@arm.com, sudeep.holla@arm.com,
	frowand.list@gmail.com, devicetree@vger.kernel.org,
	Jonathan.Cameron@huawei.com, marc.zyngier@arm.com,
	peterz@infradead.org, mathieu.poirier@linaro.org,
	leo.yan@linaro.org, Suzuki K Poulose <suzuki.poulose@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>
Subject: [PATCH v8 5/8] arm64: Use of_cpu_node_to_id helper for CPU topology parsing
Date: Tue, 10 Oct 2017 11:33:00 +0100	[thread overview]
Message-ID: <20171010103303.32436-6-suzuki.poulose@arm.com> (raw)
In-Reply-To: <20171010103303.32436-1-suzuki.poulose@arm.com>

Make use of the new generic helper to convert an of_node of a CPU
to the logical CPU id in parsing the topology.

Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
 arch/arm64/kernel/topology.c | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c
index 8d48b233e6ce..21868530018e 100644
--- a/arch/arm64/kernel/topology.c
+++ b/arch/arm64/kernel/topology.c
@@ -37,18 +37,14 @@ static int __init get_cpu_for_node(struct device_node *node)
 	if (!cpu_node)
 		return -1;
 
-	for_each_possible_cpu(cpu) {
-		if (of_get_cpu_node(cpu, NULL) == cpu_node) {
-			topology_parse_cpu_capacity(cpu_node, cpu);
-			of_node_put(cpu_node);
-			return cpu;
-		}
-	}
-
-	pr_crit("Unable to find CPU node for %pOF\n", cpu_node);
+	cpu = of_cpu_node_to_id(cpu_node);
+	if (cpu >= 0)
+		topology_parse_cpu_capacity(cpu_node, cpu);
+	else
+		pr_crit("Unable to find CPU node for %pOF\n", cpu_node);
 
 	of_node_put(cpu_node);
-	return -1;
+	return cpu;
 }
 
 static int __init parse_core(struct device_node *core, int cluster_id,
-- 
2.13.6

WARNING: multiple messages have this Message-ID (diff)
From: suzuki.poulose@arm.com (Suzuki K Poulose)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 5/8] arm64: Use of_cpu_node_to_id helper for CPU topology parsing
Date: Tue, 10 Oct 2017 11:33:00 +0100	[thread overview]
Message-ID: <20171010103303.32436-6-suzuki.poulose@arm.com> (raw)
In-Reply-To: <20171010103303.32436-1-suzuki.poulose@arm.com>

Make use of the new generic helper to convert an of_node of a CPU
to the logical CPU id in parsing the topology.

Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
 arch/arm64/kernel/topology.c | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c
index 8d48b233e6ce..21868530018e 100644
--- a/arch/arm64/kernel/topology.c
+++ b/arch/arm64/kernel/topology.c
@@ -37,18 +37,14 @@ static int __init get_cpu_for_node(struct device_node *node)
 	if (!cpu_node)
 		return -1;
 
-	for_each_possible_cpu(cpu) {
-		if (of_get_cpu_node(cpu, NULL) == cpu_node) {
-			topology_parse_cpu_capacity(cpu_node, cpu);
-			of_node_put(cpu_node);
-			return cpu;
-		}
-	}
-
-	pr_crit("Unable to find CPU node for %pOF\n", cpu_node);
+	cpu = of_cpu_node_to_id(cpu_node);
+	if (cpu >= 0)
+		topology_parse_cpu_capacity(cpu_node, cpu);
+	else
+		pr_crit("Unable to find CPU node for %pOF\n", cpu_node);
 
 	of_node_put(cpu_node);
-	return -1;
+	return cpu;
 }
 
 static int __init parse_core(struct device_node *core, int cluster_id,
-- 
2.13.6

  parent reply	other threads:[~2017-10-10 10:33 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-10 10:32 [PATCH v8 0/8] perf: Support for ARM DynamIQ Shared Unit Suzuki K Poulose
2017-10-10 10:32 ` Suzuki K Poulose
2017-10-10 10:32 ` Suzuki K Poulose
2017-10-10 10:32 ` [PATCH v8 1/8] perf: Export perf_event_update_userpage Suzuki K Poulose
2017-10-10 10:32   ` Suzuki K Poulose
2017-10-10 10:32 ` [PATCH v8 2/8] of: Add helper for mapping device node to logical CPU number Suzuki K Poulose
2017-10-10 10:32   ` Suzuki K Poulose
2017-10-10 10:32   ` Suzuki K Poulose
2017-10-10 10:32 ` [PATCH v8 3/8] coresight: of: Use of_cpu_node_to_id helper Suzuki K Poulose
2017-10-10 10:32   ` Suzuki K Poulose
2017-10-10 10:32 ` [PATCH v8 4/8] irqchip: gic-v3: " Suzuki K Poulose
2017-10-10 10:32   ` Suzuki K Poulose
2017-10-10 10:33 ` Suzuki K Poulose [this message]
2017-10-10 10:33   ` [PATCH v8 5/8] arm64: Use of_cpu_node_to_id helper for CPU topology parsing Suzuki K Poulose
2017-10-17 15:24   ` Mark Rutland
2017-10-17 15:24     ` Mark Rutland
2017-10-17 15:24     ` Mark Rutland
2017-10-17 16:11     ` Will Deacon
2017-10-17 16:11       ` Will Deacon
2017-10-17 16:11       ` Will Deacon
2017-10-17 16:20       ` Suzuki K Poulose
2017-10-17 16:20         ` Suzuki K Poulose
2017-10-17 16:42         ` Suzuki K Poulose
2017-10-17 16:42           ` Suzuki K Poulose
2017-10-17 16:42           ` Suzuki K Poulose
2017-10-10 10:33 ` [PATCH v8 6/8] arm_pmu: Use of_cpu_node_to_id helper Suzuki K Poulose
2017-10-10 10:33   ` Suzuki K Poulose
2017-10-17 15:26   ` Mark Rutland
2017-10-17 15:26     ` Mark Rutland
2017-10-10 10:33 ` [PATCH v8 7/8] dt-bindings: Document devicetree binding for ARM DSU PMU Suzuki K Poulose
2017-10-10 10:33   ` Suzuki K Poulose
2017-10-18  9:20   ` Mark Rutland
2017-10-18  9:20     ` Mark Rutland
2017-10-10 10:33 ` [PATCH v8 8/8] perf: ARM DynamIQ Shared Unit PMU support Suzuki K Poulose
2017-10-10 10:33   ` Suzuki K Poulose
2017-10-18  9:20   ` Mark Rutland
2017-10-18  9:20     ` Mark Rutland
2017-10-20 10:17     ` Suzuki K Poulose
2017-10-20 10:17       ` Suzuki K Poulose
2017-10-20 10:17       ` Suzuki K Poulose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171010103303.32436-6-suzuki.poulose@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=peterz@infradead.org \
    --cc=robh@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.