* [PATCH] tracing: Remove unused clock events
@ 2017-10-10 15:21 Steven Rostedt
0 siblings, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2017-10-10 15:21 UTC (permalink / raw)
To: Jean Pihet
Cc: LKML, discuss, linux-pm, Thomas Renninger, Arjan van de Ven,
Peter Zijlstra, Len Brown, Kevin Hilman, Ingo Molnar
From: Steven Rostedt (VMware) <rostedt@goodmis.org>
Commit 74704ac6 ("tracing, perf: Add more power related events") added
new events, among them were trace_clock_enable, trace_clock_disable and
trace_clock_set_rate. In the last 7 years, nothing has used them. As
they take up space, and nobody cares about these events, remove them.
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
diff --git a/include/trace/events/power.h b/include/trace/events/power.h
index 54e3aad..d900cb7 100644
--- a/include/trace/events/power.h
+++ b/include/trace/events/power.h
@@ -254,53 +254,6 @@ DEFINE_EVENT(wakeup_source, wakeup_source_deactivate,
);
/*
- * The clock events are used for clock enable/disable and for
- * clock rate change
- */
-DECLARE_EVENT_CLASS(clock,
-
- TP_PROTO(const char *name, unsigned int state, unsigned int cpu_id),
-
- TP_ARGS(name, state, cpu_id),
-
- TP_STRUCT__entry(
- __string( name, name )
- __field( u64, state )
- __field( u64, cpu_id )
- ),
-
- TP_fast_assign(
- __assign_str(name, name);
- __entry->state = state;
- __entry->cpu_id = cpu_id;
- ),
-
- TP_printk("%s state=%lu cpu_id=%lu", __get_str(name),
- (unsigned long)__entry->state, (unsigned long)__entry->cpu_id)
-);
-
-DEFINE_EVENT(clock, clock_enable,
-
- TP_PROTO(const char *name, unsigned int state, unsigned int cpu_id),
-
- TP_ARGS(name, state, cpu_id)
-);
-
-DEFINE_EVENT(clock, clock_disable,
-
- TP_PROTO(const char *name, unsigned int state, unsigned int cpu_id),
-
- TP_ARGS(name, state, cpu_id)
-);
-
-DEFINE_EVENT(clock, clock_set_rate,
-
- TP_PROTO(const char *name, unsigned int state, unsigned int cpu_id),
-
- TP_ARGS(name, state, cpu_id)
-);
-
-/*
* The power domain events are used for power domains transitions
*/
DECLARE_EVENT_CLASS(power_domain,
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] tracing: Remove unused clock events
@ 2017-10-12 16:44 Steven Rostedt
2017-10-13 7:20 ` Jean Pihet
0 siblings, 1 reply; 4+ messages in thread
From: Steven Rostedt @ 2017-10-12 16:44 UTC (permalink / raw)
To: Jean Pihet
Cc: LKML, discuss, linux-pm, Thomas Renninger, Arjan van de Ven,
Peter Zijlstra, Len Brown, Kevin Hilman, Ingo Molnar
[ Resending again, including linux-pm@vger.kernel.org this time ]
From: Steven Rostedt (VMware) <rostedt@goodmis.org>
Commit 74704ac6 ("tracing, perf: Add more power related events") added
new events, among them were trace_clock_enable, trace_clock_disable and
trace_clock_set_rate. In the last 7 years, nothing has used them. As
they take up space, and nobody cares about these events, remove them.
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
diff --git a/include/trace/events/power.h b/include/trace/events/power.h
index 54e3aad..d900cb7 100644
--- a/include/trace/events/power.h
+++ b/include/trace/events/power.h
@@ -254,53 +254,6 @@ DEFINE_EVENT(wakeup_source,
wakeup_source_deactivate, );
/*
- * The clock events are used for clock enable/disable and for
- * clock rate change
- */
-DECLARE_EVENT_CLASS(clock,
-
- TP_PROTO(const char *name, unsigned int state, unsigned int
cpu_id), -
- TP_ARGS(name, state, cpu_id),
-
- TP_STRUCT__entry(
- __string( name, name )
- __field( u64, state )
- __field( u64, cpu_id )
- ),
-
- TP_fast_assign(
- __assign_str(name, name);
- __entry->state = state;
- __entry->cpu_id = cpu_id;
- ),
-
- TP_printk("%s state=%lu cpu_id=%lu", __get_str(name),
- (unsigned long)__entry->state, (unsigned
long)__entry->cpu_id) -);
-
-DEFINE_EVENT(clock, clock_enable,
-
- TP_PROTO(const char *name, unsigned int state, unsigned int
cpu_id), -
- TP_ARGS(name, state, cpu_id)
-);
-
-DEFINE_EVENT(clock, clock_disable,
-
- TP_PROTO(const char *name, unsigned int state, unsigned int
cpu_id), -
- TP_ARGS(name, state, cpu_id)
-);
-
-DEFINE_EVENT(clock, clock_set_rate,
-
- TP_PROTO(const char *name, unsigned int state, unsigned int
cpu_id), -
- TP_ARGS(name, state, cpu_id)
-);
-
-/*
* The power domain events are used for power domains transitions
*/
DECLARE_EVENT_CLASS(power_domain,
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] tracing: Remove unused clock events
2017-10-12 16:44 Steven Rostedt
@ 2017-10-13 7:20 ` Jean Pihet
2017-10-13 14:25 ` Steven Rostedt
0 siblings, 1 reply; 4+ messages in thread
From: Jean Pihet @ 2017-10-13 7:20 UTC (permalink / raw)
To: Steven Rostedt
Cc: LKML, discuss, Linux PM list, Thomas Renninger, Arjan van de Ven,
Peter Zijlstra, Len Brown, Kevin Hilman, Ingo Molnar
Hi Steven,
On Thu, Oct 12, 2017 at 6:44 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
>
> [ Resending again, including linux-pm@vger.kernel.org this time ]
>
> From: Steven Rostedt (VMware) <rostedt@goodmis.org>
>
> Commit 74704ac6 ("tracing, perf: Add more power related events") added
> new events, among them were trace_clock_enable, trace_clock_disable and
> trace_clock_set_rate. In the last 7 years, nothing has used them. As
> they take up space, and nobody cares about these events, remove them.
Ok if it is not used. Can others confirm?
AFAIK this has been used internally.
BR,
Jean
>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> ---
> diff --git a/include/trace/events/power.h b/include/trace/events/power.h
> index 54e3aad..d900cb7 100644
> --- a/include/trace/events/power.h
> +++ b/include/trace/events/power.h
> @@ -254,53 +254,6 @@ DEFINE_EVENT(wakeup_source,
> wakeup_source_deactivate, );
>
> /*
> - * The clock events are used for clock enable/disable and for
> - * clock rate change
> - */
> -DECLARE_EVENT_CLASS(clock,
> -
> - TP_PROTO(const char *name, unsigned int state, unsigned int
> cpu_id), -
> - TP_ARGS(name, state, cpu_id),
> -
> - TP_STRUCT__entry(
> - __string( name, name )
> - __field( u64, state )
> - __field( u64, cpu_id )
> - ),
> -
> - TP_fast_assign(
> - __assign_str(name, name);
> - __entry->state = state;
> - __entry->cpu_id = cpu_id;
> - ),
> -
> - TP_printk("%s state=%lu cpu_id=%lu", __get_str(name),
> - (unsigned long)__entry->state, (unsigned
> long)__entry->cpu_id) -);
> -
> -DEFINE_EVENT(clock, clock_enable,
> -
> - TP_PROTO(const char *name, unsigned int state, unsigned int
> cpu_id), -
> - TP_ARGS(name, state, cpu_id)
> -);
> -
> -DEFINE_EVENT(clock, clock_disable,
> -
> - TP_PROTO(const char *name, unsigned int state, unsigned int
> cpu_id), -
> - TP_ARGS(name, state, cpu_id)
> -);
> -
> -DEFINE_EVENT(clock, clock_set_rate,
> -
> - TP_PROTO(const char *name, unsigned int state, unsigned int
> cpu_id), -
> - TP_ARGS(name, state, cpu_id)
> -);
> -
> -/*
> * The power domain events are used for power domains transitions
> */
> DECLARE_EVENT_CLASS(power_domain,
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] tracing: Remove unused clock events
2017-10-13 7:20 ` Jean Pihet
@ 2017-10-13 14:25 ` Steven Rostedt
0 siblings, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2017-10-13 14:25 UTC (permalink / raw)
To: Jean Pihet
Cc: LKML, discuss, Linux PM list, Thomas Renninger, Arjan van de Ven,
Peter Zijlstra, Len Brown, Kevin Hilman, Ingo Molnar
On Fri, 13 Oct 2017 09:20:44 +0200
Jean Pihet <jean.pihet@newoldbits.com> wrote:
> Hi Steven,
>
> On Thu, Oct 12, 2017 at 6:44 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > [ Resending again, including linux-pm@vger.kernel.org this time ]
> >
> > From: Steven Rostedt (VMware) <rostedt@goodmis.org>
> >
> > Commit 74704ac6 ("tracing, perf: Add more power related events") added
> > new events, among them were trace_clock_enable, trace_clock_disable and
> > trace_clock_set_rate. In the last 7 years, nothing has used them. As
> > they take up space, and nobody cares about these events, remove them.
>
> Ok if it is not used. Can others confirm?
>
> AFAIK this has been used internally.
If it has been used internally, then the events should be defined
internally. The trace event hooks are not there, there's no reason to
define events were hooks are not present. There's no advantage for
keeping them in the kernel proper.
-- Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-10-13 14:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-10 15:21 [PATCH] tracing: Remove unused clock events Steven Rostedt
2017-10-12 16:44 Steven Rostedt
2017-10-13 7:20 ` Jean Pihet
2017-10-13 14:25 ` Steven Rostedt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.