From: Anthony PERARD <anthony.perard@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: qemu-devel@nongnu.org, Ross Lagerwall <ross.lagerwall@citrix.com>,
Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
xen-devel@lists.xenproject.org
Subject: Re: [Qemu-devel] [PATCH 2/8] xen: restrict: use xentoolcore_restrict_all
Date: Tue, 10 Oct 2017 12:26:56 +0100 [thread overview]
Message-ID: <20171010112656.GE1771@perard.uk.xensource.com> (raw)
In-Reply-To: <1507564902-9000-3-git-send-email-ian.jackson@eu.citrix.com>
On Mon, Oct 09, 2017 at 05:01:36PM +0100, Ian Jackson wrote:
> And insist that it works.
>
> Drop individual use of xendevicemodel_restrict and
> xenforeignmemory_restrict. These are not actually effective in this
> version of qemu, because qemu has a large number of fds open onto
> various Xen control devices.
>
> The restriction arrangements are still not right, because the
> restriction needs to be done very late - after qemu has opened all of
> its control fds.
>
> xentoolcore_restrict_all and xentoolcore.h are available in Xen 4.10
> and later, only. Provide a compatibility stub. And drop the
> compatibility stubs for the old functions.
>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
--
Anthony PERARD
WARNING: multiple messages have this Message-ID (diff)
From: Anthony PERARD <anthony.perard@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Juergen Gross <jgross@suse.com>,
Ross Lagerwall <ross.lagerwall@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
qemu-devel@nongnu.org, xen-devel@lists.xenproject.org
Subject: Re: [PATCH 2/8] xen: restrict: use xentoolcore_restrict_all
Date: Tue, 10 Oct 2017 12:26:56 +0100 [thread overview]
Message-ID: <20171010112656.GE1771@perard.uk.xensource.com> (raw)
In-Reply-To: <1507564902-9000-3-git-send-email-ian.jackson@eu.citrix.com>
On Mon, Oct 09, 2017 at 05:01:36PM +0100, Ian Jackson wrote:
> And insist that it works.
>
> Drop individual use of xendevicemodel_restrict and
> xenforeignmemory_restrict. These are not actually effective in this
> version of qemu, because qemu has a large number of fds open onto
> various Xen control devices.
>
> The restriction arrangements are still not right, because the
> restriction needs to be done very late - after qemu has opened all of
> its control fds.
>
> xentoolcore_restrict_all and xentoolcore.h are available in Xen 4.10
> and later, only. Provide a compatibility stub. And drop the
> compatibility stubs for the old functions.
>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
--
Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-10-10 18:26 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 16:01 [Qemu-devel] [PATCH v4 0/8] xen: xen-domid-restrict improvements Ian Jackson
2017-10-09 16:01 ` Ian Jackson
2017-10-09 16:01 ` [Qemu-devel] [PATCH 1/8] xen: link against xentoolcore Ian Jackson
2017-10-09 16:01 ` Ian Jackson
2017-10-09 16:28 ` [Qemu-devel] " Ian Jackson
2017-10-09 16:28 ` Ian Jackson
2017-10-10 10:32 ` [Qemu-devel] " Anthony PERARD
2017-10-10 10:32 ` Anthony PERARD
2017-10-10 17:13 ` [Qemu-devel] " Ian Jackson
2017-10-10 17:13 ` Ian Jackson
2017-10-19 16:38 ` [Qemu-devel] " Ian Jackson
2017-10-19 16:38 ` Ian Jackson
2017-10-19 16:47 ` [Qemu-devel] " Anthony PERARD
2017-10-19 16:47 ` Anthony PERARD
2017-10-20 10:25 ` [Qemu-devel] " Ian Jackson
2017-10-20 10:25 ` Ian Jackson
2017-10-09 16:01 ` [Qemu-devel] [PATCH 2/8] xen: restrict: use xentoolcore_restrict_all Ian Jackson
2017-10-09 16:01 ` Ian Jackson
2017-10-10 11:26 ` Anthony PERARD [this message]
2017-10-10 11:26 ` Anthony PERARD
2017-10-09 16:01 ` [Qemu-devel] [PATCH 3/8] xen: defer call to xen_restrict until just before os_setup_post Ian Jackson
2017-10-09 16:01 ` Ian Jackson
2017-10-10 11:48 ` [Qemu-devel] " Anthony PERARD
2017-10-10 11:48 ` Anthony PERARD
2017-10-13 8:37 ` [Qemu-devel] " Ross Lagerwall
2017-10-13 8:37 ` Ross Lagerwall
2017-10-13 8:59 ` [Qemu-devel] [Xen-devel] " Andrew Cooper
2017-10-13 8:59 ` Andrew Cooper
2017-10-13 9:06 ` [Qemu-devel] [Xen-devel] " Paul Durrant
2017-10-13 9:06 ` Paul Durrant
2017-10-13 10:43 ` [Qemu-devel] " Ian Jackson
2017-10-13 10:43 ` Ian Jackson
2017-10-09 16:01 ` [Qemu-devel] [PATCH 4/8] xen: destroy_hvm_domain: Move reason into a variable Ian Jackson
2017-10-09 16:01 ` Ian Jackson
2017-10-09 16:01 ` [Qemu-devel] [PATCH 5/8] xen: move xc_interface compatibility fallback further up the file Ian Jackson
2017-10-09 16:01 ` Ian Jackson
2017-10-10 11:48 ` [Qemu-devel] " Anthony PERARD
2017-10-10 11:48 ` Anthony PERARD
2017-10-09 16:01 ` [Qemu-devel] [PATCH 6/8] xen: destroy_hvm_domain: Try xendevicemodel_shutdown Ian Jackson
2017-10-09 16:01 ` Ian Jackson
2017-10-10 11:55 ` [Qemu-devel] " Anthony PERARD
2017-10-10 11:55 ` Anthony PERARD
2017-10-09 16:01 ` [Qemu-devel] [PATCH 7/8] os-posix: Provide new -runas <uid>.<gid> facility Ian Jackson
2017-10-09 16:01 ` Ian Jackson
2017-10-09 16:01 ` [Qemu-devel] [PATCH 8/8] configure: do_compiler: Dump some extra info under bash Ian Jackson
2017-10-09 16:01 ` Ian Jackson
2017-10-09 18:53 ` [Qemu-devel] [PATCH v4 0/8] xen: xen-domid-restrict improvements no-reply
2017-10-09 18:53 ` no-reply
-- strict thread matches above, loose matches on Subject: below --
2017-10-19 16:51 [Qemu-devel] [PATCH v5 " Ian Jackson
2017-10-19 16:51 ` [Qemu-devel] [PATCH 2/8] xen: restrict: use xentoolcore_restrict_all Ian Jackson
2017-10-06 18:27 [Qemu-devel] [PATCH v3 0/8] xen: xen-domid-restrict improvements Ian Jackson
2017-10-06 18:27 ` [Qemu-devel] [PATCH 2/8] xen: restrict: use xentoolcore_restrict_all Ian Jackson
2017-10-04 16:18 [Qemu-devel] [PATCH v2 0/*] xen: xen-domid-restrict improvements Ian Jackson
2017-10-04 16:18 ` [Qemu-devel] [PATCH 2/8] xen: restrict: use xentoolcore_restrict_all Ian Jackson
2017-10-04 15:53 [Qemu-devel] [PATCH v2 0/7] xen: xen-domid-restrict improvements Ian Jackson
2017-10-04 15:53 ` [Qemu-devel] [PATCH 2/8] xen: restrict: use xentoolcore_restrict_all Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010112656.GE1771@perard.uk.xensource.com \
--to=anthony.perard@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=qemu-devel@nongnu.org \
--cc=ross.lagerwall@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.