[PATCH] cmake: fix typo in toolchain file

[PATCH] cmake: fix typo in toolchain file

[Øystein Walle]

From: Øystein Walle <ow@datarespons.no>

Signed-off-by: Øystein Walle <ow@datarespons.no>
---
 meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake b/meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake
index 6518408c70..dc8477ea34 100644
--- a/meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake
+++ b/meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake
@@ -1,7 +1,7 @@
 set( CMAKE_SYSTEM_NAME Linux )
 set( CMAKE_C_FLAGS $ENV{CFLAGS} CACHE STRING "" FORCE )
 set( CMAKE_CXX_FLAGS $ENV{CXXFLAGS}  CACHE STRING "" FORCE )
-set( CMAKE ASM_FLAGS ${CMAKE_C_FLAGS} CACHE STRING "" FORCE )
+set( CMAKE_ASM_FLAGS ${CMAKE_C_FLAGS} CACHE STRING "" FORCE )
 set( CMAKE_LDFLAGS_FLAGS ${CMAKE_CXX_FLAGS} CACHE STRING "" FORCE )
 
 set( CMAKE_FIND_ROOT_PATH $ENV{OECORE_TARGET_SYSROOT} $ENV{OECORE_NATIVE_SYSROOT} )
-- 
2.14.2

Re: [PATCH] cmake: fix typo in toolchain file

[Alexander Kanavin]

On 10/10/2017 03:00 PM, Øystein Walle wrote:

> -set( CMAKE ASM_FLAGS ${CMAKE_C_FLAGS} CACHE STRING "" FORCE )
> +set( CMAKE_ASM_FLAGS ${CMAKE_C_FLAGS} CACHE STRING "" FORCE )

Where is the typo and what is it, exactly?

Alex

Re: [PATCH] cmake: fix typo in toolchain file

[Maciej Borzęcki]

On Tue, Oct 10, 2017 at 2:25 PM, Alexander Kanavin
<alexander.kanavin@linux.intel.com> wrote:
> On 10/10/2017 03:00 PM, Øystein Walle wrote:
>
>> -set( CMAKE ASM_FLAGS ${CMAKE_C_FLAGS} CACHE STRING "" FORCE )
>> +set( CMAKE_ASM_FLAGS ${CMAKE_C_FLAGS} CACHE STRING "" FORCE )
>
>
> Where is the typo and what is it, exactly?

-set( CMAKE ASM_FLAGS ${CMAKE_C_FLAGS} CACHE STRING "" FORCE )

missing _ between CMAKE and ASM


-- 
Maciej Borzecki
RnDity

Re: [PATCH] cmake: fix typo in toolchain file

[Alexander Kanavin]

On 10/10/2017 03:38 PM, Øystein Walle wrote:

> I can resend the patch with a better commit message if you like.

Yes please.

Alex

Re: [PATCH] cmake: fix typo in toolchain file

[Øystein Walle]

On 10 October 2017 at 14:31, Maciej Borzęcki <maciej.borzecki@rndity.com> wrote:
> On Tue, Oct 10, 2017 at 2:25 PM, Alexander Kanavin
>
>> Where is the typo and what is it, exactly?
>
> -set( CMAKE ASM_FLAGS ${CMAKE_C_FLAGS} CACHE STRING "" FORCE )
>
> missing _ between CMAKE and ASM

Correct. As it is the code defines a variable named "CMAKE" with the
contents "ASM_FLAGS ${CMAKE_C_FLAGS}". As far as CMake is concerned that
is valid and so this will not generate any form of error, but may
result in incorrect flags.

I can resend the patch with a better commit message if you like.

--
Øsse

Re: [PATCH] cmake: fix typo in toolchain file

[Philip Balister]

On 10/10/2017 05:38 AM, Øystein Walle wrote:
> On 10 October 2017 at 14:31, Maciej Borzęcki <maciej.borzecki@rndity.com> wrote:
>> On Tue, Oct 10, 2017 at 2:25 PM, Alexander Kanavin
>>
>>> Where is the typo and what is it, exactly?
>>
>> -set( CMAKE ASM_FLAGS ${CMAKE_C_FLAGS} CACHE STRING "" FORCE )
>>
>> missing _ between CMAKE and ASM
> 
> Correct. As it is the code defines a variable named "CMAKE" with the
> contents "ASM_FLAGS ${CMAKE_C_FLAGS}". As far as CMake is concerned that
> is valid and so this will not generate any form of error, but may
> result in incorrect flags.
> 
> I can resend the patch with a better commit message if you like.

That would be nice. I stared at the line for a bit trying to see the
typo also.

Philip


> 
> --
> Øsse
> 

[PATCH v2] cmake: fix typo in toolchain file

[Øystein Walle]

From: Øystein Walle <ow@datarespons.no>

The missing underscore makes CMake define a new variable named "CMAKE"
with the contents "ASM_FLAGS ${CMAKE_C_FLAGS}" instead of a variable
named "CMAKE_ASM_FLAGS" with contents equal to "CMAKE_C_FLAGS". It seems
clear that the intention was to assign "CMAKE_ASM_FLAGS".

CMake uses variables named "CMAKE_<LANG>_FLAGS" for defining default
compiler flags for a given language <LANG>. Leaving this flag unset may
have unintended consequences. Not doing so is however not an error as
far as CMake is concerned so it is silently accepted.

Signed-off-by: Øystein Walle <ow@datarespons.no>
---
 meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake b/meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake
index 6518408c70..dc8477ea34 100644
--- a/meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake
+++ b/meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake
@@ -1,7 +1,7 @@
 set( CMAKE_SYSTEM_NAME Linux )
 set( CMAKE_C_FLAGS $ENV{CFLAGS} CACHE STRING "" FORCE )
 set( CMAKE_CXX_FLAGS $ENV{CXXFLAGS}  CACHE STRING "" FORCE )
-set( CMAKE ASM_FLAGS ${CMAKE_C_FLAGS} CACHE STRING "" FORCE )
+set( CMAKE_ASM_FLAGS ${CMAKE_C_FLAGS} CACHE STRING "" FORCE )
 set( CMAKE_LDFLAGS_FLAGS ${CMAKE_CXX_FLAGS} CACHE STRING "" FORCE )
 
 set( CMAKE_FIND_ROOT_PATH $ENV{OECORE_TARGET_SYSROOT} $ENV{OECORE_NATIVE_SYSROOT} )
-- 
2.14.2