Re: [Qemu-devel] [PATCH] ui/gtk: Fix deprecation of vte_terminal_copy_clipboard

From: "Daniel P. Berrange" <berrange@redhat.com>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] ui/gtk: Fix deprecation of vte_terminal_copy_clipboard
Date: Tue, 10 Oct 2017 15:43:37 +0100	[thread overview]
Message-ID: <20171010144337.GG30015@redhat.com> (raw)
In-Reply-To: <20171010102418.13487-1-anthony.perard@citrix.com>

On Tue, Oct 10, 2017 at 11:24:18AM +0100, Anthony PERARD wrote:
> vte_terminal_copy_clipboard() is deprecated in VTE 0.50.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
>  ui/gtk.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/ui/gtk.c b/ui/gtk.c
> index 5bd87c265a..342e96fbe9 100644
> --- a/ui/gtk.c
> +++ b/ui/gtk.c
> @@ -1702,7 +1702,12 @@ static void gd_menu_copy(GtkMenuItem *item, void *opaque)
>      GtkDisplayState *s = opaque;
>      VirtualConsole *vc = gd_vc_find_current(s);
>  
> +#if VTE_CHECK_VERSION(0, 50, 0)
> +    vte_terminal_copy_clipboard_format(VTE_TERMINAL(vc->vte.terminal),
> +                                       VTE_FORMAT_TEXT);
> +#else
>      vte_terminal_copy_clipboard(VTE_TERMINAL(vc->vte.terminal));
> +#endif
>  }
>  
>  static void gd_vc_adjustment_changed(GtkAdjustment *adjustment, void *opaque)

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|