[Qemu-devel] ‘vte_terminal_copy_clipboard’ is deprecated

[Qemu-devel] ‘vte_terminal_copy_clipboard’ is deprecated

[Anthony PERARD]

Hi,

Looks like vte_terminal_copy_clipboard() is been deprecated:

  CC      ui/gtk.o
ui/gtk.c: In function ‘gd_menu_copy’
ui/gtk.c:1705:5: error: ‘vte_terminal_copy_clipboard’ is deprecated [-Werror=deprecated-declarations]
     vte_terminal_copy_clipboard(VTE_TERMINAL(vc->vte.terminal));
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/vte-2.91/vte/vte.h:35:0,
                 from ui/gtk.c:47:
/usr/include/vte-2.91/vte/vtedeprecated.h:94:6: note: declared here
 void vte_terminal_copy_clipboard(VteTerminal *terminal) _VTE_GNUC_NONNULL(1);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make: *** [/local/home/sheep/work/qemu/rules.mak:66: ui/gtk.o] Error 1


Package version:

$ pacman -Qo /usr/include/vte-2.91/vte/vte.h
/usr/include/vte-2.91/vte/vte.h is owned by vte3 0.50.1-1

Regards,

-- 
Anthony PERARD

Re: [Qemu-devel] ‘vte_terminal_copy_clipboard’ is deprecated

[Daniel P. Berrange]

On Mon, Oct 09, 2017 at 03:55:42PM +0100, Anthony PERARD wrote:
> Hi,
> 
> Looks like vte_terminal_copy_clipboard() is been deprecated:
> 
>   CC      ui/gtk.o
> ui/gtk.c: In function ‘gd_menu_copy’
> ui/gtk.c:1705:5: error: ‘vte_terminal_copy_clipboard’ is deprecated [-Werror=deprecated-declarations]
>      vte_terminal_copy_clipboard(VTE_TERMINAL(vc->vte.terminal));
>      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from /usr/include/vte-2.91/vte/vte.h:35:0,
>                  from ui/gtk.c:47:
> /usr/include/vte-2.91/vte/vtedeprecated.h:94:6: note: declared here
>  void vte_terminal_copy_clipboard(VteTerminal *terminal) _VTE_GNUC_NONNULL(1);
>       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make: *** [/local/home/sheep/work/qemu/rules.mak:66: ui/gtk.o] Error 1

The docs say it should be simply replaced with a call to
vte_terminal_copy_clipboard_format, using VTE_FORMAT_TEXT
as the format.

So we just need to make either the old or new method call
conditional on VTE version >= 0.50.0

Since you've got the new vte installed to test with, do you
want to write a patch for that :-)

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [Qemu-devel] ‘vte_terminal_copy_clipboard’ is deprecated

[Anthony PERARD]

On Mon, Oct 09, 2017 at 04:02:31PM +0100, Daniel P. Berrange wrote:
> On Mon, Oct 09, 2017 at 03:55:42PM +0100, Anthony PERARD wrote:
> > Hi,
> > 
> > Looks like vte_terminal_copy_clipboard() is been deprecated:
> > 
> >   CC      ui/gtk.o
> > ui/gtk.c: In function ‘gd_menu_copy’
> > ui/gtk.c:1705:5: error: ‘vte_terminal_copy_clipboard’ is deprecated [-Werror=deprecated-declarations]
> >      vte_terminal_copy_clipboard(VTE_TERMINAL(vc->vte.terminal));
> >      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> > In file included from /usr/include/vte-2.91/vte/vte.h:35:0,
> >                  from ui/gtk.c:47:
> > /usr/include/vte-2.91/vte/vtedeprecated.h:94:6: note: declared here
> >  void vte_terminal_copy_clipboard(VteTerminal *terminal) _VTE_GNUC_NONNULL(1);
> >       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
> > make: *** [/local/home/sheep/work/qemu/rules.mak:66: ui/gtk.o] Error 1
> 
> The docs say it should be simply replaced with a call to
> vte_terminal_copy_clipboard_format, using VTE_FORMAT_TEXT
> as the format.
> 
> So we just need to make either the old or new method call
> conditional on VTE version >= 0.50.0
> 
> Since you've got the new vte installed to test with, do you
> want to write a patch for that :-)

I was lazy, but yes, I can write the patch. Thanks for reading the doc
:).

-- 
Anthony PERARD

[Qemu-devel] [PATCH] ui/gtk: Fix deprecation of vte_terminal_copy_clipboard

[Anthony PERARD]

vte_terminal_copy_clipboard() is deprecated in VTE 0.50.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
 ui/gtk.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/ui/gtk.c b/ui/gtk.c
index 5bd87c265a..342e96fbe9 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -1702,7 +1702,12 @@ static void gd_menu_copy(GtkMenuItem *item, void *opaque)
     GtkDisplayState *s = opaque;
     VirtualConsole *vc = gd_vc_find_current(s);
 
+#if VTE_CHECK_VERSION(0, 50, 0)
+    vte_terminal_copy_clipboard_format(VTE_TERMINAL(vc->vte.terminal),
+                                       VTE_FORMAT_TEXT);
+#else
     vte_terminal_copy_clipboard(VTE_TERMINAL(vc->vte.terminal));
+#endif
 }
 
 static void gd_vc_adjustment_changed(GtkAdjustment *adjustment, void *opaque)
-- 
Anthony PERARD

Re: [Qemu-devel] [PATCH] ui/gtk: Fix deprecation of vte_terminal_copy_clipboard

[Daniel P. Berrange]

On Tue, Oct 10, 2017 at 11:24:18AM +0100, Anthony PERARD wrote:
> vte_terminal_copy_clipboard() is deprecated in VTE 0.50.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
>  ui/gtk.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/ui/gtk.c b/ui/gtk.c
> index 5bd87c265a..342e96fbe9 100644
> --- a/ui/gtk.c
> +++ b/ui/gtk.c
> @@ -1702,7 +1702,12 @@ static void gd_menu_copy(GtkMenuItem *item, void *opaque)
>      GtkDisplayState *s = opaque;
>      VirtualConsole *vc = gd_vc_find_current(s);
>  
> +#if VTE_CHECK_VERSION(0, 50, 0)
> +    vte_terminal_copy_clipboard_format(VTE_TERMINAL(vc->vte.terminal),
> +                                       VTE_FORMAT_TEXT);
> +#else
>      vte_terminal_copy_clipboard(VTE_TERMINAL(vc->vte.terminal));
> +#endif
>  }
>  
>  static void gd_vc_adjustment_changed(GtkAdjustment *adjustment, void *opaque)

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|