From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: David Howells <dhowells@redhat.com>,
linux-kernel@vger.kernel.org, mingo@kernel.org,
torvalds@linux-foundation.org, mark.rutland@arm.com,
linux-arch@vger.kernel.org, will.deacon@arm.com,
Jonathan Corbet <corbet@lwn.net>,
Alexander Kuleshov <kuleshovmail@gmail.com>
Subject: Re: [PATCH RFC tip/core/rcu 12/15] lib/assoc_array: Remove smp_read_barrier_depends()
Date: Tue, 10 Oct 2017 09:05:23 -0700 [thread overview]
Message-ID: <20171010160523.GH3521@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171010155451.wv2dfirmra5aeake@hirez.programming.kicks-ass.net>
On Tue, Oct 10, 2017 at 05:54:51PM +0200, Peter Zijlstra wrote:
> On Tue, Oct 10, 2017 at 08:50:42AM -0700, Paul E. McKenney wrote:
> > + /* We need a barrier between the read of the pointer,
> > + * which is supplied by the above READ_ONCE().
> > */
>
> > /* We need a barrier between the read of the pointer
> > * and dereferencing the pointer - but only if we are
> > * actually going to dereference it.
> > */
>
> Could you also fix those "disgusting drug-induced crap" comment styles
> while you're there anyway?
>
> http://lkml.iu.edu/hypermail/linux/kernel/1607.1/00627.html
If Dave is OK with it, I will do so on my next pass.
Thanx, Paul
next prev parent reply other threads:[~2017-10-10 16:05 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 0:19 [PATCH RFC tip/core/rcu 0/15] Remove to-be-unneeded smp_read_barrier_depends() Paul E. McKenney
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 01/15] doc: READ_ONCE() now implies smp_barrier_depends() Paul E. McKenney
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 02/15] mn10300: READ_ONCE() now implies smp_read_barrier_depends() Paul E. McKenney
2017-10-10 0:22 ` Paul E. McKenney
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 03/15] drivers/net/ethernet/qlogic/qed: Fix __qed_spq_block() ordering Paul E. McKenney
2017-10-10 0:22 ` Paul E. McKenney
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 04/15] fs/dcache: Use release-acquire for name/length update Paul E. McKenney
2017-10-10 0:22 ` Paul E. McKenney
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 05/15] percpu: READ_ONCE() now implies smp_read_barrier_depends() Paul E. McKenney
2017-10-10 14:08 ` Tejun Heo
2017-10-10 15:30 ` Paul E. McKenney
2017-10-10 15:49 ` Tejun Heo
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 06/15] rcu: Adjust read-side accessor comments for READ_ONCE() Paul E. McKenney
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 07/15] rtnetlink: Update now-misleading smp_read_barrier_depends() comment Paul E. McKenney
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 08/15] seqlock: Remove now-redundant smp_read_barrier_depends() Paul E. McKenney
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 09/15] uprobes: " Paul E. McKenney
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 10/15] locking: Remove smp_read_barrier_depends() from queued_spin_lock_slowpath() Paul E. McKenney
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 11/15] tracepoint: Remove smp_read_barrier_depends() from comment Paul E. McKenney
2017-10-10 0:31 ` Steven Rostedt
2017-10-10 1:12 ` Mathieu Desnoyers
2017-10-10 15:32 ` Paul E. McKenney
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 12/15] lib/assoc_array: Remove smp_read_barrier_depends() Paul E. McKenney
2017-10-10 8:39 ` Peter Zijlstra
2017-10-10 9:36 ` David Howells
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 13/15] mm/ksm: Remove now-redundant smp_read_barrier_depends() Paul E. McKenney
2017-10-10 0:22 ` Paul E. McKenney
2017-10-10 0:22 ` Paul E. McKenney
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 14/15] netfilter: " Paul E. McKenney
2017-10-10 0:22 ` Paul E. McKenney
2017-10-10 8:43 ` Peter Zijlstra
2017-10-10 15:56 ` Paul E. McKenney
2017-10-10 0:22 ` [PATCH RFC tip/core/rcu 15/15] keyring: " Paul E. McKenney
2017-10-10 0:22 ` Paul E. McKenney
2017-10-10 0:22 ` Paul E. McKenney
2017-10-10 0:22 ` Paul E. McKenney
2017-10-10 9:35 ` [PATCH RFC tip/core/rcu 12/15] lib/assoc_array: Remove smp_read_barrier_depends() David Howells
2017-10-10 15:50 ` Paul E. McKenney
2017-10-10 15:54 ` Peter Zijlstra
2017-10-10 16:05 ` Paul E. McKenney [this message]
2017-10-11 12:19 ` David Howells
2017-10-11 12:22 ` Will Deacon
2017-10-11 12:54 ` Paul E. McKenney
2017-10-11 14:18 ` Will Deacon
2017-10-11 14:50 ` Paul E. McKenney
2017-10-11 12:58 ` Paul E. McKenney
2017-10-11 15:17 ` David Howells
2017-10-11 15:59 ` Paul E. McKenney
2017-10-11 16:12 ` Peter Zijlstra
2017-10-11 16:24 ` Peter Zijlstra
2017-10-11 16:47 ` Paul E. McKenney
2017-10-11 16:54 ` Peter Zijlstra
2017-10-11 17:06 ` Paul E. McKenney
2017-10-11 17:11 ` Peter Zijlstra
2017-10-11 17:34 ` Paul E. McKenney
2017-10-11 18:43 ` Dmitry Vyukov
2017-10-11 18:56 ` Linus Torvalds
2017-10-11 19:28 ` Paul E. McKenney
2017-10-11 19:59 ` Dmitry Vyukov
2017-10-11 17:14 ` Paul E. McKenney
2017-10-11 17:19 ` Mark Rutland
2017-10-11 16:50 ` Paul E. McKenney
2017-10-11 16:07 ` David Howells
2017-10-11 16:17 ` Peter Zijlstra
2017-10-11 16:19 ` Paul E. McKenney
2017-10-11 15:28 ` David Howells
2017-10-11 16:02 ` Paul E. McKenney
2017-10-10 9:59 ` David Howells
2017-10-10 15:52 ` Paul E. McKenney
2017-10-11 12:21 ` [PATCH RFC tip/core/rcu 0/15] Remove to-be-unneeded smp_read_barrier_depends() David Howells
2017-10-11 12:56 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010160523.GH3521@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=corbet@lwn.net \
--cc=dhowells@redhat.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.