All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, Andy Gross <andy.gross@linaro.org>,
	David Brown <david.brown@linaro.org>,
	Stephen Boyd <sboyd@codeaurora.org>,
	linux-soc@vger.kernel.org
Subject: Re: [PATCH v2] arm64: qcom: sbc: Name GPIO lines
Date: Tue, 10 Oct 2017 22:54:05 -0700	[thread overview]
Message-ID: <20171011055405.GI1165@minitux> (raw)
In-Reply-To: <20171009092844.11451-1-linus.walleij@linaro.org>

On Mon 09 Oct 02:28 PDT 2017, Linus Walleij wrote:

> This names the GPIO lines on the APQ8016 "SBC" also known
> as the DragonBoard 410c, according to the schematic. This
> is necessary for a conforming userspace looking across
> all GPIO chips for the GPIO lines named "GPIO-A" thru
> "GPIO-L".
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v1->v2:
> - Put the GPIO line names into the .dtsi file for the
>   SBC as requested.
> - Put the GPIO line names into the hierarchical SoC
>   DTS structure as requested.
> - Adjusted legend text to only cover used terminology.
> - Insert proper comments telling which line on the LSEC
>   or HSEC a certain line is routed to.
> 
> I don't have this hardware available, you can test it
> easily by compiling tools/gpio/* and issue "lsgpio" to
> see the GPIO line names in the console.
> ---
>  arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 169 ++++++++++++++++++++++++++++++
>  1 file changed, 169 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
[..]
> +				"NC", /* GPIO 70 */
> +				"NC",
> +				"NC",
> +				"NC",
> +				"NC", /* GPIO 74 */

Convenient to know where index 74 is ;P

> +				"NC",
> +				"NC",
> +				"NC",
> +				"NC",
> +				"NC",
> +				"BOOT_CONFIG_0", /* GPIO 80 */

Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

WARNING: multiple messages have this Message-ID (diff)
From: bjorn.andersson@linaro.org (Bjorn Andersson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm64: qcom: sbc: Name GPIO lines
Date: Tue, 10 Oct 2017 22:54:05 -0700	[thread overview]
Message-ID: <20171011055405.GI1165@minitux> (raw)
In-Reply-To: <20171009092844.11451-1-linus.walleij@linaro.org>

On Mon 09 Oct 02:28 PDT 2017, Linus Walleij wrote:

> This names the GPIO lines on the APQ8016 "SBC" also known
> as the DragonBoard 410c, according to the schematic. This
> is necessary for a conforming userspace looking across
> all GPIO chips for the GPIO lines named "GPIO-A" thru
> "GPIO-L".
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ChangeLog v1->v2:
> - Put the GPIO line names into the .dtsi file for the
>   SBC as requested.
> - Put the GPIO line names into the hierarchical SoC
>   DTS structure as requested.
> - Adjusted legend text to only cover used terminology.
> - Insert proper comments telling which line on the LSEC
>   or HSEC a certain line is routed to.
> 
> I don't have this hardware available, you can test it
> easily by compiling tools/gpio/* and issue "lsgpio" to
> see the GPIO line names in the console.
> ---
>  arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 169 ++++++++++++++++++++++++++++++
>  1 file changed, 169 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
[..]
> +				"NC", /* GPIO 70 */
> +				"NC",
> +				"NC",
> +				"NC",
> +				"NC", /* GPIO 74 */

Convenient to know where index 74 is ;P

> +				"NC",
> +				"NC",
> +				"NC",
> +				"NC",
> +				"NC",
> +				"BOOT_CONFIG_0", /* GPIO 80 */

Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

  reply	other threads:[~2017-10-11  5:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-09  9:28 [PATCH v2] arm64: qcom: sbc: Name GPIO lines Linus Walleij
2017-10-09  9:28 ` Linus Walleij
2017-10-11  5:54 ` Bjorn Andersson [this message]
2017-10-11  5:54   ` Bjorn Andersson
2017-10-11  6:30   ` Linus Walleij
2017-10-11  6:30     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171011055405.GI1165@minitux \
    --to=bjorn.andersson@linaro.org \
    --cc=andy.gross@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.