All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mwifiex: Random MAC address during scanning
@ 2017-09-29 10:53 Ganapathi Bhat
  2017-10-10  8:21 ` Kalle Valo
  2017-10-11 19:41 ` [PATCH] " Brian Norris
  0 siblings, 2 replies; 6+ messages in thread
From: Ganapathi Bhat @ 2017-09-29 10:53 UTC (permalink / raw)
  To: linux-wireless
  Cc: Brian Norris, Cathy Luo, Xinming Hu, Zhiyuan Yang, James Cao,
	Mangesh Malusare, Karthik Ananthapadmanabha, Ganapathi Bhat

From: Karthik Ananthapadmanabha <karthida@marvell.com>

Driver will advertise RANDOM_MAC support only if the device
supports this feature.

Signed-off-by: Karthik Ananthapadmanabha <karthida@marvell.com>
Signed-off-by: Ganapathi Bhat <gbhat@marvell.com>
---
 drivers/net/wireless/marvell/mwifiex/cfg80211.c | 10 ++++++----
 drivers/net/wireless/marvell/mwifiex/fw.h       |  1 +
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
index 32c5074..f22f7b8 100644
--- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
+++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
@@ -4306,10 +4306,12 @@ int mwifiex_register_cfg80211(struct mwifiex_adapter *adapter)
 	wiphy->features |= NL80211_FEATURE_HT_IBSS |
 			   NL80211_FEATURE_INACTIVITY_TIMER |
 			   NL80211_FEATURE_LOW_PRIORITY_SCAN |
-			   NL80211_FEATURE_NEED_OBSS_SCAN |
-			   NL80211_FEATURE_SCAN_RANDOM_MAC_ADDR |
-			   NL80211_FEATURE_SCHED_SCAN_RANDOM_MAC_ADDR |
-			   NL80211_FEATURE_ND_RANDOM_MAC_ADDR;
+			   NL80211_FEATURE_NEED_OBSS_SCAN;
+
+	if (ISSUPP_RANDOM_MAC(adapter->fw_cap_info))
+		wiphy->features |= NL80211_FEATURE_SCAN_RANDOM_MAC_ADDR |
+				   NL80211_FEATURE_SCHED_SCAN_RANDOM_MAC_ADDR |
+				   NL80211_FEATURE_ND_RANDOM_MAC_ADDR;
 
 	if (ISSUPP_TDLS_ENABLED(adapter->fw_cap_info))
 		wiphy->features |= NL80211_FEATURE_TDLS_CHANNEL_SWITCH;
diff --git a/drivers/net/wireless/marvell/mwifiex/fw.h b/drivers/net/wireless/marvell/mwifiex/fw.h
index 9e75522..6b765f3 100644
--- a/drivers/net/wireless/marvell/mwifiex/fw.h
+++ b/drivers/net/wireless/marvell/mwifiex/fw.h
@@ -238,6 +238,7 @@ enum MWIFIEX_802_11_PRIVACY_FILTER {
 #define ISSUPP_DRCS_ENABLED(FwCapInfo) (FwCapInfo & BIT(15))
 #define ISSUPP_SDIO_SPA_ENABLED(FwCapInfo) (FwCapInfo & BIT(16))
 #define ISSUPP_ADHOC_ENABLED(FwCapInfo) (FwCapInfo & BIT(25))
+#define ISSUPP_RANDOM_MAC(FwCapInfo) (FwCapInfo & BIT(27))
 
 #define MWIFIEX_DEF_HT_CAP	(IEEE80211_HT_CAP_DSSSCCK40 | \
 				 (1 << IEEE80211_HT_CAP_RX_STBC_SHIFT) | \
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: mwifiex: Random MAC address during scanning
  2017-09-29 10:53 [PATCH] mwifiex: Random MAC address during scanning Ganapathi Bhat
@ 2017-10-10  8:21 ` Kalle Valo
  2017-10-11 19:41 ` [PATCH] " Brian Norris
  1 sibling, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2017-10-10  8:21 UTC (permalink / raw)
  To: Ganapathi Bhat
  Cc: linux-wireless, Brian Norris, Cathy Luo, Xinming Hu,
	Zhiyuan Yang, James Cao, Mangesh Malusare,
	Karthik Ananthapadmanabha, Ganapathi Bhat

Ganapathi Bhat <gbhat@marvell.com> wrote:

> From: Karthik Ananthapadmanabha <karthida@marvell.com>
> 
> Driver will advertise RANDOM_MAC support only if the device
> supports this feature.
> 
> Signed-off-by: Karthik Ananthapadmanabha <karthida@marvell.com>
> Signed-off-by: Ganapathi Bhat <gbhat@marvell.com>

Patch applied to wireless-drivers-next.git, thanks.

073a435d55a6 mwifiex: Random MAC address during scanning

-- 
https://patchwork.kernel.org/patch/9977525/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] mwifiex: Random MAC address during scanning
  2017-09-29 10:53 [PATCH] mwifiex: Random MAC address during scanning Ganapathi Bhat
  2017-10-10  8:21 ` Kalle Valo
@ 2017-10-11 19:41 ` Brian Norris
  2017-10-12  5:27   ` [EXT] " Ganapathi Bhat
  2017-10-12  5:53   ` Ganapathi Bhat
  1 sibling, 2 replies; 6+ messages in thread
From: Brian Norris @ 2017-10-11 19:41 UTC (permalink / raw)
  To: Ganapathi Bhat
  Cc: linux-wireless, Cathy Luo, Xinming Hu, Zhiyuan Yang, James Cao,
	Mangesh Malusare, Karthik Ananthapadmanabha

On Fri, Sep 29, 2017 at 04:23:10PM +0530, Ganapathi Bhat wrote:
> From: Karthik Ananthapadmanabha <karthida@marvell.com>
> 
> Driver will advertise RANDOM_MAC support only if the device
> supports this feature.
> 
> Signed-off-by: Karthik Ananthapadmanabha <karthida@marvell.com>
> Signed-off-by: Ganapathi Bhat <gbhat@marvell.com>

I'd just like to point out that this is a very bad commit subject:

"[PATCH] mwifiex: Random MAC address during scanning"

It's borderline wrong, really. "Random MAC address during scanning" is
already supported. This patch is just adding a feature-flag check for
it, since some firmwares in the wild don't support it. A more accurate
description would be something like:

"[PATCH] mwifiex: Add feature flag support for MAC randomization"

The patch is already applied, so I'd only worry about it for future
submissions (no need to resend).

Brian

^ permalink raw reply	[flat|nested] 6+ messages in thread
* RE: [EXT] Re: [PATCH] mwifiex: Random MAC address during scanning
  2017-10-11 19:41 ` [PATCH] " Brian Norris
@ 2017-10-12  5:27   ` Ganapathi Bhat
  2017-10-12  5:53   ` Ganapathi Bhat
  1 sibling, 0 replies; 6+ messages in thread
From: Ganapathi Bhat @ 2017-10-12  5:27 UTC (permalink / raw)
  To: Brian Norris
  Cc: linux-wireless, Cathy Luo, Xinming Hu, Zhiyuan Yang, James Cao,
	Mangesh Malusare, Karthik Doddayennegere Ananthapadmanabha

Hi Brian,

> ----------------------------------------------------------------------
> On Fri, Sep 29, 2017 at 04:23:10PM +0530, Ganapathi Bhat wrote:
> > From: Karthik Ananthapadmanabha <karthida@marvell.com>
> >
> > Driver will advertise RANDOM_MAC support only if the device supports
> > this feature.
> >
> > Signed-off-by: Karthik Ananthapadmanabha <karthida@marvell.com>
> > Signed-off-by: Ganapathi Bhat <gbhat@marvell.com>
>
> I'd just like to point out that this is a very bad commit subject:
>
> "[PATCH] mwifiex: Random MAC address during scanning"
>
> It's borderline wrong, really. "Random MAC address during scanning" is
> already supported. This patch is just adding a feature-flag check for it, since
> some firmwares in the wild don't support it. A more accurate description
> would be something like:
>
> "[PATCH] mwifiex: Add feature flag support for MAC randomization"
>
> The patch is already applied, so I'd only worry about it for future submissions
> (no need to resend).

I'm Really Sorry.  I will take care of this in future.

>
> Brian

^ permalink raw reply	[flat|nested] 6+ messages in thread
* RE: [EXT] Re: [PATCH] mwifiex: Random MAC address during scanning
  2017-10-11 19:41 ` [PATCH] " Brian Norris
  2017-10-12  5:27   ` [EXT] " Ganapathi Bhat
@ 2017-10-12  5:53   ` Ganapathi Bhat
  2017-10-12  7:59     ` Kalle Valo
  1 sibling, 1 reply; 6+ messages in thread
From: Ganapathi Bhat @ 2017-10-12  5:53 UTC (permalink / raw)
  To: Kalle Valo
  Cc: linux-wireless, Cathy Luo, Xinming Hu, Zhiyuan Yang, James Cao,
	Mangesh Malusare, Karthik Doddayennegere Ananthapadmanabha,
	Brian Norris

Hi Kalle,
>
> > ----------------------------------------------------------------------
> > On Fri, Sep 29, 2017 at 04:23:10PM +0530, Ganapathi Bhat wrote:
> > > From: Karthik Ananthapadmanabha <karthida@marvell.com>
> > >
> > > Driver will advertise RANDOM_MAC support only if the device supports
> > > this feature.
> > >
> > > Signed-off-by: Karthik Ananthapadmanabha <karthida@marvell.com>
> > > Signed-off-by: Ganapathi Bhat <gbhat@marvell.com>
> >
> > I'd just like to point out that this is a very bad commit subject:
> >
> > "[PATCH] mwifiex: Random MAC address during scanning"
> >
> > It's borderline wrong, really. "Random MAC address during scanning" is
> > already supported. This patch is just adding a feature-flag check for
> > it, since some firmwares in the wild don't support it. A more accurate
> > description would be something like:
> >
> > "[PATCH] mwifiex: Add feature flag support for MAC randomization"
> >
> > The patch is already applied, so I'd only worry about it for future
> > submissions (no need to resend).
>
> I'm Really Sorry.  I will take care of this in future.
>
The firmware which advertises this capability flag is yet to be shared in upstream. The latest available firmware does not contain this flag.
So, is it possible to revert this change, so that we will resubmit this (with proper subject) once our firmware is uploaded.
> >
> > Brian

Regards,
Ganapathi

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [EXT] Re: [PATCH] mwifiex: Random MAC address during scanning
  2017-10-12  5:53   ` Ganapathi Bhat
@ 2017-10-12  7:59     ` Kalle Valo
  0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2017-10-12  7:59 UTC (permalink / raw)
  To: Ganapathi Bhat
  Cc: linux-wireless, Cathy Luo, Xinming Hu, Zhiyuan Yang, James Cao,
	Mangesh Malusare, Karthik Doddayennegere Ananthapadmanabha,
	Brian Norris

Ganapathi Bhat <gbhat@marvell.com> writes:

> Hi Kalle,
>>
>> > ----------------------------------------------------------------------
>> > On Fri, Sep 29, 2017 at 04:23:10PM +0530, Ganapathi Bhat wrote:
>> > > From: Karthik Ananthapadmanabha <karthida@marvell.com>
>> > >
>> > > Driver will advertise RANDOM_MAC support only if the device supports
>> > > this feature.
>> > >
>> > > Signed-off-by: Karthik Ananthapadmanabha <karthida@marvell.com>
>> > > Signed-off-by: Ganapathi Bhat <gbhat@marvell.com>
>> >
>> > I'd just like to point out that this is a very bad commit subject:
>> >
>> > "[PATCH] mwifiex: Random MAC address during scanning"
>> >
>> > It's borderline wrong, really. "Random MAC address during scanning" is
>> > already supported. This patch is just adding a feature-flag check for
>> > it, since some firmwares in the wild don't support it. A more accurate
>> > description would be something like:
>> >
>> > "[PATCH] mwifiex: Add feature flag support for MAC randomization"
>> >
>> > The patch is already applied, so I'd only worry about it for future
>> > submissions (no need to resend).

Brian, thanks for pointing out that. I had missed it.

>> I'm Really Sorry.  I will take care of this in future.
>>
> The firmware which advertises this capability flag is yet to be shared
> in upstream. The latest available firmware does not contain this flag.
> So, is it possible to revert this change, so that we will resubmit
> this (with proper subject) once our firmware is uploaded.

Like Brian said, I don't think there's any point reverting it and
resending the patch. Just something to learn for the future, for both of
us. (I need to also check the titles more carefully.)

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-10-12  7:59 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-29 10:53 [PATCH] mwifiex: Random MAC address during scanning Ganapathi Bhat
2017-10-10  8:21 ` Kalle Valo
2017-10-11 19:41 ` [PATCH] " Brian Norris
2017-10-12  5:27   ` [EXT] " Ganapathi Bhat
2017-10-12  5:53   ` Ganapathi Bhat
2017-10-12  7:59     ` Kalle Valo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.