All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoffer Dall <christoffer.dall@linaro.org>
To: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org
Cc: Marc Zyngier <marc.zyngier@arm.com>,
	Shih-Wei Li <shihwei@cs.columbia.edu>,
	kvm@vger.kernel.org
Subject: [PATCH 15/37] KVM: arm64: Don't deactivate VM on VHE systems
Date: Thu, 12 Oct 2017 12:41:19 +0200	[thread overview]
Message-ID: <20171012104141.26902-16-christoffer.dall@linaro.org> (raw)
In-Reply-To: <20171012104141.26902-1-christoffer.dall@linaro.org>

There is no need to reset the VTTBR to zero when exiting the guest on
VHE systems.  VHE systems don't use stage 2 translations for the EL2&0
translation regime used by the host.

Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
---
 arch/arm64/kvm/hyp/switch.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/kvm/hyp/switch.c b/arch/arm64/kvm/hyp/switch.c
index b72dc66..2cedf12 100644
--- a/arch/arm64/kvm/hyp/switch.c
+++ b/arch/arm64/kvm/hyp/switch.c
@@ -136,13 +136,13 @@ static void __hyp_text __deactivate_traps(struct kvm_vcpu *vcpu)
 	write_sysreg(0, pmuserenr_el0);
 }
 
-static void __hyp_text __activate_vm(struct kvm_vcpu *vcpu)
+static inline void __hyp_text __activate_vm(struct kvm_vcpu *vcpu)
 {
 	struct kvm *kvm = kern_hyp_va(vcpu->kvm);
 	write_sysreg(kvm->arch.vttbr, vttbr_el2);
 }
 
-static void __hyp_text __deactivate_vm(struct kvm_vcpu *vcpu)
+static inline void __hyp_text __deactivate_vm(struct kvm_vcpu *vcpu)
 {
 	write_sysreg(0, vttbr_el2);
 }
@@ -360,7 +360,6 @@ int kvm_vcpu_run(struct kvm_vcpu *vcpu)
 	__vgic_save_state(vcpu);
 
 	__deactivate_traps(vcpu);
-	__deactivate_vm(vcpu);
 
 	__sysreg_restore_host_state(host_ctxt);
 
-- 
2.9.0

WARNING: multiple messages have this Message-ID (diff)
From: christoffer.dall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 15/37] KVM: arm64: Don't deactivate VM on VHE systems
Date: Thu, 12 Oct 2017 12:41:19 +0200	[thread overview]
Message-ID: <20171012104141.26902-16-christoffer.dall@linaro.org> (raw)
In-Reply-To: <20171012104141.26902-1-christoffer.dall@linaro.org>

There is no need to reset the VTTBR to zero when exiting the guest on
VHE systems.  VHE systems don't use stage 2 translations for the EL2&0
translation regime used by the host.

Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
---
 arch/arm64/kvm/hyp/switch.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/kvm/hyp/switch.c b/arch/arm64/kvm/hyp/switch.c
index b72dc66..2cedf12 100644
--- a/arch/arm64/kvm/hyp/switch.c
+++ b/arch/arm64/kvm/hyp/switch.c
@@ -136,13 +136,13 @@ static void __hyp_text __deactivate_traps(struct kvm_vcpu *vcpu)
 	write_sysreg(0, pmuserenr_el0);
 }
 
-static void __hyp_text __activate_vm(struct kvm_vcpu *vcpu)
+static inline void __hyp_text __activate_vm(struct kvm_vcpu *vcpu)
 {
 	struct kvm *kvm = kern_hyp_va(vcpu->kvm);
 	write_sysreg(kvm->arch.vttbr, vttbr_el2);
 }
 
-static void __hyp_text __deactivate_vm(struct kvm_vcpu *vcpu)
+static inline void __hyp_text __deactivate_vm(struct kvm_vcpu *vcpu)
 {
 	write_sysreg(0, vttbr_el2);
 }
@@ -360,7 +360,6 @@ int kvm_vcpu_run(struct kvm_vcpu *vcpu)
 	__vgic_save_state(vcpu);
 
 	__deactivate_traps(vcpu);
-	__deactivate_vm(vcpu);
 
 	__sysreg_restore_host_state(host_ctxt);
 
-- 
2.9.0

  parent reply	other threads:[~2017-10-12 10:41 UTC|newest]

Thread overview: 254+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-12 10:41 [PATCH 00/37] Optimize KVM/ARM for VHE systems Christoffer Dall
2017-10-12 10:41 ` Christoffer Dall
2017-10-12 10:41 ` [PATCH 01/37] KVM: arm64: Avoid storing the vcpu pointer on the stack Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-10-12 15:49   ` Marc Zyngier
2017-10-12 15:49     ` Marc Zyngier
2017-10-12 17:02     ` Christoffer Dall
2017-10-12 17:02       ` Christoffer Dall
2017-10-13 11:31       ` Marc Zyngier
2017-10-13 11:31         ` Marc Zyngier
2017-11-23 20:59     ` Christoffer Dall
2017-11-23 20:59       ` Christoffer Dall
2017-11-27 11:11       ` James Morse
2017-11-27 11:11         ` James Morse
2017-11-29 18:20         ` Christoffer Dall
2017-11-29 18:20           ` Christoffer Dall
2017-11-06 17:22   ` Andrew Jones
2017-11-06 17:22     ` Andrew Jones
2017-11-07  8:24     ` Christoffer Dall
2017-11-07  8:24       ` Christoffer Dall
2017-10-12 10:41 ` [PATCH 02/37] KVM: arm64: Rework hyp_panic for VHE and non-VHE Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-10-12 15:55   ` Marc Zyngier
2017-10-12 15:55     ` Marc Zyngier
2017-10-12 17:06     ` Christoffer Dall
2017-10-12 17:06       ` Christoffer Dall
2017-10-12 10:41 ` [PATCH 03/37] KVM: arm64: Move HCR_INT_OVERRIDE to default HCR_EL2 guest flag Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-10-12 16:20   ` Marc Zyngier
2017-10-12 16:20     ` Marc Zyngier
2017-10-12 10:41 ` [PATCH 04/37] KVM: arm/arm64: Get rid of vcpu->arch.irq_lines Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-10-12 16:24   ` Marc Zyngier
2017-10-12 16:24     ` Marc Zyngier
2017-11-06 17:58   ` Andrew Jones
2017-11-06 17:58     ` Andrew Jones
2017-11-14 12:17   ` Julien Thierry
2017-11-14 12:17     ` Julien Thierry
2017-11-16 16:11     ` Julien Thierry
2017-11-16 16:11       ` Julien Thierry
2017-11-26 16:04     ` Christoffer Dall
2017-11-26 16:04       ` Christoffer Dall
2017-10-12 10:41 ` [PATCH 05/37] KVM: Record the executing ioctl number on the vcpu struct Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-10-13 17:13   ` Radim Krčmář
2017-10-13 17:13     ` Radim Krčmář
2017-10-13 17:31     ` Christoffer Dall
2017-10-13 17:31       ` Christoffer Dall
2017-10-13 18:38       ` Radim Krčmář
2017-10-13 18:38         ` Radim Krčmář
2017-10-13 18:51         ` Christoffer Dall
2017-10-13 18:51           ` Christoffer Dall
2017-11-07 10:45   ` Andrew Jones
2017-11-07 10:45     ` Andrew Jones
2017-11-22 20:28     ` Christoffer Dall
2017-11-22 20:28       ` Christoffer Dall
2017-10-12 10:41 ` [PATCH 06/37] KVM: arm/arm64: Only load/put VCPU state for KVM_RUN Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-10-12 10:41 ` [PATCH 07/37] KVM: arm/arm64: Add kvm_vcpu_load_sysregs and kvm_vcpu_put_sysregs Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-11-07 10:56   ` Andrew Jones
2017-11-07 10:56     ` Andrew Jones
2017-11-07 11:10   ` Andrew Jones
2017-11-07 11:10     ` Andrew Jones
2017-11-22 20:34     ` Christoffer Dall
2017-11-22 20:34       ` Christoffer Dall
2017-11-23 11:08       ` Andrew Jones
2017-11-23 11:08         ` Andrew Jones
2017-10-12 10:41 ` [PATCH 08/37] KVM: arm64: Defer restoring host VFP state to vcpu_put Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-11-07 13:15   ` Andrew Jones
2017-11-07 13:15     ` Andrew Jones
2017-11-26 16:24     ` Christoffer Dall
2017-11-26 16:24       ` Christoffer Dall
2017-11-15 16:04   ` Andrew Jones
2017-11-15 16:04     ` Andrew Jones
2017-11-26 16:17     ` Christoffer Dall
2017-11-26 16:17       ` Christoffer Dall
2017-11-27  8:32       ` Andrew Jones
2017-11-27  8:32         ` Andrew Jones
2017-11-25  7:52   ` Yury Norov
2017-11-25  7:52     ` Yury Norov
2017-11-26 16:17     ` Christoffer Dall
2017-11-26 16:17       ` Christoffer Dall
2017-11-26 18:58       ` Yury Norov
2017-11-26 18:58         ` Yury Norov
2017-11-26 19:18         ` Christoffer Dall
2017-11-26 19:18           ` Christoffer Dall
2017-11-27  6:25           ` Yury Norov
2017-11-27  6:25             ` Yury Norov
2017-11-30 19:07         ` Marc Zyngier
2017-11-30 19:07           ` Marc Zyngier
2017-10-12 10:41 ` [PATCH 09/37] KVM: arm64: Move debug dirty flag calculation out of world switch Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-11-07 14:09   ` Andrew Jones
2017-11-07 14:09     ` Andrew Jones
2017-11-25  8:09     ` Yury Norov
2017-11-25  8:09       ` Yury Norov
2017-12-01 17:25     ` Christoffer Dall
2017-12-01 17:25       ` Christoffer Dall
2017-12-03 13:17       ` Andrew Jones
2017-12-03 13:17         ` Andrew Jones
2017-10-12 10:41 ` [PATCH 10/37] KVM: arm64: Slightly improve debug save/restore functions Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-11-07 14:22   ` Andrew Jones
2017-11-07 14:22     ` Andrew Jones
2017-12-01 17:51     ` Christoffer Dall
2017-12-01 17:51       ` Christoffer Dall
2017-11-14 16:42   ` Julien Thierry
2017-11-14 16:42     ` Julien Thierry
2017-12-01 15:19     ` Christoffer Dall
2017-12-01 15:19       ` Christoffer Dall
2017-12-06 15:38       ` Julien Thierry
2017-12-06 15:38         ` Julien Thierry
2017-10-12 10:41 ` [PATCH 11/37] KVM: arm64: Improve debug register save/restore flow Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-11-07 14:48   ` Andrew Jones
2017-11-07 14:48     ` Andrew Jones
2017-12-01 17:52     ` Christoffer Dall
2017-12-01 17:52       ` Christoffer Dall
2017-12-03 13:49       ` Andrew Jones
2017-12-03 13:49         ` Andrew Jones
2017-12-03 20:47         ` Christoffer Dall
2017-12-03 20:47           ` Christoffer Dall
2017-10-12 10:41 ` [PATCH 12/37] KVM: arm64: Factor out fault info population and gic workarounds Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-11-07 15:12   ` Andrew Jones
2017-11-07 15:12     ` Andrew Jones
2017-10-12 10:41 ` [PATCH 13/37] KVM: arm64: Introduce VHE-specific kvm_vcpu_run Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-11-07 15:25   ` Andrew Jones
2017-11-07 15:25     ` Andrew Jones
2017-12-01 18:10     ` Christoffer Dall
2017-12-01 18:10       ` Christoffer Dall
2017-10-12 10:41 ` [PATCH 14/37] KVM: arm64: Remove kern_hyp_va() use in VHE switch function Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-11-07 16:07   ` Andrew Jones
2017-11-07 16:07     ` Andrew Jones
2017-10-12 10:41 ` Christoffer Dall [this message]
2017-10-12 10:41   ` [PATCH 15/37] KVM: arm64: Don't deactivate VM on VHE systems Christoffer Dall
2017-11-07 16:14   ` Andrew Jones
2017-11-07 16:14     ` Andrew Jones
2017-12-03 19:27     ` Christoffer Dall
2017-12-03 19:27       ` Christoffer Dall
2017-10-12 10:41 ` [PATCH 16/37] KVM: arm64: Remove noop calls to timer save/restore from VHE switch Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-11-07 16:25   ` Andrew Jones
2017-11-07 16:25     ` Andrew Jones
2017-12-03 19:27     ` Christoffer Dall
2017-12-03 19:27       ` Christoffer Dall
2017-10-12 10:41 ` [PATCH 17/37] KVM: arm64: Move userspace system registers into separate function Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-11-08  9:32   ` Andrew Jones
2017-11-08  9:32     ` Andrew Jones
2017-12-03 19:36     ` Christoffer Dall
2017-12-03 19:36       ` Christoffer Dall
2017-10-12 10:41 ` [PATCH 18/37] KVM: arm64: Rewrite sysreg alternatives to static keys Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-10-12 10:41 ` [PATCH 19/37] KVM: arm64: Introduce separate VHE/non-VHE sysreg save/restore functions Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-11-08 10:31   ` Andrew Jones
2017-11-08 10:31     ` Andrew Jones
2017-10-12 10:41 ` [PATCH 20/37] KVM: arm64: Unify non-VHE host/guest sysreg save and restore functions Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-11-08 10:39   ` Andrew Jones
2017-11-08 10:39     ` Andrew Jones
2017-12-03 19:41     ` Christoffer Dall
2017-12-03 19:41       ` Christoffer Dall
2017-10-12 10:41 ` [PATCH 21/37] KVM: arm64: Don't save the host ELR_EL2 and SPSR_EL2 on VHE systems Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-11-08 17:03   ` Andrew Jones
2017-11-08 17:03     ` Andrew Jones
2017-12-03 19:45     ` Christoffer Dall
2017-12-03 19:45       ` Christoffer Dall
2017-10-12 10:41 ` [PATCH 22/37] KVM: arm64: Change 32-bit handling of VM system registers Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-11-13 16:25   ` Andrew Jones
2017-11-13 16:25     ` Andrew Jones
2017-10-12 10:41 ` [PATCH 23/37] KVM: arm64: Prepare to handle traps on deferred VM sysregs Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-11-13 17:54   ` Andrew Jones
2017-11-13 17:54     ` Andrew Jones
2017-12-03 19:50     ` Christoffer Dall
2017-12-03 19:50       ` Christoffer Dall
2017-12-04 10:05       ` Andrew Jones
2017-12-04 10:05         ` Andrew Jones
2017-10-12 10:41 ` [PATCH 24/37] KVM: arm64: Prepare to handle traps on deferred EL0 sysregs Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-11-15  9:25   ` Julien Thierry
2017-11-15  9:25     ` Julien Thierry
2017-12-03 19:51     ` Christoffer Dall
2017-12-03 19:51       ` Christoffer Dall
2017-10-12 10:41 ` [PATCH 25/37] KVM: arm64: Prepare to handle traps on remaining deferred EL1 sysregs Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-11-13 18:56   ` Andrew Jones
2017-11-13 18:56     ` Andrew Jones
2017-12-03 20:29     ` Christoffer Dall
2017-12-03 20:29       ` Christoffer Dall
2017-10-12 10:41 ` [PATCH 26/37] KVM: arm64: Prepare to handle traps on deferred AArch32 sysregs Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-11-13 19:07   ` Andrew Jones
2017-11-13 19:07     ` Andrew Jones
2017-12-03 20:35     ` Christoffer Dall
2017-12-03 20:35       ` Christoffer Dall
2017-10-12 10:41 ` [PATCH 27/37] KVM: arm64: Defer saving/restoring system registers to vcpu load/put on VHE Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-10-12 10:41 ` [PATCH 28/37] KVM: arm64: Move common VHE/non-VHE trap config in separate functions Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-11-25 10:43   ` Yury Norov
2017-11-25 10:43     ` Yury Norov
2017-11-25 10:49     ` Russell King - ARM Linux
2017-11-25 10:49       ` Russell King - ARM Linux
2017-10-12 10:41 ` [PATCH 29/37] KVM: arm64: Configure FPSIMD traps on vcpu load/put for VHE Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-10-12 10:41 ` [PATCH 30/37] KVM: arm64: Configure c15, PMU, and debug register traps on cpu " Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-10-12 10:41 ` [PATCH 31/37] KVM: arm64: Separate activate_traps and deactive_traps for VHE and non-VHE Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-10-12 10:41 ` [PATCH 32/37] KVM: arm/arm64: Handle VGICv2 save/restore from the main VGIC code Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-11-15 17:50   ` Andre Przywara
2017-11-15 17:50     ` Andre Przywara
2017-11-26 10:29     ` Yury Norov
2017-11-26 10:29       ` Yury Norov
2017-11-26 19:46       ` Christoffer Dall
2017-11-26 19:46         ` Christoffer Dall
2017-11-30 12:09         ` Yury Norov
2017-11-30 12:09           ` Yury Norov
2017-11-26 19:37     ` Christoffer Dall
2017-11-26 19:37       ` Christoffer Dall
2017-10-12 10:41 ` [PATCH 33/37] KVM: arm/arm64: Move arm64-only vgic-v2-sr.c file to arm64 Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-11-15 17:52   ` Andre Przywara
2017-11-15 17:52     ` Andre Przywara
2017-10-12 10:41 ` [PATCH 34/37] KVM: arm/arm64: Handle VGICv3 save/restore from the main VGIC code on VHE Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-10-12 10:41 ` [PATCH 35/37] KVM: arm/arm64: Get rid of vgic_elrsr Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-11-26 14:39   ` Yury Norov
2017-11-26 14:39     ` Yury Norov
2017-11-26 19:53     ` Christoffer Dall
2017-11-26 19:53       ` Christoffer Dall
2017-10-12 10:41 ` [PATCH 36/37] KVM: arm/arm64: Move VGIC APR save/restore to vgic put/load Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-11-26 15:09   ` Yury Norov
2017-11-26 15:09     ` Yury Norov
2017-11-26 19:55     ` Christoffer Dall
2017-11-26 19:55       ` Christoffer Dall
2017-10-12 10:41 ` [PATCH 37/37] KVM: arm/arm64: Avoid VGICv3 save/restore on VHE with no IRQs Christoffer Dall
2017-10-12 10:41   ` Christoffer Dall
2017-11-30 18:33   ` Yury Norov
2017-11-30 18:33     ` Yury Norov
2017-12-03 20:38     ` Christoffer Dall
2017-12-03 20:38       ` Christoffer Dall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171012104141.26902-16-christoffer.dall@linaro.org \
    --to=christoffer.dall@linaro.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=marc.zyngier@arm.com \
    --cc=shihwei@cs.columbia.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.