All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dmaengine: stm32_mdma: add CONFIG_OF dependency
@ 2017-10-11 14:00 Arnd Bergmann
  2017-10-12 14:04 ` Vinod Koul
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-10-11 14:00 UTC (permalink / raw)
  To: Vinod Koul
  Cc: Arnd Bergmann, Dan Williams, M'boumba Cedric Madianga,
	Ludovic BARRE, Pierre-Yves MORDRET, dmaengine, linux-kernel

Without CONFIG_OF we get a build warning:

warning: (STM32_MDMA) selects DMA_OF which has unmet direct dependencies (DMADEVICES && OF)

This adds a dependency on CONFIG_OF. Since this means
we no longer need to select 'DMA_OF', I'm dropping that line
as well.

Fixes: a4ffb13c8946 ("dmaengine: Add STM32 MDMA driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/dma/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 73446622ccc9..303940b32f47 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -495,8 +495,8 @@ config STM32_DMAMUX
 config STM32_MDMA
 	bool "STMicroelectronics STM32 master dma support"
 	depends on ARCH_STM32 || COMPILE_TEST
+	depends on OF
 	select DMA_ENGINE
-	select DMA_OF
 	select DMA_VIRTUAL_CHANNELS
 	help
 	  Enable support for the on-chip MDMA controller on STMicroelectronics
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dmaengine: stm32_mdma: add CONFIG_OF dependency
  2017-10-11 14:00 [PATCH] dmaengine: stm32_mdma: add CONFIG_OF dependency Arnd Bergmann
@ 2017-10-12 14:04 ` Vinod Koul
  0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2017-10-12 14:04 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Dan Williams, M'boumba Cedric Madianga, Ludovic BARRE,
	Pierre-Yves MORDRET, dmaengine, linux-kernel

On Wed, Oct 11, 2017 at 04:00:04PM +0200, Arnd Bergmann wrote:
> Without CONFIG_OF we get a build warning:
> 
> warning: (STM32_MDMA) selects DMA_OF which has unmet direct dependencies (DMADEVICES && OF)
> 
> This adds a dependency on CONFIG_OF. Since this means
> we no longer need to select 'DMA_OF', I'm dropping that line
> as well.

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-10-12 14:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-11 14:00 [PATCH] dmaengine: stm32_mdma: add CONFIG_OF dependency Arnd Bergmann
2017-10-12 14:04 ` Vinod Koul

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.