All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Steve Lin <steven.lin1@broadcom.com>
Cc: netdev@vger.kernel.org, jiri@mellanox.com, davem@davemloft.net,
	michael.chan@broadcom.com, linux-pci@vger.kernel.org,
	linville@tuxdriver.com, gospo@broadcom.com
Subject: Re: [RFC 1/3] devlink: Add config parameter get/set operations
Date: Thu, 12 Oct 2017 16:15:48 +0200	[thread overview]
Message-ID: <20171012141548.GE14672@nanopsycho> (raw)
In-Reply-To: <1507815262-33294-2-git-send-email-steven.lin1@broadcom.com>

Thu, Oct 12, 2017 at 03:34:20PM CEST, steven.lin1@broadcom.com wrote:
>+
>+	/* When config doesn't take effect until next reboot (config
>+	 * just changed NVM which isn't read until boot, for example),
>+	 * this attribute should be set by the driver.
>+	 */
>+	DEVLINK_ATTR_RESTART_REQUIRED,		/* u8 */
>+

I think it would be nice to return this information as a part of retply
to set message - extack

Also, we need to expose to the user the original value (currently being
used) and the new one (to be used after driver re-instatiation)

  parent reply	other threads:[~2017-10-12 14:15 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-12 13:34 [RFC 0/3] Adding config get/set to devlink Steve Lin
2017-10-12 13:34 ` [RFC 1/3] devlink: Add config parameter get/set operations Steve Lin
2017-10-12 14:03   ` Jiri Pirko
2017-10-12 14:37     ` Steve Lin
2017-10-12 18:12     ` Andy Gospodarek
2017-10-13  7:04       ` Jiri Pirko
2017-10-12 14:15   ` Jiri Pirko [this message]
2017-10-12 13:34 ` [RFC 2/3] bnxt: Move generic devlink code to new file Steve Lin
2017-10-12 13:34 ` [RFC 3/3] bnxt: Add devlink support for config get/set Steve Lin
2017-10-12 14:35 ` [RFC 0/3] Adding config get/set to devlink Roopa Prabhu
2017-10-12 14:40   ` Jiri Pirko
2017-10-12 14:46     ` Roopa Prabhu
2017-10-12 15:04       ` Jiri Pirko
2017-10-12 15:31         ` Roopa Prabhu
2017-10-12 15:43         ` Florian Fainelli
2017-10-12 15:43           ` Florian Fainelli
2017-10-12 16:05           ` Roopa Prabhu
2017-10-12 16:05             ` Roopa Prabhu
2017-10-12 19:06           ` David Miller
2017-10-12 19:20             ` Florian Fainelli
2017-10-12 20:12               ` Steve Lin
2017-10-13  7:08                 ` Jiri Pirko
2017-10-12 21:36               ` Michal Kubecek
2017-10-12 21:53               ` Roopa Prabhu
2017-10-13  7:11                 ` Jiri Pirko
2017-10-14  4:21                   ` Roopa Prabhu
2017-10-12 19:01         ` David Miller
2017-10-12 19:01       ` David Miller
2017-10-12 18:59     ` David Miller
2017-10-12 14:45   ` Steve Lin
2017-10-12 14:51     ` Roopa Prabhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171012141548.GE14672@nanopsycho \
    --to=jiri@resnulli.us \
    --cc=davem@davemloft.net \
    --cc=gospo@broadcom.com \
    --cc=jiri@mellanox.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=steven.lin1@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.