All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roopa Prabhu <roopa@cumulusnetworks.com>
To: Steve Lin <steven.lin1@broadcom.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Jiri Pirko <jiri@mellanox.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	michael.chan@broadcom.com, linux-pci@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>,
	gospo@broadcom.com
Subject: Re: [RFC 0/3] Adding config get/set to devlink
Date: Thu, 12 Oct 2017 07:35:10 -0700	[thread overview]
Message-ID: <CAJieiUjuKtmYDZ5-7UjYkWFJuMGu2gajhziLQKAZLTz6g63f2A@mail.gmail.com> (raw)
In-Reply-To: <1507815262-33294-1-git-send-email-steven.lin1@broadcom.com>

On Thu, Oct 12, 2017 at 6:34 AM, Steve Lin <steven.lin1@broadcom.com> wrote:
> Adds a devlink command for getting & setting device configuration
> parameters, and enumerates a bunch of those parameters as devlink
> attributes.  Also introduces an attribute that can be set by a
> driver to indicate that the config change doesn't take effect
> until the next restart (as in the case of the bnxt driver changes
> in this patchset, for which all the configuration changes affect NVM
> only, and aren't loaded until the next restart.)
>
> bnxt driver patches make use of these new devlink cmds/attributes.
>
> Steve Lin (3):
>   devlink: Add config parameter get/set operations
>   bnxt: Move generic devlink code to new file
>   bnxt: Add devlink support for config get/set
>

Is the goal here to move all ethtool operations to devlink (I saw some
attrs related to speed etc). ?.
We do need to move ethtool attrs to netlink and devlink is a good
place (and of-course leave the current ethtool api around for backward
compatibility).

  parent reply	other threads:[~2017-10-12 14:35 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-12 13:34 [RFC 0/3] Adding config get/set to devlink Steve Lin
2017-10-12 13:34 ` [RFC 1/3] devlink: Add config parameter get/set operations Steve Lin
2017-10-12 14:03   ` Jiri Pirko
2017-10-12 14:37     ` Steve Lin
2017-10-12 18:12     ` Andy Gospodarek
2017-10-13  7:04       ` Jiri Pirko
2017-10-12 14:15   ` Jiri Pirko
2017-10-12 13:34 ` [RFC 2/3] bnxt: Move generic devlink code to new file Steve Lin
2017-10-12 13:34 ` [RFC 3/3] bnxt: Add devlink support for config get/set Steve Lin
2017-10-12 14:35 ` Roopa Prabhu [this message]
2017-10-12 14:40   ` [RFC 0/3] Adding config get/set to devlink Jiri Pirko
2017-10-12 14:46     ` Roopa Prabhu
2017-10-12 15:04       ` Jiri Pirko
2017-10-12 15:31         ` Roopa Prabhu
2017-10-12 15:43         ` Florian Fainelli
2017-10-12 15:43           ` Florian Fainelli
2017-10-12 16:05           ` Roopa Prabhu
2017-10-12 16:05             ` Roopa Prabhu
2017-10-12 19:06           ` David Miller
2017-10-12 19:20             ` Florian Fainelli
2017-10-12 20:12               ` Steve Lin
2017-10-13  7:08                 ` Jiri Pirko
2017-10-12 21:36               ` Michal Kubecek
2017-10-12 21:53               ` Roopa Prabhu
2017-10-13  7:11                 ` Jiri Pirko
2017-10-14  4:21                   ` Roopa Prabhu
2017-10-12 19:01         ` David Miller
2017-10-12 19:01       ` David Miller
2017-10-12 18:59     ` David Miller
2017-10-12 14:45   ` Steve Lin
2017-10-12 14:51     ` Roopa Prabhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJieiUjuKtmYDZ5-7UjYkWFJuMGu2gajhziLQKAZLTz6g63f2A@mail.gmail.com \
    --to=roopa@cumulusnetworks.com \
    --cc=davem@davemloft.net \
    --cc=gospo@broadcom.com \
    --cc=jiri@mellanox.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=steven.lin1@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.