All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: lukas.humbel@inf.ethz.ch
Cc: qemu-devel@nongnu.org, Marcel Apfelbaum <marcel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] hw/pci: Add e1000e NIC as command line argument
Date: Mon, 16 Oct 2017 20:02:32 +0300	[thread overview]
Message-ID: <20171016200124-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1508169816-5993-1-git-send-email-lukas.humbel@inf.ethz.ch>

On Mon, Oct 16, 2017 at 06:03:36PM +0200, lukas.humbel@inf.ethz.ch wrote:
> From: Lukas Humbel <lukas.humbel@inf.ethz.ch>
> 
> Signed-off-by: Lukas Humbel <lukas.humbel@inf.ethz.ch>

We keep these around for legacy reasons but I'm not sure we need to add
to the list.  What's wrong with just creating them with -device e1000e?

> ---
>  hw/pci/pci.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/pci/pci.c b/hw/pci/pci.c
> index 1e6fb88..9d6cd04 100644
> --- a/hw/pci/pci.c
> +++ b/hw/pci/pci.c
> @@ -1819,6 +1819,7 @@ static const char * const pci_nic_models[] = {
>      "i82559er",
>      "rtl8139",
>      "e1000",
> +    "e1000e",
>      "pcnet",
>      "virtio",
>      "sungem",
> @@ -1832,6 +1833,7 @@ static const char * const pci_nic_names[] = {
>      "i82559er",
>      "rtl8139",
>      "e1000",
> +    "e1000e",
>      "pcnet",
>      "virtio-net-pci",
>      "sungem",
> -- 
> 2.7.4

  reply	other threads:[~2017-10-16 17:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-16 16:03 [Qemu-devel] [PATCH] hw/pci: Add e1000e NIC as command line argument lukas.humbel
2017-10-16 17:02 ` Michael S. Tsirkin [this message]
2017-10-17  6:33   ` Lukas Humbel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171016200124-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=lukas.humbel@inf.ethz.ch \
    --cc=marcel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.