* [Qemu-devel] [PATCH] hw/pci: Add e1000e NIC as command line argument
@ 2017-10-16 16:03 lukas.humbel
2017-10-16 17:02 ` Michael S. Tsirkin
0 siblings, 1 reply; 3+ messages in thread
From: lukas.humbel @ 2017-10-16 16:03 UTC (permalink / raw)
To: qemu-devel; +Cc: Lukas Humbel, Michael S. Tsirkin, Marcel Apfelbaum
From: Lukas Humbel <lukas.humbel@inf.ethz.ch>
Signed-off-by: Lukas Humbel <lukas.humbel@inf.ethz.ch>
---
hw/pci/pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 1e6fb88..9d6cd04 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -1819,6 +1819,7 @@ static const char * const pci_nic_models[] = {
"i82559er",
"rtl8139",
"e1000",
+ "e1000e",
"pcnet",
"virtio",
"sungem",
@@ -1832,6 +1833,7 @@ static const char * const pci_nic_names[] = {
"i82559er",
"rtl8139",
"e1000",
+ "e1000e",
"pcnet",
"virtio-net-pci",
"sungem",
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/pci: Add e1000e NIC as command line argument
2017-10-16 16:03 [Qemu-devel] [PATCH] hw/pci: Add e1000e NIC as command line argument lukas.humbel
@ 2017-10-16 17:02 ` Michael S. Tsirkin
2017-10-17 6:33 ` Lukas Humbel
0 siblings, 1 reply; 3+ messages in thread
From: Michael S. Tsirkin @ 2017-10-16 17:02 UTC (permalink / raw)
To: lukas.humbel; +Cc: qemu-devel, Marcel Apfelbaum
On Mon, Oct 16, 2017 at 06:03:36PM +0200, lukas.humbel@inf.ethz.ch wrote:
> From: Lukas Humbel <lukas.humbel@inf.ethz.ch>
>
> Signed-off-by: Lukas Humbel <lukas.humbel@inf.ethz.ch>
We keep these around for legacy reasons but I'm not sure we need to add
to the list. What's wrong with just creating them with -device e1000e?
> ---
> hw/pci/pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/pci/pci.c b/hw/pci/pci.c
> index 1e6fb88..9d6cd04 100644
> --- a/hw/pci/pci.c
> +++ b/hw/pci/pci.c
> @@ -1819,6 +1819,7 @@ static const char * const pci_nic_models[] = {
> "i82559er",
> "rtl8139",
> "e1000",
> + "e1000e",
> "pcnet",
> "virtio",
> "sungem",
> @@ -1832,6 +1833,7 @@ static const char * const pci_nic_names[] = {
> "i82559er",
> "rtl8139",
> "e1000",
> + "e1000e",
> "pcnet",
> "virtio-net-pci",
> "sungem",
> --
> 2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/pci: Add e1000e NIC as command line argument
2017-10-16 17:02 ` Michael S. Tsirkin
@ 2017-10-17 6:33 ` Lukas Humbel
0 siblings, 0 replies; 3+ messages in thread
From: Lukas Humbel @ 2017-10-17 6:33 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: qemu-devel, Marcel Apfelbaum
On 16.10.2017 19:02, Michael S. Tsirkin wrote:
> On Mon, Oct 16, 2017 at 06:03:36PM +0200, lukas.humbel@inf.ethz.ch wrote:
>> From: Lukas Humbel <lukas.humbel@inf.ethz.ch>
>>
>> Signed-off-by: Lukas Humbel <lukas.humbel@inf.ethz.ch>
> We keep these around for legacy reasons but I'm not sure we need to add
> to the list. What's wrong with just creating them with -device e1000e?
Ah, I didn't realize that the -net argument is considered legacy. I
think there is nothing stopping me from using -device...
Thanks,
Lukas
>
>> ---
>> hw/pci/pci.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/hw/pci/pci.c b/hw/pci/pci.c
>> index 1e6fb88..9d6cd04 100644
>> --- a/hw/pci/pci.c
>> +++ b/hw/pci/pci.c
>> @@ -1819,6 +1819,7 @@ static const char * const pci_nic_models[] = {
>> "i82559er",
>> "rtl8139",
>> "e1000",
>> + "e1000e",
>> "pcnet",
>> "virtio",
>> "sungem",
>> @@ -1832,6 +1833,7 @@ static const char * const pci_nic_names[] = {
>> "i82559er",
>> "rtl8139",
>> "e1000",
>> + "e1000e",
>> "pcnet",
>> "virtio-net-pci",
>> "sungem",
>> --
>> 2.7.4
--
Lukas Humbel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-17 6:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-16 16:03 [Qemu-devel] [PATCH] hw/pci: Add e1000e NIC as command line argument lukas.humbel
2017-10-16 17:02 ` Michael S. Tsirkin
2017-10-17 6:33 ` Lukas Humbel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.