All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH  0/2] Add XHCI support
@ 2017-10-16 10:12 Biju Das
       [not found] ` <1508148769-47488-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
  2017-10-16 10:12 ` [PATCH 2/2] ARM: dts: r8a7743: Add xhci support to SoC dtsi Biju Das
  0 siblings, 2 replies; 16+ messages in thread
From: Biju Das @ 2017-10-16 10:12 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Felipe Balbi, Rob Herring, Mark Rutland
  Cc: Simon Horman, Magnus Damm, Yoshihiro Shimoda, Chris Paterson,
	Fabrizio Castro, devicetree, linux-renesas-soc, linux-usb,
	Biju Das

Hello,

This series aims to add USB XHCI support for iWave RZ/G1M (R8A7743) board.
This series has been tested against renesas-dev tag 20171013-v4.14-rc4.

Regards,

Fabrizio Castro (2):
  dt-bindings: usb-xhci: Document r8a7743 support
  ARM: dts: r8a7743: Add xhci support to SoC dtsi

 Documentation/devicetree/bindings/usb/usb-xhci.txt |  4 +++-
 arch/arm/boot/dts/r8a7743.dtsi                     | 20 ++++++++++++++++++++
 2 files changed, 23 insertions(+), 1 deletion(-)

-- 
1.9.1

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH  1/2] dt-bindings: usb-xhci: Document r8a7743 support
  2017-10-16 10:12 [PATCH 0/2] Add XHCI support Biju Das
@ 2017-10-16 10:12     ` Biju Das
  2017-10-16 10:12 ` [PATCH 2/2] ARM: dts: r8a7743: Add xhci support to SoC dtsi Biju Das
  1 sibling, 0 replies; 16+ messages in thread
From: Biju Das @ 2017-10-16 10:12 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Felipe Balbi, Rob Herring, Mark Rutland
  Cc: Simon Horman, Magnus Damm, Yoshihiro Shimoda, Chris Paterson,
	Fabrizio Castro, devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
	linux-usb-u79uwXL29TY76Z2rM5mHXA

From: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>

Document r8a7743 xhci support. The driver will use the fallback
compatible string "renesas,rcar-gen2-xhci", therefore no driver
change is needed.

Signed-off-by: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
---
 Documentation/devicetree/bindings/usb/usb-xhci.txt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt
index 2d80b60..4125d02 100644
--- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
+++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
@@ -7,12 +7,14 @@ Required properties:
     - "marvell,armada3700-xhci" for Armada 37xx SoCs
     - "marvell,armada-375-xhci" for Armada 375 SoCs
     - "marvell,armada-380-xhci" for Armada 38x SoCs
+    - "renesas,xhci-r8a7743" for r8a7743 SoC
     - "renesas,xhci-r8a7790" for r8a7790 SoC
     - "renesas,xhci-r8a7791" for r8a7791 SoC
     - "renesas,xhci-r8a7793" for r8a7793 SoC
     - "renesas,xhci-r8a7795" for r8a7795 SoC
     - "renesas,xhci-r8a7796" for r8a7796 SoC
-    - "renesas,rcar-gen2-xhci" for a generic R-Car Gen2 compatible device
+    - "renesas,rcar-gen2-xhci" for a generic R-Car Gen2 or RZ/G1 compatible
+      device
     - "renesas,rcar-gen3-xhci" for a generic R-Car Gen3 compatible device
     - "xhci-platform" (deprecated)
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH  1/2] dt-bindings: usb-xhci: Document r8a7743 support
@ 2017-10-16 10:12     ` Biju Das
  0 siblings, 0 replies; 16+ messages in thread
From: Biju Das @ 2017-10-16 10:12 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Felipe Balbi, Rob Herring, Mark Rutland
  Cc: Simon Horman, Magnus Damm, Yoshihiro Shimoda, Chris Paterson,
	Fabrizio Castro, devicetree, linux-renesas-soc, linux-usb

From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Document r8a7743 xhci support. The driver will use the fallback
compatible string "renesas,rcar-gen2-xhci", therefore no driver
change is needed.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
 Documentation/devicetree/bindings/usb/usb-xhci.txt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt
index 2d80b60..4125d02 100644
--- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
+++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
@@ -7,12 +7,14 @@ Required properties:
     - "marvell,armada3700-xhci" for Armada 37xx SoCs
     - "marvell,armada-375-xhci" for Armada 375 SoCs
     - "marvell,armada-380-xhci" for Armada 38x SoCs
+    - "renesas,xhci-r8a7743" for r8a7743 SoC
     - "renesas,xhci-r8a7790" for r8a7790 SoC
     - "renesas,xhci-r8a7791" for r8a7791 SoC
     - "renesas,xhci-r8a7793" for r8a7793 SoC
     - "renesas,xhci-r8a7795" for r8a7795 SoC
     - "renesas,xhci-r8a7796" for r8a7796 SoC
-    - "renesas,rcar-gen2-xhci" for a generic R-Car Gen2 compatible device
+    - "renesas,rcar-gen2-xhci" for a generic R-Car Gen2 or RZ/G1 compatible
+      device
     - "renesas,rcar-gen3-xhci" for a generic R-Car Gen3 compatible device
     - "xhci-platform" (deprecated)
 
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH  2/2] ARM: dts: r8a7743: Add xhci support to SoC dtsi
  2017-10-16 10:12 [PATCH 0/2] Add XHCI support Biju Das
       [not found] ` <1508148769-47488-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
@ 2017-10-16 10:12 ` Biju Das
       [not found]   ` <1508148769-47488-3-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
  1 sibling, 1 reply; 16+ messages in thread
From: Biju Das @ 2017-10-16 10:12 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Felipe Balbi, Rob Herring, Mark Rutland
  Cc: Simon Horman, Magnus Damm, Yoshihiro Shimoda, Chris Paterson,
	Fabrizio Castro, devicetree, linux-renesas-soc, linux-usb

From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Add node for xhci. Boards DT files will enable it if needed.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
 arch/arm/boot/dts/r8a7743.dtsi | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
index 699c040..386bf07 100644
--- a/arch/arm/boot/dts/r8a7743.dtsi
+++ b/arch/arm/boot/dts/r8a7743.dtsi
@@ -931,6 +931,26 @@
 			status = "disabled";
 		};
 
+		/*
+		 * pci1 and xhci share the same phy, therefore only one of them
+		 * can be active at any one time. If both of them are enabled,
+		 * a race condition will determine who'll control the phy.
+		 * A firmware file is needed by the xhci driver in order for
+		 * USB 3.0 to work properly.
+		 */
+		xhci: usb@ee000000 {
+			compatible = "renesas,xhci-r8a7743",
+				     "renesas,rcar-gen2-xhci";
+			reg = <0 0xee000000 0 0xc00>;
+			interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 328>;
+			power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
+			resets = <&cpg 328>;
+			phys = <&usb2 1>;
+			phy-names = "usb";
+			status = "disabled";
+		};
+
 		sdhi0: sd@ee100000 {
 			compatible = "renesas,sdhi-r8a7743";
 			reg = <0 0xee100000 0 0x328>;
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* RE: [PATCH  1/2] dt-bindings: usb-xhci: Document r8a7743 support
  2017-10-16 10:12     ` Biju Das
@ 2017-10-17  1:33         ` Yoshihiro Shimoda
  -1 siblings, 0 replies; 16+ messages in thread
From: Yoshihiro Shimoda @ 2017-10-17  1:33 UTC (permalink / raw)
  To: Biju Das, Greg Kroah-Hartman, Felipe Balbi, Rob Herring,
	Mark Rutland, Mathias Nyman
  Cc: Simon Horman, Magnus Damm, Chris Paterson, Fabrizio Castro,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
	linux-usb-u79uwXL29TY76Z2rM5mHXA

Hi Biju-san,
(and added Mathias-san of the XHCI maintainer as TO)

Thank you for the patch!

> From: Biju Das, Sent: Monday, October 16, 2017 7:13 PM
> 
> From: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> 
> Document r8a7743 xhci support. The driver will use the fallback
> compatible string "renesas,rcar-gen2-xhci", therefore no driver
> change is needed.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/usb/usb-xhci.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> index 2d80b60..4125d02 100644
> --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> @@ -7,12 +7,14 @@ Required properties:
>      - "marvell,armada3700-xhci" for Armada 37xx SoCs
>      - "marvell,armada-375-xhci" for Armada 375 SoCs
>      - "marvell,armada-380-xhci" for Armada 38x SoCs
> +    - "renesas,xhci-r8a7743" for r8a7743 SoC
>      - "renesas,xhci-r8a7790" for r8a7790 SoC
>      - "renesas,xhci-r8a7791" for r8a7791 SoC
>      - "renesas,xhci-r8a7793" for r8a7793 SoC
>      - "renesas,xhci-r8a7795" for r8a7795 SoC
>      - "renesas,xhci-r8a7796" for r8a7796 SoC
> -    - "renesas,rcar-gen2-xhci" for a generic R-Car Gen2 compatible device
> +    - "renesas,rcar-gen2-xhci" for a generic R-Car Gen2 or RZ/G1 compatible
> +      device
>      - "renesas,rcar-gen3-xhci" for a generic R-Car Gen3 compatible device
>      - "xhci-platform" (deprecated)
>

It seems good to me. So,

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>

Best regards,
Yoshihiro Shimoda

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 16+ messages in thread

* RE: [PATCH  1/2] dt-bindings: usb-xhci: Document r8a7743 support
@ 2017-10-17  1:33         ` Yoshihiro Shimoda
  0 siblings, 0 replies; 16+ messages in thread
From: Yoshihiro Shimoda @ 2017-10-17  1:33 UTC (permalink / raw)
  To: Biju Das, Greg Kroah-Hartman, Felipe Balbi, Rob Herring,
	Mark Rutland, Mathias Nyman
  Cc: Simon Horman, Magnus Damm, Chris Paterson, Fabrizio Castro,
	devicetree, linux-renesas-soc, linux-usb

Hi Biju-san,
(and added Mathias-san of the XHCI maintainer as TO)

Thank you for the patch!

> From: Biju Das, Sent: Monday, October 16, 2017 7:13 PM
> 
> From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> 
> Document r8a7743 xhci support. The driver will use the fallback
> compatible string "renesas,rcar-gen2-xhci", therefore no driver
> change is needed.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
>  Documentation/devicetree/bindings/usb/usb-xhci.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> index 2d80b60..4125d02 100644
> --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> @@ -7,12 +7,14 @@ Required properties:
>      - "marvell,armada3700-xhci" for Armada 37xx SoCs
>      - "marvell,armada-375-xhci" for Armada 375 SoCs
>      - "marvell,armada-380-xhci" for Armada 38x SoCs
> +    - "renesas,xhci-r8a7743" for r8a7743 SoC
>      - "renesas,xhci-r8a7790" for r8a7790 SoC
>      - "renesas,xhci-r8a7791" for r8a7791 SoC
>      - "renesas,xhci-r8a7793" for r8a7793 SoC
>      - "renesas,xhci-r8a7795" for r8a7795 SoC
>      - "renesas,xhci-r8a7796" for r8a7796 SoC
> -    - "renesas,rcar-gen2-xhci" for a generic R-Car Gen2 compatible device
> +    - "renesas,rcar-gen2-xhci" for a generic R-Car Gen2 or RZ/G1 compatible
> +      device
>      - "renesas,rcar-gen3-xhci" for a generic R-Car Gen3 compatible device
>      - "xhci-platform" (deprecated)
>

It seems good to me. So,

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda

^ permalink raw reply	[flat|nested] 16+ messages in thread

* RE: [PATCH  2/2] ARM: dts: r8a7743: Add xhci support to SoC dtsi
  2017-10-16 10:12 ` [PATCH 2/2] ARM: dts: r8a7743: Add xhci support to SoC dtsi Biju Das
@ 2017-10-17  1:39       ` Yoshihiro Shimoda
  0 siblings, 0 replies; 16+ messages in thread
From: Yoshihiro Shimoda @ 2017-10-17  1:39 UTC (permalink / raw)
  To: Biju Das, Greg Kroah-Hartman, Felipe Balbi, Rob Herring, Mark Rutland
  Cc: Simon Horman, Magnus Damm, Chris Paterson, Fabrizio Castro,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
	linux-usb-u79uwXL29TY76Z2rM5mHXA

Hi Biju-san,

IIUC, when we submitted a patch for dts[i] file,
we don't need to submit such a patch to usb maintainers.

> From: Biju Das, Sent: Monday, October 16, 2017 7:13 PM
> 
> From: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> 
> Add node for xhci. Boards DT files will enable it if needed.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> ---
>  arch/arm/boot/dts/r8a7743.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
> index 699c040..386bf07 100644
> --- a/arch/arm/boot/dts/r8a7743.dtsi
> +++ b/arch/arm/boot/dts/r8a7743.dtsi
> @@ -931,6 +931,26 @@
>  			status = "disabled";
>  		};
> 
> +		/*
> +		 * pci1 and xhci share the same phy, therefore only one of them
> +		 * can be active at any one time. If both of them are enabled,
> +		 * a race condition will determine who'll control the phy.
> +		 * A firmware file is needed by the xhci driver in order for
> +		 * USB 3.0 to work properly.
> +		 */
> +		xhci: usb@ee000000 {
> +			compatible = "renesas,xhci-r8a7743",
> +				     "renesas,rcar-gen2-xhci";
> +			reg = <0 0xee000000 0 0xc00>;
> +			interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&cpg CPG_MOD 328>;
> +			power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
> +			resets = <&cpg 328>;
> +			phys = <&usb2 1>;
> +			phy-names = "usb";
> +			status = "disabled";
> +		};
> +
>  		sdhi0: sd@ee100000 {
>  			compatible = "renesas,sdhi-r8a7743";
>  			reg = <0 0xee100000 0 0x328>;

It seems good to me. So,

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>

Best regards,
Yoshihiro Shimoda

> --
> 1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 16+ messages in thread

* RE: [PATCH  2/2] ARM: dts: r8a7743: Add xhci support to SoC dtsi
@ 2017-10-17  1:39       ` Yoshihiro Shimoda
  0 siblings, 0 replies; 16+ messages in thread
From: Yoshihiro Shimoda @ 2017-10-17  1:39 UTC (permalink / raw)
  To: Biju Das, Greg Kroah-Hartman, Felipe Balbi, Rob Herring, Mark Rutland
  Cc: Simon Horman, Magnus Damm, Chris Paterson, Fabrizio Castro,
	devicetree, linux-renesas-soc, linux-usb

Hi Biju-san,

IIUC, when we submitted a patch for dts[i] file,
we don't need to submit such a patch to usb maintainers.

> From: Biju Das, Sent: Monday, October 16, 2017 7:13 PM
> 
> From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> 
> Add node for xhci. Boards DT files will enable it if needed.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
>  arch/arm/boot/dts/r8a7743.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
> index 699c040..386bf07 100644
> --- a/arch/arm/boot/dts/r8a7743.dtsi
> +++ b/arch/arm/boot/dts/r8a7743.dtsi
> @@ -931,6 +931,26 @@
>  			status = "disabled";
>  		};
> 
> +		/*
> +		 * pci1 and xhci share the same phy, therefore only one of them
> +		 * can be active at any one time. If both of them are enabled,
> +		 * a race condition will determine who'll control the phy.
> +		 * A firmware file is needed by the xhci driver in order for
> +		 * USB 3.0 to work properly.
> +		 */
> +		xhci: usb@ee000000 {
> +			compatible = "renesas,xhci-r8a7743",
> +				     "renesas,rcar-gen2-xhci";
> +			reg = <0 0xee000000 0 0xc00>;
> +			interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&cpg CPG_MOD 328>;
> +			power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
> +			resets = <&cpg 328>;
> +			phys = <&usb2 1>;
> +			phy-names = "usb";
> +			status = "disabled";
> +		};
> +
>  		sdhi0: sd@ee100000 {
>  			compatible = "renesas,sdhi-r8a7743";
>  			reg = <0 0xee100000 0 0x328>;

It seems good to me. So,

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda

> --
> 1.9.1

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH  1/2] dt-bindings: usb-xhci: Document r8a7743 support
  2017-10-16 10:12     ` Biju Das
@ 2017-10-17  7:54         ` Simon Horman
  -1 siblings, 0 replies; 16+ messages in thread
From: Simon Horman @ 2017-10-17  7:54 UTC (permalink / raw)
  To: Biju Das
  Cc: Greg Kroah-Hartman, Felipe Balbi, Rob Herring, Mark Rutland,
	Magnus Damm, Yoshihiro Shimoda, Chris Paterson, Fabrizio Castro,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
	linux-usb-u79uwXL29TY76Z2rM5mHXA

On Mon, Oct 16, 2017 at 11:12:48AM +0100, Biju Das wrote:
> From: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> 
> Document r8a7743 xhci support. The driver will use the fallback
> compatible string "renesas,rcar-gen2-xhci", therefore no driver
> change is needed.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>

Reviewed-by: Simon Horman <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH  1/2] dt-bindings: usb-xhci: Document r8a7743 support
@ 2017-10-17  7:54         ` Simon Horman
  0 siblings, 0 replies; 16+ messages in thread
From: Simon Horman @ 2017-10-17  7:54 UTC (permalink / raw)
  To: Biju Das
  Cc: Greg Kroah-Hartman, Felipe Balbi, Rob Herring, Mark Rutland,
	Magnus Damm, Yoshihiro Shimoda, Chris Paterson, Fabrizio Castro,
	devicetree, linux-renesas-soc, linux-usb

On Mon, Oct 16, 2017 at 11:12:48AM +0100, Biju Das wrote:
> From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> 
> Document r8a7743 xhci support. The driver will use the fallback
> compatible string "renesas,rcar-gen2-xhci", therefore no driver
> change is needed.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* RE: [PATCH  2/2] ARM: dts: r8a7743: Add xhci support to SoC dtsi
  2017-10-17  1:39       ` Yoshihiro Shimoda
  (?)
@ 2017-10-17  8:27       ` Biju Das
  -1 siblings, 0 replies; 16+ messages in thread
From: Biju Das @ 2017-10-17  8:27 UTC (permalink / raw)
  To: Yoshihiro Shimoda, Greg Kroah-Hartman, Felipe Balbi, Rob Herring,
	Mark Rutland
  Cc: Simon Horman, Magnus Damm, Chris Paterson, Fabrizio Castro,
	devicetree, linux-renesas-soc, linux-usb

Hi Shimoda-San,


> Hi Biju-san,
>
> IIUC, when we submitted a patch for dts[i] file, we don't need to submit such a
> patch to usb maintainers.

Thanks. I will take care this in future.

Regards,
Biju



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH  2/2] ARM: dts: r8a7743: Add xhci support to SoC dtsi
  2017-10-17  1:39       ` Yoshihiro Shimoda
@ 2017-10-18  5:22           ` Simon Horman
  -1 siblings, 0 replies; 16+ messages in thread
From: Simon Horman @ 2017-10-18  5:22 UTC (permalink / raw)
  To: Yoshihiro Shimoda
  Cc: Biju Das, Greg Kroah-Hartman, Felipe Balbi, Rob Herring,
	Mark Rutland, Magnus Damm, Chris Paterson, Fabrizio Castro,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
	linux-usb-u79uwXL29TY76Z2rM5mHXA

On Tue, Oct 17, 2017 at 01:39:33AM +0000, Yoshihiro Shimoda wrote:
> Hi Biju-san,
> 
> IIUC, when we submitted a patch for dts[i] file,
> we don't need to submit such a patch to usb maintainers.
> 
> > From: Biju Das, Sent: Monday, October 16, 2017 7:13 PM
> > 
> > From: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> > 
> > Add node for xhci. Boards DT files will enable it if needed.
> > 
> > Signed-off-by: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> > ---
> >  arch/arm/boot/dts/r8a7743.dtsi | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
> > index 699c040..386bf07 100644
> > --- a/arch/arm/boot/dts/r8a7743.dtsi
> > +++ b/arch/arm/boot/dts/r8a7743.dtsi
> > @@ -931,6 +931,26 @@
> >  			status = "disabled";
> >  		};
> > 
> > +		/*
> > +		 * pci1 and xhci share the same phy, therefore only one of them
> > +		 * can be active at any one time. If both of them are enabled,
> > +		 * a race condition will determine who'll control the phy.
> > +		 * A firmware file is needed by the xhci driver in order for
> > +		 * USB 3.0 to work properly.
> > +		 */
> > +		xhci: usb@ee000000 {
> > +			compatible = "renesas,xhci-r8a7743",
> > +				     "renesas,rcar-gen2-xhci";
> > +			reg = <0 0xee000000 0 0xc00>;
> > +			interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>;
> > +			clocks = <&cpg CPG_MOD 328>;
> > +			power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
> > +			resets = <&cpg 328>;
> > +			phys = <&usb2 1>;
> > +			phy-names = "usb";
> > +			status = "disabled";
> > +		};
> > +
> >  		sdhi0: sd@ee100000 {
> >  			compatible = "renesas,sdhi-r8a7743";
> >  			reg = <0 0xee100000 0 0x328>;
> 
> It seems good to me. So,
> 
> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>

Thanks, applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH  2/2] ARM: dts: r8a7743: Add xhci support to SoC dtsi
@ 2017-10-18  5:22           ` Simon Horman
  0 siblings, 0 replies; 16+ messages in thread
From: Simon Horman @ 2017-10-18  5:22 UTC (permalink / raw)
  To: Yoshihiro Shimoda
  Cc: Biju Das, Greg Kroah-Hartman, Felipe Balbi, Rob Herring,
	Mark Rutland, Magnus Damm, Chris Paterson, Fabrizio Castro,
	devicetree, linux-renesas-soc, linux-usb

On Tue, Oct 17, 2017 at 01:39:33AM +0000, Yoshihiro Shimoda wrote:
> Hi Biju-san,
> 
> IIUC, when we submitted a patch for dts[i] file,
> we don't need to submit such a patch to usb maintainers.
> 
> > From: Biju Das, Sent: Monday, October 16, 2017 7:13 PM
> > 
> > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > 
> > Add node for xhci. Boards DT files will enable it if needed.
> > 
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > ---
> >  arch/arm/boot/dts/r8a7743.dtsi | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
> > index 699c040..386bf07 100644
> > --- a/arch/arm/boot/dts/r8a7743.dtsi
> > +++ b/arch/arm/boot/dts/r8a7743.dtsi
> > @@ -931,6 +931,26 @@
> >  			status = "disabled";
> >  		};
> > 
> > +		/*
> > +		 * pci1 and xhci share the same phy, therefore only one of them
> > +		 * can be active at any one time. If both of them are enabled,
> > +		 * a race condition will determine who'll control the phy.
> > +		 * A firmware file is needed by the xhci driver in order for
> > +		 * USB 3.0 to work properly.
> > +		 */
> > +		xhci: usb@ee000000 {
> > +			compatible = "renesas,xhci-r8a7743",
> > +				     "renesas,rcar-gen2-xhci";
> > +			reg = <0 0xee000000 0 0xc00>;
> > +			interrupts = <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>;
> > +			clocks = <&cpg CPG_MOD 328>;
> > +			power-domains = <&sysc R8A7743_PD_ALWAYS_ON>;
> > +			resets = <&cpg 328>;
> > +			phys = <&usb2 1>;
> > +			phy-names = "usb";
> > +			status = "disabled";
> > +		};
> > +
> >  		sdhi0: sd@ee100000 {
> >  			compatible = "renesas,sdhi-r8a7743";
> >  			reg = <0 0xee100000 0 0x328>;
> 
> It seems good to me. So,
> 
> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Thanks, applied.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* RE: [PATCH  1/2] dt-bindings: usb-xhci: Document r8a7743 support
  2017-10-17  1:33         ` Yoshihiro Shimoda
  (?)
@ 2017-11-07 11:00         ` Biju Das
       [not found]           ` <KL1PR06MB1702D3E0C32610A0591A445FB8510-k6wCOA2IOKSx7cDWSRonpW0DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
  -1 siblings, 1 reply; 16+ messages in thread
From: Biju Das @ 2017-11-07 11:00 UTC (permalink / raw)
  To: Yoshihiro Shimoda, Greg Kroah-Hartman, Felipe Balbi, Rob Herring,
	Mark Rutland, Mathias Nyman
  Cc: Simon Horman, Magnus Damm, Chris Paterson, Fabrizio Castro,
	devicetree, linux-renesas-soc, linux-usb

Hi Mathias,

Does this patch look okay to you?

Regards,
Biju

> -----Original Message-----
> From: Yoshihiro Shimoda
> Sent: 17 October 2017 02:34
> To: Biju Das <biju.das@bp.renesas.com>; Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>; Felipe Balbi <balbi@kernel.org>; Rob Herring
> <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>; Mathias
> Nyman <mathias.nyman@intel.com>
> Cc: Simon Horman <horms@verge.net.au>; Magnus Damm
> <magnus.damm@gmail.com>; Chris Paterson <Chris.Paterson2@renesas.com>;
> Fabrizio Castro <fabrizio.castro@bp.renesas.com>;
> devicetree@vger.kernel.org; linux-renesas-soc@vger.kernel.org; linux-
> usb@vger.kernel.org
> Subject: RE: [PATCH 1/2] dt-bindings: usb-xhci: Document r8a7743 support
>
> Hi Biju-san,
> (and added Mathias-san of the XHCI maintainer as TO)
>
> Thank you for the patch!
>
> > From: Biju Das, Sent: Monday, October 16, 2017 7:13 PM
> >
> > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >
> > Document r8a7743 xhci support. The driver will use the fallback
> > compatible string "renesas,rcar-gen2-xhci", therefore no driver change
> > is needed.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > ---
> >  Documentation/devicetree/bindings/usb/usb-xhci.txt | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > index 2d80b60..4125d02 100644
> > --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > @@ -7,12 +7,14 @@ Required properties:
> >      - "marvell,armada3700-xhci" for Armada 37xx SoCs
> >      - "marvell,armada-375-xhci" for Armada 375 SoCs
> >      - "marvell,armada-380-xhci" for Armada 38x SoCs
> > +    - "renesas,xhci-r8a7743" for r8a7743 SoC
> >      - "renesas,xhci-r8a7790" for r8a7790 SoC
> >      - "renesas,xhci-r8a7791" for r8a7791 SoC
> >      - "renesas,xhci-r8a7793" for r8a7793 SoC
> >      - "renesas,xhci-r8a7795" for r8a7795 SoC
> >      - "renesas,xhci-r8a7796" for r8a7796 SoC
> > -    - "renesas,rcar-gen2-xhci" for a generic R-Car Gen2 compatible device
> > +    - "renesas,rcar-gen2-xhci" for a generic R-Car Gen2 or RZ/G1 compatible
> > +      device
> >      - "renesas,rcar-gen3-xhci" for a generic R-Car Gen3 compatible device
> >      - "xhci-platform" (deprecated)
> >
>
> It seems good to me. So,
>
> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>
> Best regards,
> Yoshihiro Shimoda




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 1/2] dt-bindings: usb-xhci: Document r8a7743 support
  2017-11-07 11:00         ` Biju Das
@ 2017-11-07 13:32               ` Mathias Nyman
  0 siblings, 0 replies; 16+ messages in thread
From: Mathias Nyman @ 2017-11-07 13:32 UTC (permalink / raw)
  To: Biju Das, Yoshihiro Shimoda, Greg Kroah-Hartman, Felipe Balbi,
	Rob Herring, Mark Rutland, Mathias Nyman
  Cc: Simon Horman, Magnus Damm, Chris Paterson, Fabrizio Castro,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA,
	linux-usb-u79uwXL29TY76Z2rM5mHXA

On 07.11.2017 13:00, Biju Das wrote:
> Hi Mathias,
> 
> Does this patch look okay to you?
> 

Yes, Adding to queue, Will send out after rc1

Thanks
-Mathias

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 1/2] dt-bindings: usb-xhci: Document r8a7743 support
@ 2017-11-07 13:32               ` Mathias Nyman
  0 siblings, 0 replies; 16+ messages in thread
From: Mathias Nyman @ 2017-11-07 13:32 UTC (permalink / raw)
  To: Biju Das, Yoshihiro Shimoda, Greg Kroah-Hartman, Felipe Balbi,
	Rob Herring, Mark Rutland, Mathias Nyman
  Cc: Simon Horman, Magnus Damm, Chris Paterson, Fabrizio Castro,
	devicetree, linux-renesas-soc, linux-usb

On 07.11.2017 13:00, Biju Das wrote:
> Hi Mathias,
> 
> Does this patch look okay to you?
> 

Yes, Adding to queue, Will send out after rc1

Thanks
-Mathias

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2017-11-07 13:32 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-16 10:12 [PATCH 0/2] Add XHCI support Biju Das
     [not found] ` <1508148769-47488-1-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-10-16 10:12   ` [PATCH 1/2] dt-bindings: usb-xhci: Document r8a7743 support Biju Das
2017-10-16 10:12     ` Biju Das
     [not found]     ` <1508148769-47488-2-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-10-17  1:33       ` Yoshihiro Shimoda
2017-10-17  1:33         ` Yoshihiro Shimoda
2017-11-07 11:00         ` Biju Das
     [not found]           ` <KL1PR06MB1702D3E0C32610A0591A445FB8510-k6wCOA2IOKSx7cDWSRonpW0DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-11-07 13:32             ` Mathias Nyman
2017-11-07 13:32               ` Mathias Nyman
2017-10-17  7:54       ` Simon Horman
2017-10-17  7:54         ` Simon Horman
2017-10-16 10:12 ` [PATCH 2/2] ARM: dts: r8a7743: Add xhci support to SoC dtsi Biju Das
     [not found]   ` <1508148769-47488-3-git-send-email-biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2017-10-17  1:39     ` Yoshihiro Shimoda
2017-10-17  1:39       ` Yoshihiro Shimoda
2017-10-17  8:27       ` Biju Das
     [not found]       ` <TY1PR06MB0992D251A9DB8DB83E7099C9D84C0-/PRLmSCtZ16WJvbLRFYGcG0DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-10-18  5:22         ` Simon Horman
2017-10-18  5:22           ` Simon Horman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.