[PATCH igt] igt/pm_rc6_residency: Allow some leeway on the upper %% bound

[PATCH igt] igt/pm_rc6_residency: Allow some leeway on the upper %% bound

[Chris Wilson]

As we use rounding when converting from hw clocks to time, we may report
a residency greater than wallclock (by a small margin), so allow us to
overshoot by 5% (just due to our inaccuracy).

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/pm_rc6_residency.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/pm_rc6_residency.c b/tests/pm_rc6_residency.c
index d6fc4701..520d3b54 100644
--- a/tests/pm_rc6_residency.c
+++ b/tests/pm_rc6_residency.c
@@ -79,9 +79,9 @@ static void residency_accuracy(unsigned int diff,
 
 	ratio = (double)diff / duration;
 
-	igt_info("Residency in %s or deeper state: %u ms (sleep duration %u ms) (ratio to expected duration: %.02f)\n",
-		 name_of_rc6_residency, diff, duration, ratio);
-	igt_assert_f(ratio > 0.9 && ratio <= 1,
+	igt_info("Residency in %s or deeper state: %u ms (sleep duration %u ms) (%.1f%% of expected duration)\n",
+		 name_of_rc6_residency, diff, duration, 100*ratio);
+	igt_assert_f(ratio > 0.9 && ratio <= 1.05,
 		     "Sysfs RC6 residency counter is inaccurate.\n");
 }
 
-- 
2.15.0.rc1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH igt] igt/pm_rc6_residency: Allow some leeway on the upper %% bound

[Sagar Arun Kamble]

On 10/17/2017 3:51 PM, Chris Wilson wrote:
> As we use rounding when converting from hw clocks to time, we may report
> a residency greater than wallclock (by a small margin), so allow us to
> overshoot by 5% (just due to our inaccuracy).
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
> ---
>   tests/pm_rc6_residency.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/pm_rc6_residency.c b/tests/pm_rc6_residency.c
> index d6fc4701..520d3b54 100644
> --- a/tests/pm_rc6_residency.c
> +++ b/tests/pm_rc6_residency.c
> @@ -79,9 +79,9 @@ static void residency_accuracy(unsigned int diff,
>   
>   	ratio = (double)diff / duration;
>   
> -	igt_info("Residency in %s or deeper state: %u ms (sleep duration %u ms) (ratio to expected duration: %.02f)\n",
> -		 name_of_rc6_residency, diff, duration, ratio);
> -	igt_assert_f(ratio > 0.9 && ratio <= 1,
> +	igt_info("Residency in %s or deeper state: %u ms (sleep duration %u ms) (%.1f%% of expected duration)\n",
> +		 name_of_rc6_residency, diff, duration, 100*ratio);
> +	igt_assert_f(ratio > 0.9 && ratio <= 1.05,
>   		     "Sysfs RC6 residency counter is inaccurate.\n");
>   }
>   

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.BAT: failure for igt/pm_rc6_residency: Allow some leeway on the upper %% bound

[Patchwork]

== Series Details ==

Series: igt/pm_rc6_residency: Allow some leeway on the upper %% bound
URL   : https://patchwork.freedesktop.org/series/32112/
State : failure

== Summary ==

IGT patchset tested on top of latest successful build
6853f8bad8ce5770d28a621a7e15449930d56d9f lib/i915: Extract context priority setparam to a helper

with latest DRM-Tip kernel build CI_DRM_3252
e4dedb9e7c81 drm-tip: 2017y-10m-17d-07h-45m-57s UTC integration manifest

No testlist changes.

Test gem_exec_reloc:
        Subgroup basic-cpu-gtt-active:
                pass       -> FAIL       (fi-gdg-551) fdo#102582 +2
Test kms_cursor_legacy:
        Subgroup basic-busy-flip-before-cursor-legacy:
                pass       -> FAIL       (fi-gdg-551) fdo#102618
Test kms_pipe_crc_basic:
        Subgroup suspend-read-crc-pipe-a:
                pass       -> INCOMPLETE (fi-elk-e7500)

fdo#102582 https://bugs.freedesktop.org/show_bug.cgi?id=102582
fdo#102618 https://bugs.freedesktop.org/show_bug.cgi?id=102618

fi-bdw-5557u     total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:439s
fi-bdw-gvtdvm    total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:453s
fi-blb-e6850     total:289  pass:223  dwarn:1   dfail:0   fail:0   skip:65  time:373s
fi-bsw-n3050     total:289  pass:243  dwarn:0   dfail:0   fail:0   skip:46  time:531s
fi-bwr-2160      total:289  pass:183  dwarn:0   dfail:0   fail:0   skip:106 time:263s
fi-bxt-dsi       total:289  pass:259  dwarn:0   dfail:0   fail:0   skip:30  time:507s
fi-bxt-j4205     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:501s
fi-byt-j1900     total:289  pass:253  dwarn:1   dfail:0   fail:0   skip:35  time:492s
fi-byt-n2820     total:289  pass:249  dwarn:1   dfail:0   fail:0   skip:39  time:479s
fi-cfl-s         total:289  pass:253  dwarn:4   dfail:0   fail:0   skip:32  time:563s
fi-elk-e7500     total:245  pass:192  dwarn:0   dfail:0   fail:0   skip:52 
fi-gdg-551       total:289  pass:174  dwarn:1   dfail:0   fail:5   skip:109 time:259s
fi-glk-1         total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:585s
fi-hsw-4770r     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:426s
fi-ilk-650       total:289  pass:228  dwarn:0   dfail:0   fail:0   skip:61  time:430s
fi-ivb-3520m     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:488s
fi-ivb-3770      total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:466s
fi-kbl-7500u     total:289  pass:264  dwarn:1   dfail:0   fail:0   skip:24  time:488s
fi-kbl-7560u     total:289  pass:270  dwarn:0   dfail:0   fail:0   skip:19  time:566s
fi-kbl-7567u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:473s
fi-kbl-r         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:588s
fi-pnv-d510      total:289  pass:222  dwarn:1   dfail:0   fail:0   skip:66  time:544s
fi-skl-6260u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:443s
fi-skl-6700hq    total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:645s
fi-skl-6700k     total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:510s
fi-skl-6770hq    total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:497s
fi-skl-gvtdvm    total:289  pass:266  dwarn:0   dfail:0   fail:0   skip:23  time:459s
fi-snb-2520m     total:289  pass:250  dwarn:0   dfail:0   fail:0   skip:39  time:564s
fi-snb-2600      total:289  pass:249  dwarn:0   dfail:0   fail:0   skip:40  time:420s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_368/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.BAT: failure for igt/pm_rc6_residency: Allow some leeway on the upper %% bound

[Patchwork]

== Series Details ==

Series: igt/pm_rc6_residency: Allow some leeway on the upper %% bound
URL   : https://patchwork.freedesktop.org/series/32112/
State : failure

== Summary ==

Series 32112 revision 1 was fully merged or fully failed: no git log

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_368/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx