From: Vlastimil Babka <vbabka@suse.cz> To: Andrew Morton <akpm@linux-foundation.org> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mel Gorman <mgorman@techsingularity.net>, Johannes Weiner <hannes@cmpxchg.org>, Michal Hocko <mhocko@kernel.org>, Vlastimil Babka <vbabka@suse.cz> Subject: [PATCH] mm, page_alloc: simplify hot/cold page handling in rmqueue_bulk() Date: Wed, 18 Oct 2017 09:35:28 +0200 [thread overview] Message-ID: <20171018073528.30982-1-vbabka@suse.cz> (raw) The rmqueue_bulk() function fills an empty pcplist with pages from the free list. It tries to preserve increasing order by pfn to the caller, because it leads to better performance with some I/O controllers, as explained in e084b2d95e48 ("page-allocator: preserve PFN ordering when __GFP_COLD is set"). For callers requesting cold pages, which are obtained from the tail of pcplists, it means the pcplist has to be filled in reverse order from the free lists (the hot/cold property only applies when pages are recycled on the pcplists, not when refilled from free lists). The related comment in rmqueue_bulk() wasn't clear to me without reading the log of the commit mentioned above, so try to clarify it. The code for filling the pcplists in order determined by the cold flag also seems unnecessarily hard to follow. It's sufficient to either use list_add() or list_add_tail(), but the current code also updates the list head pointer in each step to the last added page, which then counterintuitively requires to switch the usage of list_add() and list_add_tail() to achieve the desired order, with no apparent benefit. This patch simplifies the code. Signed-off-by: Vlastimil Babka <vbabka@suse.cz> --- mm/page_alloc.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 6191c9a04789..4b296fc8e599 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -2329,19 +2329,18 @@ static int rmqueue_bulk(struct zone *zone, unsigned int order, continue; /* - * Split buddy pages returned by expand() are received here - * in physical page order. The page is added to the callers and - * list and the list head then moves forward. From the callers - * perspective, the linked list is ordered by page number in - * some conditions. This is useful for IO devices that can - * merge IO requests if the physical pages are ordered + * Split buddy pages returned by expand() are received here in + * physical page order. The page is added to the caller's list. + * From the callers perspective, make sure the pages will be + * consumed in the order as returned by expand(), regardless of + * cold being true or false. This is useful for IO devices that + * can merge IO requests if the physical pages are ordered * properly. */ if (likely(!cold)) - list_add(&page->lru, list); - else list_add_tail(&page->lru, list); - list = &page->lru; + else + list_add(&page->lru, list); alloced++; if (is_migrate_cma(get_pcppage_migratetype(page))) __mod_zone_page_state(zone, NR_FREE_CMA_PAGES, -- 2.14.2
WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz> To: Andrew Morton <akpm@linux-foundation.org> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mel Gorman <mgorman@techsingularity.net>, Johannes Weiner <hannes@cmpxchg.org>, Michal Hocko <mhocko@kernel.org>, Vlastimil Babka <vbabka@suse.cz> Subject: [PATCH] mm, page_alloc: simplify hot/cold page handling in rmqueue_bulk() Date: Wed, 18 Oct 2017 09:35:28 +0200 [thread overview] Message-ID: <20171018073528.30982-1-vbabka@suse.cz> (raw) The rmqueue_bulk() function fills an empty pcplist with pages from the free list. It tries to preserve increasing order by pfn to the caller, because it leads to better performance with some I/O controllers, as explained in e084b2d95e48 ("page-allocator: preserve PFN ordering when __GFP_COLD is set"). For callers requesting cold pages, which are obtained from the tail of pcplists, it means the pcplist has to be filled in reverse order from the free lists (the hot/cold property only applies when pages are recycled on the pcplists, not when refilled from free lists). The related comment in rmqueue_bulk() wasn't clear to me without reading the log of the commit mentioned above, so try to clarify it. The code for filling the pcplists in order determined by the cold flag also seems unnecessarily hard to follow. It's sufficient to either use list_add() or list_add_tail(), but the current code also updates the list head pointer in each step to the last added page, which then counterintuitively requires to switch the usage of list_add() and list_add_tail() to achieve the desired order, with no apparent benefit. This patch simplifies the code. Signed-off-by: Vlastimil Babka <vbabka@suse.cz> --- mm/page_alloc.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 6191c9a04789..4b296fc8e599 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -2329,19 +2329,18 @@ static int rmqueue_bulk(struct zone *zone, unsigned int order, continue; /* - * Split buddy pages returned by expand() are received here - * in physical page order. The page is added to the callers and - * list and the list head then moves forward. From the callers - * perspective, the linked list is ordered by page number in - * some conditions. This is useful for IO devices that can - * merge IO requests if the physical pages are ordered + * Split buddy pages returned by expand() are received here in + * physical page order. The page is added to the caller's list. + * From the callers perspective, make sure the pages will be + * consumed in the order as returned by expand(), regardless of + * cold being true or false. This is useful for IO devices that + * can merge IO requests if the physical pages are ordered * properly. */ if (likely(!cold)) - list_add(&page->lru, list); - else list_add_tail(&page->lru, list); - list = &page->lru; + else + list_add(&page->lru, list); alloced++; if (is_migrate_cma(get_pcppage_migratetype(page))) __mod_zone_page_state(zone, NR_FREE_CMA_PAGES, -- 2.14.2 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2017-10-18 7:36 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-18 7:35 Vlastimil Babka [this message] 2017-10-18 7:35 ` [PATCH] mm, page_alloc: simplify hot/cold page handling in rmqueue_bulk() Vlastimil Babka 2017-10-18 8:06 ` Mel Gorman 2017-10-18 8:06 ` Mel Gorman 2017-10-18 8:38 ` Vlastimil Babka 2017-10-18 8:38 ` Vlastimil Babka
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171018073528.30982-1-vbabka@suse.cz \ --to=vbabka@suse.cz \ --cc=akpm@linux-foundation.org \ --cc=hannes@cmpxchg.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@techsingularity.net \ --cc=mhocko@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.