From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Khuong Dinh <kdinh@apm.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>,
msalter@redhat.com, Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, jcm@redhat.com,
patches <patches@apm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, rjw@rjwysocki.net
Subject: Re: [PATCH v4 pci 0/2] PCI/MSI: pci-xgene-msi: Enable MSI support in ACPI boot for X-Gene v1
Date: Wed, 18 Oct 2017 10:07:16 +0100 [thread overview]
Message-ID: <20171018090716.GA14820@red-moon> (raw)
In-Reply-To: <CAAsHzqsxMy8On5ThggTwYohqMCLEJTbA=b1LgUPiuKu9C+eHeQ@mail.gmail.com>
On Tue, Oct 17, 2017 at 10:45:35PM -0700, Khuong Dinh wrote:
> Hi Lorenzo,
>
> On Tue, Oct 17, 2017 at 6:38 AM, Lorenzo Pieralisi
> <lorenzo.pieralisi@arm.com> wrote:
> > Hi Khuong,
> >
> > On Mon, Oct 16, 2017 at 02:19:50PM -0700, Khuong Dinh wrote:
> >> Hi Lorenzo,
> >> Do you have any comments for this patch?
> >
> > I'd have some comments but given that there are related issues with ACPI
> > probe ordering that Marc is trying to solve on his side - I will work
> > with him to see if we can accommodate changes that can solve this issue
> > too.
> >
> > Again - I recognize it is a complex problem (that is not even
> > contemplated by the current ACPI specs), we have to try to make
> > the solution as generic as we can to prevent reinventing the wheel
> > anytime a sligthly different issue (related to ACPI probe ordering)
> > comes up.
> >
> > Leave it to me (us) and I will get back to you on this.
>
> Thanks for helping to take care of the generic ACPI probe ordering issue.
> Given that the patch 'PCI/MSI: pci-xgene-msi: Enable MSI support in ACPI
> boot for X-Gene v1" adds only the ACPI ID, can you pull in this patch
> independently from the ACPI probe ordering issue?
No. For two reasons:
1) It's Bjorn who decides whether that code can be merged or not, not
me
2) That patch sneaks in ACPI MSI support for X-gene v1 that depends
on kernel link ordering. As soon as it is pulled in the mainline
it creates a dependency on pseudo-working code that may break
anytime and as I said many times before I am not willing to rely
on that.
Lorenzo
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Khuong Dinh <kdinh@apm.com>
Cc: rjw@rjwysocki.net, Marc Zyngier <marc.zyngier@arm.com>,
linux-pci@vger.kernel.org, msalter@redhat.com,
patches <patches@apm.com>,
linux-kernel@vger.kernel.org, jcm@redhat.com,
Bjorn Helgaas <bhelgaas@google.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 pci 0/2] PCI/MSI: pci-xgene-msi: Enable MSI support in ACPI boot for X-Gene v1
Date: Wed, 18 Oct 2017 10:07:16 +0100 [thread overview]
Message-ID: <20171018090716.GA14820@red-moon> (raw)
In-Reply-To: <CAAsHzqsxMy8On5ThggTwYohqMCLEJTbA=b1LgUPiuKu9C+eHeQ@mail.gmail.com>
On Tue, Oct 17, 2017 at 10:45:35PM -0700, Khuong Dinh wrote:
> Hi Lorenzo,
>
> On Tue, Oct 17, 2017 at 6:38 AM, Lorenzo Pieralisi
> <lorenzo.pieralisi@arm.com> wrote:
> > Hi Khuong,
> >
> > On Mon, Oct 16, 2017 at 02:19:50PM -0700, Khuong Dinh wrote:
> >> Hi Lorenzo,
> >> Do you have any comments for this patch?
> >
> > I'd have some comments but given that there are related issues with ACPI
> > probe ordering that Marc is trying to solve on his side - I will work
> > with him to see if we can accommodate changes that can solve this issue
> > too.
> >
> > Again - I recognize it is a complex problem (that is not even
> > contemplated by the current ACPI specs), we have to try to make
> > the solution as generic as we can to prevent reinventing the wheel
> > anytime a sligthly different issue (related to ACPI probe ordering)
> > comes up.
> >
> > Leave it to me (us) and I will get back to you on this.
>
> Thanks for helping to take care of the generic ACPI probe ordering issue.
> Given that the patch 'PCI/MSI: pci-xgene-msi: Enable MSI support in ACPI
> boot for X-Gene v1" adds only the ACPI ID, can you pull in this patch
> independently from the ACPI probe ordering issue?
No. For two reasons:
1) It's Bjorn who decides whether that code can be merged or not, not
me
2) That patch sneaks in ACPI MSI support for X-gene v1 that depends
on kernel link ordering. As soon as it is pulled in the mainline
it creates a dependency on pseudo-working code that may break
anytime and as I said many times before I am not willing to rely
on that.
Lorenzo
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 pci 0/2] PCI/MSI: pci-xgene-msi: Enable MSI support in ACPI boot for X-Gene v1
Date: Wed, 18 Oct 2017 10:07:16 +0100 [thread overview]
Message-ID: <20171018090716.GA14820@red-moon> (raw)
In-Reply-To: <CAAsHzqsxMy8On5ThggTwYohqMCLEJTbA=b1LgUPiuKu9C+eHeQ@mail.gmail.com>
On Tue, Oct 17, 2017 at 10:45:35PM -0700, Khuong Dinh wrote:
> Hi Lorenzo,
>
> On Tue, Oct 17, 2017 at 6:38 AM, Lorenzo Pieralisi
> <lorenzo.pieralisi@arm.com> wrote:
> > Hi Khuong,
> >
> > On Mon, Oct 16, 2017 at 02:19:50PM -0700, Khuong Dinh wrote:
> >> Hi Lorenzo,
> >> Do you have any comments for this patch?
> >
> > I'd have some comments but given that there are related issues with ACPI
> > probe ordering that Marc is trying to solve on his side - I will work
> > with him to see if we can accommodate changes that can solve this issue
> > too.
> >
> > Again - I recognize it is a complex problem (that is not even
> > contemplated by the current ACPI specs), we have to try to make
> > the solution as generic as we can to prevent reinventing the wheel
> > anytime a sligthly different issue (related to ACPI probe ordering)
> > comes up.
> >
> > Leave it to me (us) and I will get back to you on this.
>
> Thanks for helping to take care of the generic ACPI probe ordering issue.
> Given that the patch 'PCI/MSI: pci-xgene-msi: Enable MSI support in ACPI
> boot for X-Gene v1" adds only the ACPI ID, can you pull in this patch
> independently from the ACPI probe ordering issue?
No. For two reasons:
1) It's Bjorn who decides whether that code can be merged or not, not
me
2) That patch sneaks in ACPI MSI support for X-gene v1 that depends
on kernel link ordering. As soon as it is pulled in the mainline
it creates a dependency on pseudo-working code that may break
anytime and as I said many times before I am not willing to rely
on that.
Lorenzo
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
next prev parent reply other threads:[~2017-10-18 9:07 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 17:49 [PATCH v4 pci 0/2] PCI/MSI: pci-xgene-msi: Enable MSI support in ACPI boot for X-Gene v1 Khuong Dinh
2017-09-26 17:49 ` Khuong Dinh
2017-09-26 17:49 ` Khuong Dinh
2017-09-26 17:49 ` [PATCH v4 pci 1/2] " Khuong Dinh
2017-09-26 17:49 ` Khuong Dinh
2017-09-26 17:49 ` Khuong Dinh
2017-09-26 17:49 ` [PATCH v4 pci 2/2] PCI/MSI: Enforce MSI driver loaded before PCIe in ACPI boot Khuong Dinh
2017-09-26 17:49 ` Khuong Dinh
2017-09-26 17:49 ` Khuong Dinh
2017-10-16 21:19 ` [PATCH v4 pci 0/2] PCI/MSI: pci-xgene-msi: Enable MSI support in ACPI boot for X-Gene v1 Khuong Dinh
2017-10-16 21:19 ` Khuong Dinh
2017-10-16 21:19 ` Khuong Dinh
2017-10-17 13:38 ` Lorenzo Pieralisi
2017-10-17 13:38 ` Lorenzo Pieralisi
2017-10-17 13:38 ` Lorenzo Pieralisi
2017-10-18 5:45 ` Khuong Dinh
2017-10-18 5:45 ` Khuong Dinh
2017-10-18 5:45 ` Khuong Dinh
2017-10-18 9:07 ` Lorenzo Pieralisi [this message]
2017-10-18 9:07 ` Lorenzo Pieralisi
2017-10-18 9:07 ` Lorenzo Pieralisi
2017-10-18 9:26 ` Lorenzo Pieralisi
2017-10-18 9:26 ` Lorenzo Pieralisi
2017-10-18 9:26 ` Lorenzo Pieralisi
2017-10-18 21:43 ` Khuong Dinh
2017-10-18 21:43 ` Khuong Dinh
2017-10-18 21:43 ` Khuong Dinh
2017-10-17 17:05 ` Bjorn Helgaas
2017-10-17 17:05 ` Bjorn Helgaas
2017-10-17 17:05 ` Bjorn Helgaas
2017-10-17 17:33 ` Jon Masters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018090716.GA14820@red-moon \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=jcm@redhat.com \
--cc=kdinh@apm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=msalter@redhat.com \
--cc=patches@apm.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.