Re: [PATCH 1/2] [media] rc/keymaps: add support for RC of hisilicon TV demo boards

Re: [PATCH 1/2] [media] rc/keymaps: add support for RC of hisilicon TV demo boards

[Sean Young]

On Wed, Oct 18, 2017 at 06:54:56AM -0400, Jiancheng Xue wrote:
> From: Younian Wang <wangyounian@hisilicon.com>
> 
> This is a NEC protocol type remote controller distributed with
> hisilicon TV demo boards.
> 
> Signed-off-by: Younian Wang <wangyounian@hisilicon.com>
> Signed-off-by: Jiancheng Xue <xuejiancheng@hisilicon.com>
> ---
>  drivers/media/rc/keymaps/Makefile          |  1 +
>  drivers/media/rc/keymaps/rc-hisi-tv-demo.c | 70 ++++++++++++++++++++++++++++++
>  2 files changed, 71 insertions(+)
>  create mode 100644 drivers/media/rc/keymaps/rc-hisi-tv-demo.c
> 
> diff --git a/drivers/media/rc/keymaps/Makefile b/drivers/media/rc/keymaps/Makefile
> index af6496d..83ec9c3 100644
> --- a/drivers/media/rc/keymaps/Makefile
> +++ b/drivers/media/rc/keymaps/Makefile
> @@ -47,6 +47,7 @@ obj-$(CONFIG_RC_MAP) += rc-adstech-dvb-t-pci.o \
>  			rc-geekbox.o \
>  			rc-genius-tvgo-a11mce.o \
>  			rc-gotview7135.o \
> +			rc-hisi-tv-demo.o \
>  			rc-imon-mce.o \
>  			rc-imon-pad.o \
>  			rc-iodata-bctv7e.o \
> diff --git a/drivers/media/rc/keymaps/rc-hisi-tv-demo.c b/drivers/media/rc/keymaps/rc-hisi-tv-demo.c
> new file mode 100644
> index 0000000..410b17d
> --- /dev/null
> +++ b/drivers/media/rc/keymaps/rc-hisi-tv-demo.c
> @@ -0,0 +1,70 @@
> +#include <linux/module.h>
> +#include <media/rc-map.h>

Both keymaps are missing a copyright statement at the top of the c files.

Thanks
Sean

> +
> +static struct rc_map_table hisi_tv_demo_keymap[] = {
> +	{ 0x00000092, KEY_1},
> +	{ 0x00000093, KEY_2},
> +	{ 0x000000cc, KEY_3},
> +	{ 0x0000009f, KEY_4},
> +	{ 0x0000008e, KEY_5},
> +	{ 0x0000008f, KEY_6},
> +	{ 0x000000c8, KEY_7},
> +	{ 0x00000094, KEY_8},
> +	{ 0x0000008a, KEY_9},
> +	{ 0x0000008b, KEY_0},
> +	{ 0x000000ce, KEY_ENTER},
> +	{ 0x000000ca, KEY_UP},
> +	{ 0x00000099, KEY_LEFT},
> +	{ 0x00000084, KEY_PAGEUP},
> +	{ 0x000000c1, KEY_RIGHT},
> +	{ 0x000000d2, KEY_DOWN},
> +	{ 0x00000089, KEY_PAGEDOWN},
> +	{ 0x000000d1, KEY_MUTE},
> +	{ 0x00000098, KEY_VOLUMEDOWN},
> +	{ 0x00000090, KEY_VOLUMEUP},
> +	{ 0x0000009c, KEY_POWER},
> +	{ 0x000000d6, KEY_STOP},
> +	{ 0x00000097, KEY_MENU},
> +	{ 0x000000cb, KEY_BACK},
> +	{ 0x000000da, KEY_PLAYPAUSE},
> +	{ 0x00000080, KEY_INFO},
> +	{ 0x000000c3, KEY_REWIND},
> +	{ 0x00000087, KEY_HOMEPAGE},
> +	{ 0x000000d0, KEY_FASTFORWARD},
> +	{ 0x000000c4, KEY_SOUND},
> +	{ 0x00000082, BTN_1},
> +	{ 0x000000c7, BTN_2},
> +	{ 0x00000086, KEY_PROGRAM},
> +	{ 0x000000d9, KEY_SUBTITLE},
> +	{ 0x00000085, KEY_ZOOM},
> +	{ 0x0000009b, KEY_RED},
> +	{ 0x0000009a, KEY_GREEN},
> +	{ 0x000000c0, KEY_YELLOW},
> +	{ 0x000000c2, KEY_BLUE},
> +	{ 0x0000009d, KEY_CHANNELDOWN},
> +	{ 0x000000cf, KEY_CHANNELUP},
> +};
> +
> +static struct rc_map_list hisi_tv_demo_map = {
> +	.map = {
> +		.scan	  = hisi_tv_demo_keymap,
> +		.size	  = ARRAY_SIZE(hisi_tv_demo_keymap),
> +		.rc_proto = RC_PROTO_NEC,
> +		.name	  = "rc-hisi-demo",
> +	}
> +};
> +
> +static int __init init_rc_map_hisi_tv_demo(void)
> +{
> +	return rc_map_register(&hisi_tv_demo_map);
> +}
> +
> +static void __exit exit_rc_map_hisi_tv_demo(void)
> +{
> +	rc_map_unregister(&hisi_tv_demo_map);
> +}
> +
> +module_init(init_rc_map_hisi_tv_demo)
> +module_exit(exit_rc_map_hisi_tv_demo)
> +
> +MODULE_LICENSE("GPL v2");
> -- 
> 2.7.4

Re: [PATCH 1/2] [media] rc/keymaps: add support for RC of hisilicon TV demo boards

[Jiancheng Xue]

Hi,

On 2017/10/18 17:31, Sean Young wrote:
> On Wed, Oct 18, 2017 at 06:54:56AM -0400, Jiancheng Xue wrote:
>> From: Younian Wang <wangyounian@hisilicon.com>
>>
>> This is a NEC protocol type remote controller distributed with
>> hisilicon TV demo boards.
>>
>> Signed-off-by: Younian Wang <wangyounian@hisilicon.com>
>> Signed-off-by: Jiancheng Xue <xuejiancheng@hisilicon.com>
>> ---
>>  drivers/media/rc/keymaps/Makefile          |  1 +
>>  drivers/media/rc/keymaps/rc-hisi-tv-demo.c | 70 ++++++++++++++++++++++++++++++
>>  2 files changed, 71 insertions(+)
>>  create mode 100644 drivers/media/rc/keymaps/rc-hisi-tv-demo.c
>>
>> diff --git a/drivers/media/rc/keymaps/Makefile b/drivers/media/rc/keymaps/Makefile
>> index af6496d..83ec9c3 100644
>> --- a/drivers/media/rc/keymaps/Makefile
>> +++ b/drivers/media/rc/keymaps/Makefile
>> @@ -47,6 +47,7 @@ obj-$(CONFIG_RC_MAP) += rc-adstech-dvb-t-pci.o \
>>  			rc-geekbox.o \
>>  			rc-genius-tvgo-a11mce.o \
>>  			rc-gotview7135.o \
>> +			rc-hisi-tv-demo.o \
>>  			rc-imon-mce.o \
>>  			rc-imon-pad.o \
>>  			rc-iodata-bctv7e.o \
>> diff --git a/drivers/media/rc/keymaps/rc-hisi-tv-demo.c b/drivers/media/rc/keymaps/rc-hisi-tv-demo.c
>> new file mode 100644
>> index 0000000..410b17d
>> --- /dev/null
>> +++ b/drivers/media/rc/keymaps/rc-hisi-tv-demo.c
>> @@ -0,0 +1,70 @@
>> +#include <linux/module.h>
>> +#include <media/rc-map.h>
> 
> Both keymaps are missing a copyright statement at the top of the c files.
> 

Oh. I will add the copyright in next version. Thank you very much.

Regards,
Jiancheng

> Thanks
> Sean
> 
>> +
>> +static struct rc_map_table hisi_tv_demo_keymap[] = {
>> +	{ 0x00000092, KEY_1},
>> +	{ 0x00000093, KEY_2},
>> +	{ 0x000000cc, KEY_3},
>> +	{ 0x0000009f, KEY_4},
>> +	{ 0x0000008e, KEY_5},
>> +	{ 0x0000008f, KEY_6},
>> +	{ 0x000000c8, KEY_7},
>> +	{ 0x00000094, KEY_8},
>> +	{ 0x0000008a, KEY_9},
>> +	{ 0x0000008b, KEY_0},
>> +	{ 0x000000ce, KEY_ENTER},
>> +	{ 0x000000ca, KEY_UP},
>> +	{ 0x00000099, KEY_LEFT},
>> +	{ 0x00000084, KEY_PAGEUP},
>> +	{ 0x000000c1, KEY_RIGHT},
>> +	{ 0x000000d2, KEY_DOWN},
>> +	{ 0x00000089, KEY_PAGEDOWN},
>> +	{ 0x000000d1, KEY_MUTE},
>> +	{ 0x00000098, KEY_VOLUMEDOWN},
>> +	{ 0x00000090, KEY_VOLUMEUP},
>> +	{ 0x0000009c, KEY_POWER},
>> +	{ 0x000000d6, KEY_STOP},
>> +	{ 0x00000097, KEY_MENU},
>> +	{ 0x000000cb, KEY_BACK},
>> +	{ 0x000000da, KEY_PLAYPAUSE},
>> +	{ 0x00000080, KEY_INFO},
>> +	{ 0x000000c3, KEY_REWIND},
>> +	{ 0x00000087, KEY_HOMEPAGE},
>> +	{ 0x000000d0, KEY_FASTFORWARD},
>> +	{ 0x000000c4, KEY_SOUND},
>> +	{ 0x00000082, BTN_1},
>> +	{ 0x000000c7, BTN_2},
>> +	{ 0x00000086, KEY_PROGRAM},
>> +	{ 0x000000d9, KEY_SUBTITLE},
>> +	{ 0x00000085, KEY_ZOOM},
>> +	{ 0x0000009b, KEY_RED},
>> +	{ 0x0000009a, KEY_GREEN},
>> +	{ 0x000000c0, KEY_YELLOW},
>> +	{ 0x000000c2, KEY_BLUE},
>> +	{ 0x0000009d, KEY_CHANNELDOWN},
>> +	{ 0x000000cf, KEY_CHANNELUP},
>> +};
>> +
>> +static struct rc_map_list hisi_tv_demo_map = {
>> +	.map = {
>> +		.scan	  = hisi_tv_demo_keymap,
>> +		.size	  = ARRAY_SIZE(hisi_tv_demo_keymap),
>> +		.rc_proto = RC_PROTO_NEC,
>> +		.name	  = "rc-hisi-demo",
>> +	}
>> +};
>> +
>> +static int __init init_rc_map_hisi_tv_demo(void)
>> +{
>> +	return rc_map_register(&hisi_tv_demo_map);
>> +}
>> +
>> +static void __exit exit_rc_map_hisi_tv_demo(void)
>> +{
>> +	rc_map_unregister(&hisi_tv_demo_map);
>> +}
>> +
>> +module_init(init_rc_map_hisi_tv_demo)
>> +module_exit(exit_rc_map_hisi_tv_demo)
>> +
>> +MODULE_LICENSE("GPL v2");
>> -- 
>> 2.7.4
> 
> .
> 

[PATCH 0/2] [media] rc/keymaps: add support for two RCs of hisilicon boards.

[Jiancheng Xue]

Add support for two remote controllers of hisilicon boards.

Younian Wang (2):
  [media] rc/keymaps: add support for RC of hisilicon TV demo boards
  [media] rc/keymaps: add support for RC of hisilicon poplar board

 drivers/media/rc/keymaps/Makefile          |  2 +
 drivers/media/rc/keymaps/rc-hisi-poplar.c  | 58 +++++++++++++++++++++++++
 drivers/media/rc/keymaps/rc-hisi-tv-demo.c | 70 ++++++++++++++++++++++++++++++
 3 files changed, 130 insertions(+)
 create mode 100644 drivers/media/rc/keymaps/rc-hisi-poplar.c
 create mode 100644 drivers/media/rc/keymaps/rc-hisi-tv-demo.c

-- 
2.7.4

[PATCH 1/2] [media] rc/keymaps: add support for RC of hisilicon TV demo boards

[Jiancheng Xue]

From: Younian Wang <wangyounian@hisilicon.com>

This is a NEC protocol type remote controller distributed with
hisilicon TV demo boards.

Signed-off-by: Younian Wang <wangyounian@hisilicon.com>
Signed-off-by: Jiancheng Xue <xuejiancheng@hisilicon.com>
---
 drivers/media/rc/keymaps/Makefile          |  1 +
 drivers/media/rc/keymaps/rc-hisi-tv-demo.c | 70 ++++++++++++++++++++++++++++++
 2 files changed, 71 insertions(+)
 create mode 100644 drivers/media/rc/keymaps/rc-hisi-tv-demo.c

diff --git a/drivers/media/rc/keymaps/Makefile b/drivers/media/rc/keymaps/Makefile
index af6496d..83ec9c3 100644
--- a/drivers/media/rc/keymaps/Makefile
+++ b/drivers/media/rc/keymaps/Makefile
@@ -47,6 +47,7 @@ obj-$(CONFIG_RC_MAP) += rc-adstech-dvb-t-pci.o \
 			rc-geekbox.o \
 			rc-genius-tvgo-a11mce.o \
 			rc-gotview7135.o \
+			rc-hisi-tv-demo.o \
 			rc-imon-mce.o \
 			rc-imon-pad.o \
 			rc-iodata-bctv7e.o \
diff --git a/drivers/media/rc/keymaps/rc-hisi-tv-demo.c b/drivers/media/rc/keymaps/rc-hisi-tv-demo.c
new file mode 100644
index 0000000..410b17d
--- /dev/null
+++ b/drivers/media/rc/keymaps/rc-hisi-tv-demo.c
@@ -0,0 +1,70 @@
+#include <linux/module.h>
+#include <media/rc-map.h>
+
+static struct rc_map_table hisi_tv_demo_keymap[] = {
+	{ 0x00000092, KEY_1},
+	{ 0x00000093, KEY_2},
+	{ 0x000000cc, KEY_3},
+	{ 0x0000009f, KEY_4},
+	{ 0x0000008e, KEY_5},
+	{ 0x0000008f, KEY_6},
+	{ 0x000000c8, KEY_7},
+	{ 0x00000094, KEY_8},
+	{ 0x0000008a, KEY_9},
+	{ 0x0000008b, KEY_0},
+	{ 0x000000ce, KEY_ENTER},
+	{ 0x000000ca, KEY_UP},
+	{ 0x00000099, KEY_LEFT},
+	{ 0x00000084, KEY_PAGEUP},
+	{ 0x000000c1, KEY_RIGHT},
+	{ 0x000000d2, KEY_DOWN},
+	{ 0x00000089, KEY_PAGEDOWN},
+	{ 0x000000d1, KEY_MUTE},
+	{ 0x00000098, KEY_VOLUMEDOWN},
+	{ 0x00000090, KEY_VOLUMEUP},
+	{ 0x0000009c, KEY_POWER},
+	{ 0x000000d6, KEY_STOP},
+	{ 0x00000097, KEY_MENU},
+	{ 0x000000cb, KEY_BACK},
+	{ 0x000000da, KEY_PLAYPAUSE},
+	{ 0x00000080, KEY_INFO},
+	{ 0x000000c3, KEY_REWIND},
+	{ 0x00000087, KEY_HOMEPAGE},
+	{ 0x000000d0, KEY_FASTFORWARD},
+	{ 0x000000c4, KEY_SOUND},
+	{ 0x00000082, BTN_1},
+	{ 0x000000c7, BTN_2},
+	{ 0x00000086, KEY_PROGRAM},
+	{ 0x000000d9, KEY_SUBTITLE},
+	{ 0x00000085, KEY_ZOOM},
+	{ 0x0000009b, KEY_RED},
+	{ 0x0000009a, KEY_GREEN},
+	{ 0x000000c0, KEY_YELLOW},
+	{ 0x000000c2, KEY_BLUE},
+	{ 0x0000009d, KEY_CHANNELDOWN},
+	{ 0x000000cf, KEY_CHANNELUP},
+};
+
+static struct rc_map_list hisi_tv_demo_map = {
+	.map = {
+		.scan	  = hisi_tv_demo_keymap,
+		.size	  = ARRAY_SIZE(hisi_tv_demo_keymap),
+		.rc_proto = RC_PROTO_NEC,
+		.name	  = "rc-hisi-demo",
+	}
+};
+
+static int __init init_rc_map_hisi_tv_demo(void)
+{
+	return rc_map_register(&hisi_tv_demo_map);
+}
+
+static void __exit exit_rc_map_hisi_tv_demo(void)
+{
+	rc_map_unregister(&hisi_tv_demo_map);
+}
+
+module_init(init_rc_map_hisi_tv_demo)
+module_exit(exit_rc_map_hisi_tv_demo)
+
+MODULE_LICENSE("GPL v2");
-- 
2.7.4

[PATCH 2/2] [media] rc/keymaps: add support for RC of hisilicon poplar board

[Jiancheng Xue]

From: Younian Wang <wangyounian@hisilicon.com>

This is a NEC protocol type remote controller distributed with
96boards poplar@tocoding board.

Signed-off-by: Younian Wang <wangyounian@hisilicon.com>
Signed-off-by: Jiancheng Xue <xuejiancheng@hisilicon.com>
---
 drivers/media/rc/keymaps/Makefile         |  1 +
 drivers/media/rc/keymaps/rc-hisi-poplar.c | 58 +++++++++++++++++++++++++++++++
 2 files changed, 59 insertions(+)
 create mode 100644 drivers/media/rc/keymaps/rc-hisi-poplar.c

diff --git a/drivers/media/rc/keymaps/Makefile b/drivers/media/rc/keymaps/Makefile
index 83ec9c3..8daabfc6 100644
--- a/drivers/media/rc/keymaps/Makefile
+++ b/drivers/media/rc/keymaps/Makefile
@@ -47,6 +47,7 @@ obj-$(CONFIG_RC_MAP) += rc-adstech-dvb-t-pci.o \
 			rc-geekbox.o \
 			rc-genius-tvgo-a11mce.o \
 			rc-gotview7135.o \
+			rc-hisi-poplar.o \
 			rc-hisi-tv-demo.o \
 			rc-imon-mce.o \
 			rc-imon-pad.o \
diff --git a/drivers/media/rc/keymaps/rc-hisi-poplar.c b/drivers/media/rc/keymaps/rc-hisi-poplar.c
new file mode 100644
index 0000000..730d556
--- /dev/null
+++ b/drivers/media/rc/keymaps/rc-hisi-poplar.c
@@ -0,0 +1,58 @@
+#include <linux/module.h>
+#include <media/rc-map.h>
+
+static struct rc_map_table hisi_poplar_keymap[] = {
+	{ 0x0000b292, KEY_1},
+	{ 0x0000b293, KEY_2},
+	{ 0x0000b2cc, KEY_3},
+	{ 0x0000b28e, KEY_4},
+	{ 0x0000b28f, KEY_5},
+	{ 0x0000b2c8, KEY_6},
+	{ 0x0000b28a, KEY_7},
+	{ 0x0000b28b, KEY_8},
+	{ 0x0000b2c4, KEY_9},
+	{ 0x0000b287, KEY_0},
+	{ 0x0000b282, KEY_HOMEPAGE},
+	{ 0x0000b2ca, KEY_UP},
+	{ 0x0000b299, KEY_LEFT},
+	{ 0x0000b2c1, KEY_RIGHT},
+	{ 0x0000b2d2, KEY_DOWN},
+	{ 0x0000b2c5, KEY_DELETE},
+	{ 0x0000b29c, KEY_MUTE},
+	{ 0x0000b281, KEY_VOLUMEDOWN},
+	{ 0x0000b280, KEY_VOLUMEUP},
+	{ 0x0000b2dc, KEY_POWER},
+	{ 0x0000b29a, KEY_MENU},
+	{ 0x0000b28d, KEY_SETUP},
+	{ 0x0000b2c5, KEY_BACK},
+	{ 0x0000b295, KEY_PLAYPAUSE},
+	{ 0x0000b2ce, KEY_ENTER},
+	{ 0x0000b285, KEY_CHANNELUP},
+	{ 0x0000b286, KEY_CHANNELDOWN},
+	{ 0x0000b2da, KEY_NUMERIC_STAR},
+	{ 0x0000b2d0, KEY_NUMERIC_POUND},
+};
+
+static struct rc_map_list hisi_poplar_map = {
+	.map = {
+		.scan	  = hisi_poplar_keymap,
+		.size	  = ARRAY_SIZE(hisi_poplar_keymap),
+		.rc_proto = RC_PROTO_NEC,
+		.name	  = "rc-hisi-poplar",
+	}
+};
+
+static int __init init_rc_map_hisi_poplar(void)
+{
+	return rc_map_register(&hisi_poplar_map);
+}
+
+static void __exit exit_rc_map_hisi_poplar(void)
+{
+	rc_map_unregister(&hisi_poplar_map);
+}
+
+module_init(init_rc_map_hisi_poplar)
+module_exit(exit_rc_map_hisi_poplar)
+
+MODULE_LICENSE("GPL v2");
-- 
2.7.4

Re: [PATCH 0/2] [media] rc/keymaps: add support for two RCs of hisilicon boards.

[Hans Verkuil]

On 10/18/2017 12:54 PM, Jiancheng Xue wrote:
> Add support for two remote controllers of hisilicon boards.
> 
> Younian Wang (2):
>   [media] rc/keymaps: add support for RC of hisilicon TV demo boards
>   [media] rc/keymaps: add support for RC of hisilicon poplar board
> 
>  drivers/media/rc/keymaps/Makefile          |  2 +
>  drivers/media/rc/keymaps/rc-hisi-poplar.c  | 58 +++++++++++++++++++++++++
>  drivers/media/rc/keymaps/rc-hisi-tv-demo.c | 70 ++++++++++++++++++++++++++++++
>  3 files changed, 130 insertions(+)
>  create mode 100644 drivers/media/rc/keymaps/rc-hisi-poplar.c
>  create mode 100644 drivers/media/rc/keymaps/rc-hisi-tv-demo.c
> 

Did you make a mistake? You reposted these two patches, but still without any
copyright statement...

I think something went wrong here.

Regards,

	Hans

Re: [PATCH 0/2] [media] rc/keymaps: add support for two RCs of hisilicon boards.

[Jiancheng Xue]

Hi Hans，

On 2017/10/19 15:01, Hans Verkuil wrote:
> On 10/18/2017 12:54 PM, Jiancheng Xue wrote:
>> Add support for two remote controllers of hisilicon boards.
>>
>> Younian Wang (2):
>>   [media] rc/keymaps: add support for RC of hisilicon TV demo boards
>>   [media] rc/keymaps: add support for RC of hisilicon poplar board
>>
>>  drivers/media/rc/keymaps/Makefile          |  2 +
>>  drivers/media/rc/keymaps/rc-hisi-poplar.c  | 58 +++++++++++++++++++++++++
>>  drivers/media/rc/keymaps/rc-hisi-tv-demo.c | 70 ++++++++++++++++++++++++++++++
>>  3 files changed, 130 insertions(+)
>>  create mode 100644 drivers/media/rc/keymaps/rc-hisi-poplar.c
>>  create mode 100644 drivers/media/rc/keymaps/rc-hisi-tv-demo.c
>>
> 
> Did you make a mistake? You reposted these two patches, but still without any
> copyright statement...
> 
> I think something went wrong here.
> 
I haven't reposted them so far. This is still the first version. I am waiting
to see if there are any more comments. If not, I can repost them soon.

Thank you.

Regards,
Jiancheng

Re: [PATCH 0/2] [media] rc/keymaps: add support for two RCs of hisilicon boards.

[Hans Verkuil]

On 10/19/2017 09:12 AM, Jiancheng Xue wrote:
> Hi Hans，
> 
> On 2017/10/19 15:01, Hans Verkuil wrote:
>> On 10/18/2017 12:54 PM, Jiancheng Xue wrote:
>>> Add support for two remote controllers of hisilicon boards.
>>>
>>> Younian Wang (2):
>>>   [media] rc/keymaps: add support for RC of hisilicon TV demo boards
>>>   [media] rc/keymaps: add support for RC of hisilicon poplar board
>>>
>>>  drivers/media/rc/keymaps/Makefile          |  2 +
>>>  drivers/media/rc/keymaps/rc-hisi-poplar.c  | 58 +++++++++++++++++++++++++
>>>  drivers/media/rc/keymaps/rc-hisi-tv-demo.c | 70 ++++++++++++++++++++++++++++++
>>>  3 files changed, 130 insertions(+)
>>>  create mode 100644 drivers/media/rc/keymaps/rc-hisi-poplar.c
>>>  create mode 100644 drivers/media/rc/keymaps/rc-hisi-tv-demo.c
>>>
>>
>> Did you make a mistake? You reposted these two patches, but still without any
>> copyright statement...
>>
>> I think something went wrong here.
>>
> I haven't reposted them so far. This is still the first version. I am waiting
> to see if there are any more comments. If not, I can repost them soon.

Ah, now I see why I got confused: something is wrong with the email dates: Sean's
reply has an earlier timestamp than your patch series. So I mistakenly thought
that the patch series was a v2 series.

Regards,

	Hans