* [PATCH 1/2] mtd: spi-nor: fix style issue
@ 2017-10-19 8:12 Philipp Puschmann
2017-10-29 19:54 ` Cyrille Pitchen
0 siblings, 1 reply; 2+ messages in thread
From: Philipp Puschmann @ 2017-10-19 8:12 UTC (permalink / raw)
To: linux-mtd; +Cc: pp
Fixed a space coding style issue, found via checkpatch.
Signed-off-by: Philipp Puschmann <pp@emlix.com>
---
drivers/mtd/spi-nor/spi-nor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index 19c000722cbc..386de64e5a86 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -964,7 +964,7 @@ static const struct flash_info spi_nor_ids[] = {
{ "f25l64qa", INFO(0x8c4117, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_HAS_LOCK) },
/* Everspin */
- { "mr25h256", CAT25_INFO( 32 * 1024, 1, 256, 2, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) },
+ { "mr25h256", CAT25_INFO(32 * 1024, 1, 256, 2, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) },
{ "mr25h10", CAT25_INFO(128 * 1024, 1, 256, 3, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) },
{ "mr25h40", CAT25_INFO(512 * 1024, 1, 256, 3, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) },
--
2.14.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] mtd: spi-nor: fix style issue
2017-10-19 8:12 [PATCH 1/2] mtd: spi-nor: fix style issue Philipp Puschmann
@ 2017-10-29 19:54 ` Cyrille Pitchen
0 siblings, 0 replies; 2+ messages in thread
From: Cyrille Pitchen @ 2017-10-29 19:54 UTC (permalink / raw)
To: Philipp Puschmann, linux-mtd
Hi Philipp
Le 19/10/2017 à 10:12, Philipp Puschmann a écrit :
> Fixed a space coding style issue, found via checkpatch.
>
> Signed-off-by: Philipp Puschmann <pp@emlix.com>
> ---
> drivers/mtd/spi-nor/spi-nor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 19c000722cbc..386de64e5a86 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -964,7 +964,7 @@ static const struct flash_info spi_nor_ids[] = {
> { "f25l64qa", INFO(0x8c4117, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_HAS_LOCK) },
>
> /* Everspin */
> - { "mr25h256", CAT25_INFO( 32 * 1024, 1, 256, 2, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) },
> + { "mr25h256", CAT25_INFO(32 * 1024, 1, 256, 2, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) },
Indeed, submitted patches should always pass the checkpatch test but
let's say entries of the spi_nor_ids[] are are exceptions here: it is
more easy to read if data are aligned hence I won't apply this patch.
Best regards,
Cyrille
> { "mr25h10", CAT25_INFO(128 * 1024, 1, 256, 3, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) },
> { "mr25h40", CAT25_INFO(512 * 1024, 1, 256, 3, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) },
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-29 19:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-19 8:12 [PATCH 1/2] mtd: spi-nor: fix style issue Philipp Puschmann
2017-10-29 19:54 ` Cyrille Pitchen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.