* [PATCH] panel: display: Add support for Mitsubishi aa070mc01 TFT panel
@ 2017-09-08 9:43 Lukasz Majewski
2017-09-24 21:18 ` Łukasz Majewski
2017-10-19 8:15 ` Thierry Reding
0 siblings, 2 replies; 5+ messages in thread
From: Lukasz Majewski @ 2017-09-08 9:43 UTC (permalink / raw)
To: Thierry Reding, David Airlie, dri-devel, linux-kernel; +Cc: Lukasz Majewski
This commit adds support for Mitsubishi aa070mc01 TFT panel working
with 8 bit ISP mode (pin 19 "mode" HIGH for 20 pin TFT connector).
Signed-off-by: Lukasz Majewski <lukma@denx.de>
---
drivers/gpu/drm/panel/panel-simple.c | 35 +++++++++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 3d2cb8b..0c64ec6 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1141,6 +1141,38 @@ static const struct panel_desc innolux_g121x1_l03 = {
},
};
+static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
+ .clock = 30400,
+ .hdisplay = 800,
+ .hsync_start = 800 + 0,
+ .hsync_end = 800 + 1,
+ .htotal = 800 + 0 + 1 + 160,
+ .vdisplay = 480,
+ .vsync_start = 480 + 0,
+ .vsync_end = 480 + 48 + 1,
+ .vtotal = 480 + 48 + 1 + 0,
+ .vrefresh = 60,
+ .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
+};
+
+static const struct panel_desc mitsubishi_aa070mc01 = {
+ .modes = &mitsubishi_aa070mc01_mode,
+ .num_modes = 1,
+ .bpc = 8,
+ .size = {
+ .width = 152,
+ .height = 91,
+ },
+
+ .delay = {
+ .enable = 200,
+ .unprepare = 200,
+ .disable = 400,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
+ .bus_flags = DRM_BUS_FLAG_DE_HIGH,
+};
+
static const struct drm_display_mode innolux_n116bge_mode = {
.clock = 76420,
.hdisplay = 1366,
@@ -2029,6 +2061,9 @@ static const struct of_device_id platform_of_match[] = {
.compatible = "innolux,g121x1-l03",
.data = &innolux_g121x1_l03,
}, {
+ .compatible = "mitsubishi,aa070mc01-ca1",
+ .data = &mitsubishi_aa070mc01,
+ }, {
.compatible = "innolux,n116bge",
.data = &innolux_n116bge,
}, {
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] panel: display: Add support for Mitsubishi aa070mc01 TFT panel
2017-09-08 9:43 [PATCH] panel: display: Add support for Mitsubishi aa070mc01 TFT panel Lukasz Majewski
@ 2017-09-24 21:18 ` Łukasz Majewski
2017-10-19 8:15 ` Thierry Reding
1 sibling, 0 replies; 5+ messages in thread
From: Łukasz Majewski @ 2017-09-24 21:18 UTC (permalink / raw)
To: Thierry Reding, David Airlie, dri-devel, linux-kernel
On 09/08/2017 11:43 AM, Lukasz Majewski wrote:
> This commit adds support for Mitsubishi aa070mc01 TFT panel working
> with 8 bit ISP mode (pin 19 "mode" HIGH for 20 pin TFT connector).
>
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
Gentle ping on this patch.....
Anyone could express their opinion?
Thanks in advance,
Łukasz
> ---
> drivers/gpu/drm/panel/panel-simple.c | 35 +++++++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 3d2cb8b..0c64ec6 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1141,6 +1141,38 @@ static const struct panel_desc innolux_g121x1_l03 = {
> },
> };
>
> +static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
> + .clock = 30400,
> + .hdisplay = 800,
> + .hsync_start = 800 + 0,
> + .hsync_end = 800 + 1,
> + .htotal = 800 + 0 + 1 + 160,
> + .vdisplay = 480,
> + .vsync_start = 480 + 0,
> + .vsync_end = 480 + 48 + 1,
> + .vtotal = 480 + 48 + 1 + 0,
> + .vrefresh = 60,
> + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> +};
> +
> +static const struct panel_desc mitsubishi_aa070mc01 = {
> + .modes = &mitsubishi_aa070mc01_mode,
> + .num_modes = 1,
> + .bpc = 8,
> + .size = {
> + .width = 152,
> + .height = 91,
> + },
> +
> + .delay = {
> + .enable = 200,
> + .unprepare = 200,
> + .disable = 400,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> + .bus_flags = DRM_BUS_FLAG_DE_HIGH,
> +};
> +
> static const struct drm_display_mode innolux_n116bge_mode = {
> .clock = 76420,
> .hdisplay = 1366,
> @@ -2029,6 +2061,9 @@ static const struct of_device_id platform_of_match[] = {
> .compatible = "innolux,g121x1-l03",
> .data = &innolux_g121x1_l03,
> }, {
> + .compatible = "mitsubishi,aa070mc01-ca1",
> + .data = &mitsubishi_aa070mc01,
> + }, {
> .compatible = "innolux,n116bge",
> .data = &innolux_n116bge,
> }, {
>
--
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] panel: display: Add support for Mitsubishi aa070mc01 TFT panel
2017-09-08 9:43 [PATCH] panel: display: Add support for Mitsubishi aa070mc01 TFT panel Lukasz Majewski
@ 2017-10-19 8:15 ` Thierry Reding
2017-10-19 8:15 ` Thierry Reding
1 sibling, 0 replies; 5+ messages in thread
From: Thierry Reding @ 2017-10-19 8:15 UTC (permalink / raw)
To: Lukasz Majewski; +Cc: David Airlie, dri-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1997 bytes --]
On Fri, Sep 08, 2017 at 11:43:02AM +0200, Lukasz Majewski wrote:
> This commit adds support for Mitsubishi aa070mc01 TFT panel working
> with 8 bit ISP mode (pin 19 "mode" HIGH for 20 pin TFT connector).
>
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 35 +++++++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
This is missing a device tree binding.
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 3d2cb8b..0c64ec6 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1141,6 +1141,38 @@ static const struct panel_desc innolux_g121x1_l03 = {
> },
> };
>
> +static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
> + .clock = 30400,
> + .hdisplay = 800,
> + .hsync_start = 800 + 0,
> + .hsync_end = 800 + 1,
> + .htotal = 800 + 0 + 1 + 160,
> + .vdisplay = 480,
> + .vsync_start = 480 + 0,
> + .vsync_end = 480 + 48 + 1,
> + .vtotal = 480 + 48 + 1 + 0,
> + .vrefresh = 60,
> + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> +};
> +
> +static const struct panel_desc mitsubishi_aa070mc01 = {
> + .modes = &mitsubishi_aa070mc01_mode,
> + .num_modes = 1,
> + .bpc = 8,
> + .size = {
> + .width = 152,
> + .height = 91,
> + },
> +
> + .delay = {
> + .enable = 200,
> + .unprepare = 200,
> + .disable = 400,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> + .bus_flags = DRM_BUS_FLAG_DE_HIGH,
> +};
And this isn't sorted properly.
> +
> static const struct drm_display_mode innolux_n116bge_mode = {
> .clock = 76420,
> .hdisplay = 1366,
> @@ -2029,6 +2061,9 @@ static const struct of_device_id platform_of_match[] = {
> .compatible = "innolux,g121x1-l03",
> .data = &innolux_g121x1_l03,
> }, {
> + .compatible = "mitsubishi,aa070mc01-ca1",
> + .data = &mitsubishi_aa070mc01,
> + }, {
Same here.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] panel: display: Add support for Mitsubishi aa070mc01 TFT panel
@ 2017-10-19 8:15 ` Thierry Reding
0 siblings, 0 replies; 5+ messages in thread
From: Thierry Reding @ 2017-10-19 8:15 UTC (permalink / raw)
To: Lukasz Majewski; +Cc: linux-kernel, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 1997 bytes --]
On Fri, Sep 08, 2017 at 11:43:02AM +0200, Lukasz Majewski wrote:
> This commit adds support for Mitsubishi aa070mc01 TFT panel working
> with 8 bit ISP mode (pin 19 "mode" HIGH for 20 pin TFT connector).
>
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 35 +++++++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
This is missing a device tree binding.
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 3d2cb8b..0c64ec6 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1141,6 +1141,38 @@ static const struct panel_desc innolux_g121x1_l03 = {
> },
> };
>
> +static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
> + .clock = 30400,
> + .hdisplay = 800,
> + .hsync_start = 800 + 0,
> + .hsync_end = 800 + 1,
> + .htotal = 800 + 0 + 1 + 160,
> + .vdisplay = 480,
> + .vsync_start = 480 + 0,
> + .vsync_end = 480 + 48 + 1,
> + .vtotal = 480 + 48 + 1 + 0,
> + .vrefresh = 60,
> + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> +};
> +
> +static const struct panel_desc mitsubishi_aa070mc01 = {
> + .modes = &mitsubishi_aa070mc01_mode,
> + .num_modes = 1,
> + .bpc = 8,
> + .size = {
> + .width = 152,
> + .height = 91,
> + },
> +
> + .delay = {
> + .enable = 200,
> + .unprepare = 200,
> + .disable = 400,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> + .bus_flags = DRM_BUS_FLAG_DE_HIGH,
> +};
And this isn't sorted properly.
> +
> static const struct drm_display_mode innolux_n116bge_mode = {
> .clock = 76420,
> .hdisplay = 1366,
> @@ -2029,6 +2061,9 @@ static const struct of_device_id platform_of_match[] = {
> .compatible = "innolux,g121x1-l03",
> .data = &innolux_g121x1_l03,
> }, {
> + .compatible = "mitsubishi,aa070mc01-ca1",
> + .data = &mitsubishi_aa070mc01,
> + }, {
Same here.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] panel: display: Add support for Mitsubishi aa070mc01 TFT panel
2017-10-19 8:15 ` Thierry Reding
(?)
@ 2017-10-19 19:25 ` Lukasz Majewski
-1 siblings, 0 replies; 5+ messages in thread
From: Lukasz Majewski @ 2017-10-19 19:25 UTC (permalink / raw)
To: Thierry Reding; +Cc: David Airlie, dri-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2531 bytes --]
HI Thierry,
> On Fri, Sep 08, 2017 at 11:43:02AM +0200, Lukasz Majewski wrote:
> > This commit adds support for Mitsubishi aa070mc01 TFT panel working
> > with 8 bit ISP mode (pin 19 "mode" HIGH for 20 pin TFT connector).
> >
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > ---
> > drivers/gpu/drm/panel/panel-simple.c | 35
> > +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+)
>
> This is missing a device tree binding.
>
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c
> > b/drivers/gpu/drm/panel/panel-simple.c index 3d2cb8b..0c64ec6 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -1141,6 +1141,38 @@ static const struct panel_desc
> > innolux_g121x1_l03 = { },
> > };
> >
> > +static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
> > + .clock = 30400,
> > + .hdisplay = 800,
> > + .hsync_start = 800 + 0,
> > + .hsync_end = 800 + 1,
> > + .htotal = 800 + 0 + 1 + 160,
> > + .vdisplay = 480,
> > + .vsync_start = 480 + 0,
> > + .vsync_end = 480 + 48 + 1,
> > + .vtotal = 480 + 48 + 1 + 0,
> > + .vrefresh = 60,
> > + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> > +};
> > +
> > +static const struct panel_desc mitsubishi_aa070mc01 = {
> > + .modes = &mitsubishi_aa070mc01_mode,
> > + .num_modes = 1,
> > + .bpc = 8,
> > + .size = {
> > + .width = 152,
> > + .height = 91,
> > + },
> > +
> > + .delay = {
> > + .enable = 200,
> > + .unprepare = 200,
> > + .disable = 400,
> > + },
> > + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> > + .bus_flags = DRM_BUS_FLAG_DE_HIGH,
> > +};
>
> And this isn't sorted properly.
>
> > +
> > static const struct drm_display_mode innolux_n116bge_mode = {
> > .clock = 76420,
> > .hdisplay = 1366,
> > @@ -2029,6 +2061,9 @@ static const struct of_device_id
> > platform_of_match[] = { .compatible = "innolux,g121x1-l03",
> > .data = &innolux_g121x1_l03,
> > }, {
> > + .compatible = "mitsubishi,aa070mc01-ca1",
> > + .data = &mitsubishi_aa070mc01,
> > + }, {
>
> Same here.
>
> Thierry
I will prepare ./Documentation/device-tree description for this patch
and sort those entries.
Thanks for your comments :-)
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-19 19:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-08 9:43 [PATCH] panel: display: Add support for Mitsubishi aa070mc01 TFT panel Lukasz Majewski
2017-09-24 21:18 ` Łukasz Majewski
2017-10-19 8:15 ` Thierry Reding
2017-10-19 8:15 ` Thierry Reding
2017-10-19 19:25 ` Lukasz Majewski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.