All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Rob Herring <robh@kernel.org>
Cc: Eugen Hristev <eugen.hristev@microchip.com>,
	nicolas.ferre@microchip.com, linux-iio@vger.kernel.org,
	lars@metafoo.de, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	ludovic.desroches@microchip.com, jic23@kernel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: iio: at91-sama5d2_adc: add optional dma property
Date: Thu, 19 Oct 2017 13:14:17 +0200	[thread overview]
Message-ID: <20171019111417.7rzdnkvtukzzhl2u@piout.net> (raw)
In-Reply-To: <20171013215142.vlfhzzzetmc7resq@rob-hp-laptop>

On 13/10/2017 at 16:51:42 -0500, Rob Herring wrote:
> On Wed, Oct 11, 2017 at 09:35:28AM +0300, Eugen Hristev wrote:
> > Added property for DMA configuration of the device.
> > 
> > Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> > ---
> >  Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt b/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt
> > index 552e7a8..5f94d479 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt
> > +++ b/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt
> > @@ -17,6 +17,11 @@ Required properties:
> >    This property uses the IRQ edge types values: IRQ_TYPE_EDGE_RISING ,
> >    IRQ_TYPE_EDGE_FALLING or IRQ_TYPE_EDGE_BOTH
> >  
> > +Optional properties:
> > +  - dmas: Phandle to dma channel for the ADC.
> > +  See ../../dma/dma.txt for details.
> > +  - dma-names: Must be "rx" when dmas property is being used.
> 
> -names is pointless when there is only one.
> 

You didn't reply to the question I had previously about that: What if at
some point, we have multiple dmas in the same binding?

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/5] dt-bindings: iio: at91-sama5d2_adc: add optional dma property
Date: Thu, 19 Oct 2017 13:14:17 +0200	[thread overview]
Message-ID: <20171019111417.7rzdnkvtukzzhl2u@piout.net> (raw)
In-Reply-To: <20171013215142.vlfhzzzetmc7resq@rob-hp-laptop>

On 13/10/2017 at 16:51:42 -0500, Rob Herring wrote:
> On Wed, Oct 11, 2017 at 09:35:28AM +0300, Eugen Hristev wrote:
> > Added property for DMA configuration of the device.
> > 
> > Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> > ---
> >  Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt b/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt
> > index 552e7a8..5f94d479 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt
> > +++ b/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt
> > @@ -17,6 +17,11 @@ Required properties:
> >    This property uses the IRQ edge types values: IRQ_TYPE_EDGE_RISING ,
> >    IRQ_TYPE_EDGE_FALLING or IRQ_TYPE_EDGE_BOTH
> >  
> > +Optional properties:
> > +  - dmas: Phandle to dma channel for the ADC.
> > +  See ../../dma/dma.txt for details.
> > +  - dma-names: Must be "rx" when dmas property is being used.
> 
> -names is pointless when there is only one.
> 

You didn't reply to the question I had previously about that: What if at
some point, we have multiple dmas in the same binding?

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-10-19 11:14 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-11  6:35 [PATCH v2 0/5] iio: adc: at91-sama5d2_adc: add DMA support Eugen Hristev
2017-10-11  6:35 ` Eugen Hristev
2017-10-11  6:35 ` Eugen Hristev
2017-10-11  6:35 ` [PATCH v2 1/5] dt-bindings: iio: at91-sama5d2_adc: add optional dma property Eugen Hristev
2017-10-11  6:35   ` Eugen Hristev
2017-10-11  6:35   ` Eugen Hristev
2017-10-13 21:51   ` Rob Herring
2017-10-13 21:51     ` Rob Herring
2017-10-19 11:14     ` Alexandre Belloni [this message]
2017-10-19 11:14       ` Alexandre Belloni
2017-10-19 21:58       ` Rob Herring
2017-10-19 21:58         ` Rob Herring
2017-10-19 21:58         ` Rob Herring
2017-10-19 21:58         ` Rob Herring
2017-11-07  8:49         ` Eugen Hristev
2017-11-07  8:49           ` Eugen Hristev
2017-11-07  8:49           ` Eugen Hristev
2017-11-07  8:49           ` Eugen Hristev
2017-11-07  9:02           ` Ludovic Desroches
2017-11-07  9:02             ` Ludovic Desroches
2017-11-07  9:02             ` Ludovic Desroches
2017-10-11  6:35 ` [PATCH v2 2/5] ARM: dts: at91: sama5d2: added dma property for ADC device Eugen Hristev
2017-10-11  6:35   ` Eugen Hristev
2017-10-11  6:35   ` Eugen Hristev
2017-10-11  6:35 ` [PATCH v2 3/5] iio: adc: at91-sama5d2_adc: add support for DMA Eugen Hristev
2017-10-11  6:35   ` Eugen Hristev
2017-10-11  6:35   ` Eugen Hristev
2017-10-15 10:16   ` Jonathan Cameron
2017-10-15 10:16     ` Jonathan Cameron
2017-10-15 10:16     ` Jonathan Cameron
2017-10-11  6:35 ` [PATCH v2 4/5] iio: adc: at91-sama5d2_adc: ack DRDY irq in direct mode Eugen Hristev
2017-10-11  6:35   ` Eugen Hristev
2017-10-11  6:35   ` Eugen Hristev
2017-10-11  6:35 ` [PATCH v2 5/5] iio: adc: at91-sama5d2_adc: use max sample rate Eugen Hristev
2017-10-11  6:35   ` Eugen Hristev
2017-10-11  6:35   ` Eugen Hristev
2017-10-15 10:28   ` Jonathan Cameron
2017-10-15 10:28     ` Jonathan Cameron
2017-10-15 10:28     ` Jonathan Cameron
2017-10-18  8:49     ` Eugen Hristev
2017-10-18  8:49       ` Eugen Hristev
2017-10-18  8:49       ` Eugen Hristev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171019111417.7rzdnkvtukzzhl2u@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=eugen.hristev@microchip.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.