All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: "Johan Hovold" <johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Greg Kroah-Hartman"
	<greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>,
	"Frédéric Danis"
	<frederic.danis.oss-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"Marcel Holtmann"
	<marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>,
	"Rafael J. Wysocki"
	<rafael-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Rob Herring" <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Sebastian Reichel" <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Loic Poulain"
	<loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"Lukas Wunner" <lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>,
	"open list:BLUETOOTH DRIVERS"
	<linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"ACPI Devel Maling List"
	<linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v3 0/2] ACPI serdev support
Date: Thu, 19 Oct 2017 16:32:41 +0200	[thread overview]
Message-ID: <20171019143241.GF5638@localhost> (raw)
In-Reply-To: <877ea825-eec5-d982-f962-d67067749009-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On Thu, Oct 19, 2017 at 04:26:25PM +0200, Hans de Goede wrote:
> Hi,
> 
> On 19-10-17 16:23, Johan Hovold wrote:
> > On Wed, Oct 18, 2017 at 04:56:08PM +0200, Greg Kroah-Hartman wrote:
> >> On Wed, Oct 18, 2017 at 04:46:05PM +0200, Frédéric Danis wrote:
> > 
> >>> Le 11/10/2017 à 20:32, Marcel Holtmann a écrit :
> > 
> >>>>>>> Add ACPI support for serial attached devices.
> >>>>>>>
> >>>>>>> Currently, serial devices are not set as enumerated during
> >>>>>>> ACPI scan for SPI or i2c buses (but not for UART). This
> >>>>>>> should also be done for UART serial devices.  I renamed
> >>>>>>> *spi_i2c_slave* to *serial_bus_slave* to reflect this.

> > I just realised that we cannot merge this series (the second acpi patch)
> > until the hci_intel driver gains serdev support or otherwise PM will
> > break for those devices.
> > 
> > Specifically, the hci_intel driver uses similar hacks as the hci_bcm
> > driver does for PM, so we need something like Hans's hci_bcm series also
> > for hci_intel before we can do the switch.
> 
> Hmm, I've never actually seen any hardware use an intel BT HCI connected
> to a serdev, but I guess people did not write that code for fun, so those
> do exist ?

At least that's what it looks like. 

It was added by Loic Poulain in commit 1ab1f239bf17 ("Bluetooth:
hci_intel: Add support for platform driver") two years ago and the
ACPI-match table has an entry for "INT33E1".

Johan

WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Johan Hovold" <johan@kernel.org>,
	"Greg Kroah-Hartman" <greg@kroah.com>,
	"Frédéric Danis" <frederic.danis.oss@gmail.com>,
	"Marcel Holtmann" <marcel@holtmann.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Sebastian Reichel" <sre@kernel.org>,
	"Loic Poulain" <loic.poulain@gmail.com>,
	"Lukas Wunner" <lukas@wunner.de>,
	"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"ACPI Devel Maling List" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v3 0/2] ACPI serdev support
Date: Thu, 19 Oct 2017 16:32:41 +0200	[thread overview]
Message-ID: <20171019143241.GF5638@localhost> (raw)
In-Reply-To: <877ea825-eec5-d982-f962-d67067749009@redhat.com>

On Thu, Oct 19, 2017 at 04:26:25PM +0200, Hans de Goede wrote:
> Hi,
> 
> On 19-10-17 16:23, Johan Hovold wrote:
> > On Wed, Oct 18, 2017 at 04:56:08PM +0200, Greg Kroah-Hartman wrote:
> >> On Wed, Oct 18, 2017 at 04:46:05PM +0200, Frédéric Danis wrote:
> > 
> >>> Le 11/10/2017 à 20:32, Marcel Holtmann a écrit :
> > 
> >>>>>>> Add ACPI support for serial attached devices.
> >>>>>>>
> >>>>>>> Currently, serial devices are not set as enumerated during
> >>>>>>> ACPI scan for SPI or i2c buses (but not for UART). This
> >>>>>>> should also be done for UART serial devices.  I renamed
> >>>>>>> *spi_i2c_slave* to *serial_bus_slave* to reflect this.

> > I just realised that we cannot merge this series (the second acpi patch)
> > until the hci_intel driver gains serdev support or otherwise PM will
> > break for those devices.
> > 
> > Specifically, the hci_intel driver uses similar hacks as the hci_bcm
> > driver does for PM, so we need something like Hans's hci_bcm series also
> > for hci_intel before we can do the switch.
> 
> Hmm, I've never actually seen any hardware use an intel BT HCI connected
> to a serdev, but I guess people did not write that code for fun, so those
> do exist ?

At least that's what it looks like. 

It was added by Loic Poulain in commit 1ab1f239bf17 ("Bluetooth:
hci_intel: Add support for platform driver") two years ago and the
ACPI-match table has an entry for "INT33E1".

Johan

  parent reply	other threads:[~2017-10-19 14:32 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-11  8:32 [PATCH v3 0/2] ACPI serdev support Frédéric Danis
2017-10-11  8:32 ` Frédéric Danis
     [not found] ` <1507710734-32520-1-git-send-email-frederic.danis.oss-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-10-11  8:32   ` [PATCH v3 1/2] serdev: Add ACPI support Frédéric Danis
2017-10-11  8:32     ` Frédéric Danis
2017-10-11  8:43     ` Johan Hovold
2017-10-11  8:32 ` [PATCH v3 2/2] ACPI / scan: Fix enumeration for special UART devices Frédéric Danis
2017-10-15  9:57   ` Lukas Wunner
     [not found]   ` <1507710734-32520-3-git-send-email-frederic.danis.oss-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-31 14:21     ` [v3,2/2] " Graeme Gregory
2018-01-31 14:21       ` Graeme Gregory
2018-02-02 10:03       ` Frédéric Danis
2018-02-02 10:03         ` Frédéric Danis
2018-02-02 15:28         ` Graeme Gregory
2017-10-11  9:03 ` [PATCH v3 0/2] ACPI serdev support Johan Hovold
2017-10-11 13:09   ` Rafael J. Wysocki
2017-10-11 13:09     ` Rafael J. Wysocki
2017-10-11 18:32     ` Marcel Holtmann
2017-10-11 18:32       ` Marcel Holtmann
2017-10-18 14:46       ` Frédéric Danis
2017-10-18 14:56         ` Greg Kroah-Hartman
     [not found]           ` <20171018145608.GB27138-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-10-19 14:23             ` Johan Hovold
2017-10-19 14:23               ` Johan Hovold
2017-10-19 14:26               ` Hans de Goede
2017-10-19 14:32                 ` Marcel Holtmann
2017-10-19 14:56                   ` Hans de Goede
2017-10-19 16:15                     ` Loic Poulain
     [not found]                       ` <CAMZdPi_ZpNrdjJPnS_rQ9t3oYe6+en9oHQMjmMjx_xHL-WWZKQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-19 18:50                         ` Hans de Goede
2017-10-19 18:50                           ` Hans de Goede
2017-10-19 19:00                           ` Marcel Holtmann
     [not found]                             ` <FFD85CA6-6BD9-45AA-B3C2-898212711C0C-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org>
2017-10-19 19:05                               ` Hans de Goede
2017-10-19 19:05                                 ` Hans de Goede
2017-10-21  9:59                             ` Johan Hovold
     [not found]                 ` <877ea825-eec5-d982-f962-d67067749009-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-10-19 14:32                   ` Johan Hovold [this message]
2017-10-19 14:32                     ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171019143241.GF5638@localhost \
    --to=johan-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=frederic.danis.oss-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org \
    --cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-bluetooth-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=loic.poulain-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org \
    --cc=marcel-kz+m5ild9QBg9hUCZPvPmw@public.gmane.org \
    --cc=rafael-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.