From: Cornelia Huck <cohuck@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
Alexander Graf <agraf@suse.de>, Thomas Huth <thuth@redhat.com>,
David Hildenbrand <david@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Bjoern Walk <bwalk@linux.vnet.ibm.com>,
Pierre Morel <pmorel@linux.vnet.ibm.com>,
Halil Pasic <pasic@linux.vnet.ibm.com>,
"Jason J . Herne" <jjherne@linux.vnet.ibm.com>,
"Collin L. Walling" <walling@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] s390-ccw: print carriage return with new lines
Date: Fri, 20 Oct 2017 14:41:55 +0200 [thread overview]
Message-ID: <20171020144155.11f7e549.cohuck@redhat.com> (raw)
In-Reply-To: <83d262ee-47e8-61c7-77cd-bbfc53d692c5@de.ibm.com>
On Fri, 20 Oct 2017 14:27:12 +0200
Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> On 10/20/2017 01:31 PM, Cornelia Huck wrote:
> > On Fri, 20 Oct 2017 12:25:17 +0200
> > Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> >
> >> From: "Collin L. Walling" <walling@linux.vnet.ibm.com>
> >>
> >> The sclp console in the s390 bios writes raw data,
> >> leading console emulators (such as virsh console) to
> >> treat a new line ('\n') as just a new line instead
> >> of as a Unix line feed. Because of this, output
> >> appears in a "stair case" pattern.
> >>
> >> Let's print \r\n on every occurrence of a new line
> >> in the string passed to write to amend this issue.
> >>
> >> This is in sync with the guest Linux code in
> >> drivers/s390/char/sclp_vt220.c which also does a line feed
> >> conversion in the console part of the driver.
> >>
> >> This fixes the s390-ccw and s390-netboot output like
> >> $ virsh start test --console
> >> Domain test started
> >> Connected to domain test
> >> Escape character is ^]
> >> Network boot starting...
> >> Using MAC address: 02:01:02:03:04:05
> >> Requesting information via DHCP: 010
> >>
> >> Signed-off-by: Collin L. Walling <walling@linux.vnet.ibm.com>
> >> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> >> ---
> >> pc-bios/s390-ccw/s390-ccw.h | 3 +++
> >> pc-bios/s390-ccw/sclp.c | 17 ++++++++++++++---
> >> 2 files changed, 17 insertions(+), 3 deletions(-)
> >
> > I'd defer that to a second pullreq before softfreeze where we can
> > collect the stragglers (currently building a pullreq). And I'd also
> > like to delegate that second pullreq to you, as I'll be busy/offline
> > after KVM Forum.
>
> Sure I can do that in a 2nd pull req after KVM forum.
>
Cool, thx.
next prev parent reply other threads:[~2017-10-20 12:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 10:25 [Qemu-devel] [PATCH] s390-ccw: print carriage return with new lines Christian Borntraeger
2017-10-20 10:30 ` Alexander Graf
2017-10-20 10:41 ` Christian Borntraeger
2017-10-20 11:02 ` Christian Borntraeger
2017-10-20 11:09 ` Alexander Graf
2017-10-20 11:18 ` Christian Borntraeger
2017-10-20 11:28 ` Thomas Huth
2017-10-20 13:48 ` Farhan Ali
2017-10-25 5:55 ` Christian Borntraeger
2017-10-20 11:31 ` Cornelia Huck
2017-10-20 12:27 ` Christian Borntraeger
2017-10-20 12:41 ` Cornelia Huck [this message]
2017-10-20 11:37 ` Halil Pasic
2017-10-25 19:49 ` Collin L. Walling
2017-10-25 22:24 ` Halil Pasic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171020144155.11f7e549.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=bwalk@linux.vnet.ibm.com \
--cc=david@redhat.com \
--cc=jjherne@linux.vnet.ibm.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=pmorel@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
--cc=walling@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.