From: Farhan Ali <alifm@linux.vnet.ibm.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
Alexander Graf <agraf@suse.de>, Cornelia Huck <cohuck@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
Bjoern Walk <bwalk@linux.vnet.ibm.com>,
David Hildenbrand <david@redhat.com>,
Pierre Morel <pmorel@linux.vnet.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>,
Halil Pasic <pasic@linux.vnet.ibm.com>,
"Jason J . Herne" <jjherne@linux.vnet.ibm.com>,
"Collin L. Walling" <walling@linux.vnet.ibm.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] s390-ccw: print carriage return with new lines
Date: Fri, 20 Oct 2017 09:48:22 -0400 [thread overview]
Message-ID: <9292cbd5-49b5-c9da-cc34-33466818a02e@linux.vnet.ibm.com> (raw)
In-Reply-To: <b4a828b6-b563-55f0-2952-8a3447a8a30a@de.ibm.com>
On 10/20/2017 07:02 AM, Christian Borntraeger wrote:
> --- a/pc-bios/s390-ccw/sclp.c
> +++ b/pc-bios/s390-ccw/sclp.c
> @@ -83,7 +83,7 @@ long write(int fd, const void *str, size_t len)
> return -EIO;
> }
>
> - for (p = str; *p; ++p) {
> + for (p = str; len ; ++p, len--) {
> if (data_len > SCCB_DATA_LEN - 1) {
> return -EFBIG;
> }
>
>
>
The write function returns len, wouldn't this change make write return 0?
next prev parent reply other threads:[~2017-10-20 13:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 10:25 [Qemu-devel] [PATCH] s390-ccw: print carriage return with new lines Christian Borntraeger
2017-10-20 10:30 ` Alexander Graf
2017-10-20 10:41 ` Christian Borntraeger
2017-10-20 11:02 ` Christian Borntraeger
2017-10-20 11:09 ` Alexander Graf
2017-10-20 11:18 ` Christian Borntraeger
2017-10-20 11:28 ` Thomas Huth
2017-10-20 13:48 ` Farhan Ali [this message]
2017-10-25 5:55 ` Christian Borntraeger
2017-10-20 11:31 ` Cornelia Huck
2017-10-20 12:27 ` Christian Borntraeger
2017-10-20 12:41 ` Cornelia Huck
2017-10-20 11:37 ` Halil Pasic
2017-10-25 19:49 ` Collin L. Walling
2017-10-25 22:24 ` Halil Pasic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9292cbd5-49b5-c9da-cc34-33466818a02e@linux.vnet.ibm.com \
--to=alifm@linux.vnet.ibm.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=bwalk@linux.vnet.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=jjherne@linux.vnet.ibm.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=pmorel@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
--cc=walling@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.